Received-SPF: pass (google.com: domain of linux-kernel+bounces-213928-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Thu, 13 Jun 2024 21:33:01 +0200
From: Andrew Lunn <andrew@lunn.ch>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
	Russell King <linux@armlinux.org.uk>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	stable@vger.kernel.org, kernel@pengutronix.de,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net v1 2/2] net: phy: dp83tg720: get initial master/slave
 configuration
Message-ID: <f88abfe3-a66c-4e65-b627-7adf7f04580f@lunn.ch>
References: <20240613183034.2407798-1-o.rempel@pengutronix.de>
 <20240613183034.2407798-2-o.rempel@pengutronix.de>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240613183034.2407798-2-o.rempel@pengutronix.de>

On Thu, Jun 13, 2024 at 08:30:34PM +0200, Oleksij Rempel wrote:
> Get initial master/slave configuration, otherwise ethtool
> wont be able to provide this information until link is
> established. This makes troubleshooting harder, since wrong
> role configuration would prevent the link start.

I looked at how genphy_c45_read_status() works. If we have
phydev->autoneg == AUTONEG_ENABLE then genphy_c45_baset1_read_status()
is called which sets phydev->master_slave_get. If not AUTONEG_ENABLE
it calls genphy_c45_read_pma() which ends up calling
genphy_c45_pma_baset1_read_master_slave().

So it seems like the .read_status op should be setting master/slave
each time it is called, and not one time during .config_init.

What do you think?

    Andrew