Received: by 2002:a89:413:0:b0:1fd:dba5:e537 with SMTP id m19csp398643lqs; Thu, 13 Jun 2024 13:19:59 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCU3ZHbKDugfI5X+e2z/YrNZUv4gqz0Z4IVOvfxgOHZQMBgp+tzU+Mxs4W7gRvtnaebEKLR+WU+ljmM9ZDgQhaQuKudZQGR3TeGcpxeSrg== X-Google-Smtp-Source: AGHT+IFOGS5oJCj485xj1SnUgqN3LsCvSYbju8S+V0DYgJ1Qvt4oybH9M5zpCox7WA+BIbUVqdPi X-Received: by 2002:a05:6808:1810:b0:3d2:3873:6625 with SMTP id 5614622812f47-3d24e8f2970mr826900b6e.25.1718309998954; Thu, 13 Jun 2024 13:19:58 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1718309998; cv=pass; d=google.com; s=arc-20160816; b=p9XwVXqScpeEyvVmbkY7gWcnyUhprzQKYol0yisolHO0tC0ZmnKdZQXOtYQv2vVwWB zNNxXbKGa9PmgXWrVKwrwaYVmO4UXxgeQcFLspsHsf/0095W9vBhXNZ8C+c6QepeMgn9 fDN8pYmKbtWUXmXWtywSDarOVPvEGKzsSNLqYHlnQi4sVDbbpFDXiXjlwbUJS8JJh7Y+ y46TMfsGTSnZNoQAlC9VsXJ7Rnc00O/H778/ohUBLkoy+bKWHeGABTdsMgN5OdI1XOg8 wp2EDqAijBCEEBpP7sz4FNhhv1+tHJO546a2LCKN7rw7PH3BMISE6ddAnmYIwC/i0+YJ CzeQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=Wx6jOPXztgYs/zdxpsoEV9iH4lRhvPv83o7h0HWZtgg=; fh=yIN4OAxC6zK628YWFP0SZETQr7Ryk1QkyB+UIm7k9bg=; b=YULOMJq/FJGmqCIzh4CLJJo5RvvjVLl6ye1j+oOroFqwCpADjBZ5kdlde8G96R2ccW YLdlddQ8/3bc57Hk3pgaierrxl1Cn21ENx19kbgfUHhlUCs3/X9sJ7SOu+mhc1qqqu7V psFShxfYK9ymsc4WEFDUXhBWXOEU5QfSe4pM0RKZoDoJ5K1nas0E2paXxfFQ6eO0x5ZC +1IgHebeczFnkZ79FHI/FKCgXflR+Eq8DpntJtn+YOwrOJQknND8lxkVC/sO27ZvK9Dd 3BhZCnG+ZFSs4A7iotGOZzY9bq6mYVv7uIasLUx2vKU7PFSUXJ5oNzwWy1UuMqopclKP rfXg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b="Bf5/YajK"; arc=pass (i=1 dkim=pass dkdomain=linux-foundation.org); spf=pass (google.com: domain of linux-kernel+bounces-213987-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-213987-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id d75a77b69052e-441f311d6e3si14364701cf.778.2024.06.13.13.19.58 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Jun 2024 13:19:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-213987-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b="Bf5/YajK"; arc=pass (i=1 dkim=pass dkdomain=linux-foundation.org); spf=pass (google.com: domain of linux-kernel+bounces-213987-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-213987-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id A6A261C22D9E for ; Thu, 13 Jun 2024 20:19:58 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 62675145B0B; Thu, 13 Jun 2024 20:18:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="Bf5/YajK" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7594513C9CF; Thu, 13 Jun 2024 20:18:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718309935; cv=none; b=AAlbo2O/B0l4rtp0nN0pfK6vey/s8O2iMYMM8P0WDv7Wk+Kvsp9W+vZO8u1XD01S94cvzz7FcdJFmrkJI7+40rynJjSf+hQFm7GyfUny6w6lZDYghEq+mPcqO7CQly6Qzay+LHnpeyoEfem1c7HlvkNKYc/gvbO4LTv7zNiiFSU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718309935; c=relaxed/simple; bh=tZkWlPzsEIJD0w2s0YudkX0DW+VefZKFhtp6mC0r2IU=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=bH1KIwVsF6aM7kLlToKsks7wolV3AbQJlljAUG2hY+rYlyzO5jZ6WUb74YacGL/Jh3WX9DFII66EtQ+CNJWDlKZnmjNoQdwPr0dGeX2AfGk8R85UGjL4El2/ZCFu+C3Uk/z2pXoO+cJq8aL9QpNDLFyzRmhnERwE9+d7eUIir6o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=Bf5/YajK; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8D924C32786; Thu, 13 Jun 2024 20:18:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1718309935; bh=tZkWlPzsEIJD0w2s0YudkX0DW+VefZKFhtp6mC0r2IU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Bf5/YajKc4bfbaMnNBJtRIpnDJlNphOAbPvgJhaNCxXLBU5O1cF2Vv2cdDksmwZ8t 24wyy/nVoSssXL2C+IQDaESgQcRd2hVNQwRF4vQZqJDdiaf4+wuo3rN8uEqqqzl1Et OW0XOY8HY+vtdqMwTvzMuRNA1pMauFSPHlAQ5qao= Date: Thu, 13 Jun 2024 13:18:53 -0700 From: Andrew Morton To: Uladzislau Rezki Cc: "zhaoyang.huang" , Christoph Hellwig , Lorenzo Stoakes , Baoquan He , Thomas Gleixner , hailong liu , linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Zhaoyang Huang , steve.kang@unisoc.com Subject: Re: [Resend PATCHv4 1/1] mm: fix incorrect vbq reference in purge_fragmented_block Message-Id: <20240613131853.814a40233d36d57f868f9a39@linux-foundation.org> In-Reply-To: References: <20240607023116.1720640-1-zhaoyang.huang@unisoc.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 13 Jun 2024 19:33:16 +0200 Uladzislau Rezki wrote: > > 2.25.1 > > > Yes there is a mess with holding wrong vbq->lock and vmap_blocks xarray. > > The patch looks good to me. One small nit from my side is a commit > message. To me it is vague and it should be improved. > > Could you please use Hailong.Liu explanation > of the issue and resend the patch? > > See it here: https://lkml.org/lkml/2024/6/2/2 > > Reviewed-by: Uladzislau Rezki (Sony) Thanks, I'll queue this (with a cc:stable) for testing and shall await the updated changelog.