Received-SPF: pass (google.com: domain of linux-kernel+bounces-213997-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <bc52a051-4296-48ac-9a83-29139855553f@intel.com>
Date: Thu, 13 Jun 2024 13:32:10 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v20 00/18] Add support for Sub-NUMA cluster (SNC) systems
To: <babu.moger@amd.com>, Tony Luck <tony.luck@intel.com>, Fenghua Yu
	<fenghua.yu@intel.com>, Maciej Wieczor-Retman
	<maciej.wieczor-retman@intel.com>, Peter Newman <peternewman@google.com>,
	James Morse <james.morse@arm.com>, Drew Fustini <dfustini@baylibre.com>,
	"Dave Martin" <Dave.Martin@arm.com>
CC: <x86@kernel.org>, <linux-kernel@vger.kernel.org>,
	<patches@lists.linux.dev>
References: <20240610183528.349198-1-tony.luck@intel.com>
 <658d9869-ef22-48a7-876a-5bbba4f134ff@amd.com>
From: Reinette Chatre <reinette.chatre@intel.com>
Content-Language: en-US
In-Reply-To: <658d9869-ef22-48a7-876a-5bbba4f134ff@amd.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?elNkOXh6N2VyYnNXRGJxVjZoSytJclpRYzVGbFZhcno0TU91NVVNcnNjbkc0?=
 =?utf-8?B?Mi9XSXdneU9jVEY4bXBQRUIxS0djbElTTG5nQjVnZTdhV1dTbnlFRUhUakwx?=
 =?utf-8?B?TWcwMlBCRFJ4MzZyeXQ4UlIxcE5VUFdZSUxhRG80a2hnNFZBRmd3enFQWllB?=
 =?utf-8?B?Wk0ycXl1Wmx2UEhOZmpWNCtIVkI2M012UUkySmdPZ0hPWnF2d0VVdWpZTUxQ?=
 =?utf-8?B?aS85Q2N5dU82M2VRY2l2cHNqQWp4VFF6bTN1RURoRWF5cmV3eG9FYnJkT0dJ?=
 =?utf-8?B?d09PbXdVaWpiNFVPR1c2Vmxhc3YwQ25kc0lzTU82R1hia2VreVBwUGFEZFBC?=
 =?utf-8?B?Wnk1ZlZpR2hYT1c4T1h6TnlmU0cvRFN2dFlXYTJydi9KU3M2T2RqZzJLem92?=
 =?utf-8?B?VmV4TnVNeXFRbXRJWWJjRkpmdXRnVllOMVBLOFJIYkR0dG9LZm9VM1RXZ05G?=
 =?utf-8?B?QlV1b1ExU3pHQTZhdGFsQkN1elc0NnhvOEV2RDNGb1B6amZkYlRYWGdPRTlU?=
 =?utf-8?B?Skc3VUNIVTNoVFhPeVJjVHVkakt6am5mVWpsM2VZVEdKYkxJOU1oVEFwMEZ0?=
 =?utf-8?B?ZEo2Nm52dE01QS9ONDdGOWJxQ0h2UWNKdWkySFBVdGxLWjJBWStSRit6citn?=
 =?utf-8?B?SWtvTVpScDVsc2hCNkNlUlFML2FJamxiWHppbEtKd2J0Qk95VmsyWHQrcXBQ?=
 =?utf-8?B?ZC84UWowRC80L2pLU3FvaEdkVmNqT3N3YWwrTUlSMVA3STg0TDNuU1FkSEhH?=
 =?utf-8?B?cWZIajB5QWxUMUpJVVNUSXUwYUR4aG5tUTJ1ODBPL2ZFdklhbnZSM09FcmNR?=
 =?utf-8?B?d1FPMWlnUTFJTUF5a0tZUENRZjFFV1RuZllUNk54TFM0NkhJMGl5emdnZ3d3?=
 =?utf-8?B?WVZMUTJIQkVjMEtRb1Y1czk2d3drWWpONW94VGZtNDBwYnZkb1FIUVdISDkz?=
 =?utf-8?B?QmE1UmY4K1pxVkFvd0d5NXpVNlhUK2RjTFp5R2dPWGRsclNMK0JseGNidlov?=
 =?utf-8?B?K3BuczY4YWprMy9URURURi9HUWlDMjdKemhhKzlya0RHMk5TZjdSaTZkckpo?=
 =?utf-8?B?Q0YxcW5GRkluOUpObTlWYWRQL3NEa0FLVDRIUXk5YkF6bUxLbjVmcGFpeDZL?=
 =?utf-8?B?RXhBQ0lqTXRWczdCWlVLdmtBSnFwSXRlelZwMUZrYVpwM1Jndm5RK3Z2U2xN?=
 =?utf-8?B?eERiTjRlaFEwamlEYzlMNk9ZUmxsMXB5ZzhHZ21pd1V5NkJmUG91NTk5Q0lz?=
 =?utf-8?B?cGtqVW5qcXZuc3V4S25UZDBCTldQZlhjQnM5cU5ORUFtOGgveEpWOG1mdW54?=
 =?utf-8?B?Qnc0NHFzcnZsWE1wNnV6ZTh0QWRDclQ3eTJIY0hjcjlrQ0VUU0s3ODJWWURo?=
 =?utf-8?B?SXoxazhsczRCaGpsS2YzMTRabnpuMkhOZFFuT1NmcUh5M2hHVzloMjNoNlR3?=
 =?utf-8?B?NHArSTE3UklOUXlPa29CVjhJMzl2eTFxOU4yd1E4WnBIY2JpeGVUeVBxaXdl?=
 =?utf-8?B?bTZBZUl3akRYZ2pLaGN4TzJJYzBWWWQxK0d4T3pZM2E1b2RCVHoySE44aFkx?=
 =?utf-8?B?NHpsOXlUTGNGeWNrYnFYM1d6Y0FkNGJNVEw3VVRrc0Jpd2ovRzFLVWNBRWZK?=
 =?utf-8?B?MUo5RlU2RU9BWHB0RWNNMjN6aWN2L1FBZ2JPeEx4VG5OT1QzVVpFRVB1L0dh?=
 =?utf-8?B?V1h4MGIzYzZoaGVXQkRzaEZIR25VaXd5RnZrMDJxTWplVGdJVHhqajVzdGwx?=
 =?utf-8?B?azRjemozZmhBU25iTDd1SmMzVWJOUmtJK09zejgvaTVDbVdRVkZiTG5rZERP?=
 =?utf-8?B?R3JaTWt2SWk5QWxhcTBXQ3MwaHVVb291U1hVUktuZ2tnOUdQY1dYUTJNVVR1?=
 =?utf-8?B?NjN0bFQyRHVZVXcxZ1k5TitHY3ZUcHowTjYyUWtWSEpyZDFFZzVkbHlXRk1w?=
 =?utf-8?B?NWFnZkdtYWVZbXhBWGM0MjhEQjBjVFg3TjNUYlJVTzU3cDZWbFhiNEhWaDdU?=
 =?utf-8?B?MlU0dkJydWRmZTFwbmtYZ1lSK25NWUc5UjJSOTRlcXEvNU04dkdHS3dRVm9z?=
 =?utf-8?B?VWtOQVdqQzBKR3NiMy8yZng4QVJqRTNkQVg1cW94c3l1Zytoemc5NWloR21J?=
 =?utf-8?B?RkFNdEZMallOUXJYQ1N6Y1A4OUI3RUkvdVBxd2RQb1dxK0l5K0Z1ME9vS1Va?=
 =?utf-8?B?b2c9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: eae61046-2636-46a1-fb64-08dc8be7e828
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jun 2024 20:32:12.9721
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3waXZ466r/chJ3u9YJaZUkFcC/rayPztCtFDnjGoYX9PfH4DtVKWMjPSSdJ90plFAS3tAuVtlAz9dizvu7DlNmRUlzU7B98jTjVCSnqTPWM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB6038
X-OriginatorOrg: intel.com

Hi Babu,

On 6/13/24 12:17 PM, Moger, Babu wrote:
> I may be little bit out of sync here. Also, sorry to come back late in the
> series.
> 
> Looking at the series again, I see this approach adds lots of code.
> Look at this structure.
> 
> 
> @@ -187,10 +196,12 @@ struct rdt_resource {
>   	bool			alloc_capable;
>   	bool			mon_capable;
>   	int			num_rmid;
> -	enum resctrl_scope	scope;
> +	enum resctrl_scope	ctrl_scope;
> +	enum resctrl_scope	mon_scope;
>   	struct resctrl_cache	cache;
>   	struct resctrl_membw	membw;
> -	struct list_head	domains;
> +	struct list_head	ctrl_domains;
> +	struct list_head	mon_domains;
>   	char			*name;
>   	int			data_width;
>   	u32			default_ctrl;
> 
> There are two scope fields.
> There are two domains fields.
> 
> These are very confusing and very hard to maintain. Also, I am not sure if
> these fields are useful for anything other than SNC feature. This approach
> adds quite a bit of code for no specific advantage.
> 
> Why don't we just split the RDT_RESOURCE_L3 resource
> into separate resources, one for control, one for monitoring.
> We already have "control" only resources (MBA, SMBA, L2). Lets create new
> "monitor" only resource. I feel it will be much cleaner approach.
> 
> Tony has already tried that approach and showed that it is much simpler.
> 
> v15-RFC :
> https://lore.kernel.org/lkml/20240130222034.37181-1-tony.luck@intel.com/
> 
> What do you think?
> 

Some highlights of my thoughts in response to that series, but the whole thread
may be of interest to you:
https://lore.kernel.org/lkml/78c88c6d-2e8d-42d1-a6f2-1c5ac38fb258@intel.com/
https://lore.kernel.org/lkml/59944211-d34a-4ba3-a1de-095822c0b3f0@intel.com/

Reinette