Received: by 2002:a89:413:0:b0:1fd:dba5:e537 with SMTP id m19csp410226lqs; Thu, 13 Jun 2024 13:46:39 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWeddQLreSKlPsHhHMDNZ7TNM8oqQbUMFakYCmIaN7DqDk+M2BV69CJV+p1jzD0OvfYZXwftFg8vEeLRqDFj46tzqwJPW+JR2cntR4W8w== X-Google-Smtp-Source: AGHT+IHubG1AwFYl7xp2mj4/KBAE2z12eTZh8n2nIaRaH4Tg62dggVbxZp9qPbiMdpFcf8sG7/En X-Received: by 2002:a05:6808:1795:b0:3d2:24d0:eddc with SMTP id 5614622812f47-3d24e98706dmr821872b6e.36.1718311598815; Thu, 13 Jun 2024 13:46:38 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1718311598; cv=pass; d=google.com; s=arc-20160816; b=fyz5g2U8ZoBgRjAvaLkXyAB3PqTLj6FgzORYCZBV3EbtqYzKOkHq7ae3vYBnTwDVqp 5HuNFFpvyO+vrpAr8WWQoXzr303/lMreQk4BUg5aQXSv5gUpcaBqcS47l2NP++tchhyx lN+IorxPjwcVUi5d6ortQrPCmpN/0r8Xaly5uBSB1bC/8atZBAeD96Q7OsGX/4Rw5D1K lm5O3Ky6FxauKeoZ5Dchd1Bu9JNWDZv8eI4mghvJWitoI2Z/u7JFL9L3sqrO+zrVU8Td EyqHiak+t8PjEwLYElmt5yhgDeGXFM+loatC0wM79PrnLsTLOUpiD06g+7lFFgh6lboV Yzjg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=rdUt95wCW7pUkKB7MuV0OXQsjoGeXHyKiKG8gB7jBxw=; fh=yTYBSOWbNngQx+841plDFpLMQOAH1HyA0jhYcK4t0Jc=; b=ZjBv/+bC09OzI6vk9nR3slbtyrZuuZqBH8odYZAONf5kCYxUy5Ip5I/nflFBWW00GV 8ropHnA7eFnmDiAp6e0NAkfmzUB2UE9zquryitdaw78lUgS0WK957OvfPM6qDSnoTM3i qVvhBpaBe2Qqsp18NRNECF2IcaahFkWSNOdZWVI7xbpxqPt7F6Slu960pi+Z8XAv08R8 QLlkA3JrqAucvZk2A3lXgOpc7M5k2Ir59RWzfVwA+rqyitDZ7J93SfeZj1fDjulBifRe nTncQlhD/xo3JZFtghgUNuslYQ4/ynx4g9nOI0e3wjbrYgxd74fFF6wT9XWTPqPK5OHw wKNw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b="t/CGnthG"; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-214002-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-214002-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id d75a77b69052e-4421174f209si18255741cf.501.2024.06.13.13.46.38 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Jun 2024 13:46:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-214002-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b="t/CGnthG"; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-214002-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-214002-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 8152F1C20C18 for ; Thu, 13 Jun 2024 20:46:38 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id BAA6E13BACB; Thu, 13 Jun 2024 20:46:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="t/CGnthG" Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B5A5C763E7; Thu, 13 Jun 2024 20:46:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718311586; cv=none; b=lzRDOIj1rkFyeZcCx90AZcpgHHNaJZDGtPSd64IQif9oW0uydFpF03KIKQI7Zgid9Pj+226zMgdzf2l9gDIQ5/PuZo8fbxMegxXv+uAjesZRijS/j6CDqqUQLnj7DKvQE6BTbFAmwzIYSuQm3sB3jn3JFUcbWw1h618r7j8pJbM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718311586; c=relaxed/simple; bh=HicCLRv+HEWgT4PEns+naj+VIcI7qkndERvazIZM33g=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Mgn0/Zo2ylkdxrtzeKxel5ScCw9TmjAfvRaXtD16aR7CJ0N98gr8hkyyWTUgGd9FsttqxqgpAcqWfVGFSY16fJCOFbdtGKe+dAMFWhe0MHQSPnU0FxbZhau55XHu+8wSb03IB9RGPwBpLtvHiE4cxDQyeWsbVGetuctWUqkZjPc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=t/CGnthG; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=rdUt95wCW7pUkKB7MuV0OXQsjoGeXHyKiKG8gB7jBxw=; b=t/CGnthG7/sB5eOHvVxPMw254R rYKGxhsxSrlVd1M19VkDAM7Ij2cdor+ezzPSlaQPt41RbGiH0hlwFBPYFFBjax6tvBIrafaw0ziNp bMT/cuqDMWrQD9lkrBeRQbxKSm/00LV0m+Txf9iKaea8R4dJX0BHbcxLXt1Dfpgd7kZk=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1sHrKn-0000Mh-OF; Thu, 13 Jun 2024 22:46:13 +0200 Date: Thu, 13 Jun 2024 22:46:13 +0200 From: Andrew Lunn To: Rengarajan S Cc: woojung.huh@microchip.com, UNGLinuxDriver@microchip.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v1] lan78xx: lan7801 MAC support with lan8841 Message-ID: <6eec7a37-13d0-4451-9b32-4b031c942aa1@lunn.ch> References: <20240611094233.865234-1-rengarajan.s@microchip.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240611094233.865234-1-rengarajan.s@microchip.com> On Tue, Jun 11, 2024 at 03:12:33PM +0530, Rengarajan S wrote: > Add lan7801 MAC only support with lan8841. The PHY fixup is registered > for lan8841 and the initializations are done using lan8835_fixup since > the register configs are similar for both lann8841 and lan8835. What exactly does this fixup do? Looking at it, what protects it from being used on some other device which also happens to use the same PHY? Is there something to guarantee: struct lan78xx_net *dev = netdev_priv(phydev->attached_dev); really is a lan78xx_net * ? Andrew