Received-SPF: pass (google.com: domain of linux-kernel+bounces-214008-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Precedence: bulk
MIME-Version: 1.0
References: <20240612234930.211119-1-allen.lkml@gmail.com> <17eadeab-ecd5-4302-94b3-bbcf4f9d8dfc@intel.com>
In-Reply-To: <17eadeab-ecd5-4302-94b3-bbcf4f9d8dfc@intel.com>
From: Allen <allen.lkml@gmail.com>
Date: Thu, 13 Jun 2024 13:59:21 -0700
Message-ID: <CAOMdWSLRuzrytH_6t2POHeDNLvZ2SDk5z5ahfSE5dYa7fKKs-Q@mail.gmail.com>
Subject: Re: [PATCH v2] mmc: Convert from tasklet to BH workqueue
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: Aubin Constans <aubin.constans@microchip.com>, Ulf Hansson <ulf.hansson@linaro.org>, 
	Nicolas Ferre <nicolas.ferre@microchip.com>, 
	Alexandre Belloni <alexandre.belloni@bootlin.com>, Claudiu Beznea <claudiu.beznea@tuxon.dev>, 
	Manuel Lauss <manuel.lauss@gmail.com>, =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= <mirq-linux@rere.qmqm.pl>, 
	Jaehoon Chung <jh80.chung@samsung.com>, Aaro Koskinen <aaro.koskinen@iki.fi>, 
	Wolfram Sang <wsa+renesas@sang-engineering.com>, 
	Florian Fainelli <florian.fainelli@broadcom.com>, Ray Jui <rjui@broadcom.com>, 
	Scott Branden <sbranden@broadcom.com>, 
	Broadcom internal kernel review list <bcm-kernel-feedback-list@broadcom.com>, Alex Dubov <oakad@yahoo.com>, 
	Kunihiko Hayashi <hayashi.kunihiko@socionext.com>, Masami Hiramatsu <mhiramat@kernel.org>, 
	Bruce Chang <brucechang@via.com.tw>, Harald Welte <HaraldWelte@viatech.com>, 
	Pierre Ossman <pierre@ossman.eu>, Christian Loehle <christian.loehle@arm.com>, linux-mmc@vger.kernel.org, 
	linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, 
	linux-omap@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

> > The only generic interface to execute asynchronously in the BH context =
is
> > tasklet; however, it's marked deprecated and has some design flaws. To
> > replace tasklets, BH workqueue support was recently added. A BH workque=
ue
> > behaves similarly to regular workqueues except that the queued work ite=
ms
> > are executed in the BH context.
> >
> > This patch converts drivers/mmc/* from tasklet to BH workqueue.
> >
> > Based on the work done by Tejun Heo <tj@kernel.org>
> >
> > Tested-by: Christian Loehle <christian.loehle@arm.com>
> > Tested-by: Aubin Constans <aubin.constans@microchip.com>
> > Acked-by: Aubin Constans <aubin.constans@microchip.com>
> > Acked-by: Micha=C5=82 Miros=C5=82aw <mirq-linux@rere.qmqm.pl>
> > Reviewed-by: Christian Loehle <christian.loehle@arm.com>
> > Signed-off-by: Allen Pais <allen.lkml@gmail.com>
> > ---
> > v2:
> >    - fixed patch styling issues
> >    - rename work to bh_work
> >
> > Link to v1:
> > https://lore.kernel.org/all/20240327160314.9982-10-apais@linux.microsof=
t.com/
> >
>
> [SNIP]
>
> > diff --git a/drivers/mmc/host/sdhci-bcm-kona.c b/drivers/mmc/host/sdhci=
-bcm-kona.c
> > index cb9152c6a65d..9c215db81b2b 100644
> > --- a/drivers/mmc/host/sdhci-bcm-kona.c
> > +++ b/drivers/mmc/host/sdhci-bcm-kona.c
> > @@ -107,7 +107,7 @@ static void sdhci_bcm_kona_sd_init(struct sdhci_hos=
t *host)
> >   * Software emulation of the SD card insertion/removal. Set insert=3D1=
 for insert
> >   * and insert=3D0 for removal. The card detection is done by GPIO. For=
 Broadcom
> >   * IP to function properly the bit 0 of CORESTAT register needs to be =
set/reset
> > - * to generate the CD IRQ handled in sdhci.c which schedules card_task=
let.
> > + * to generate the CD IRQ handled in sdhci.c which schedules card_bh_w=
ork.
>
> The comment was stale because sdhci.c has not had a card_tasklet for
> a long time.  Just drop the " which schedules card_tasklet"
>

 Will do. Thanks.

- Allen

> >   */
> >  static int sdhci_bcm_kona_sd_card_emulate(struct sdhci_host *host, int=
 insert)
> >  {
>


--=20
       - Allen