Received-SPF: pass (google.com: domain of linux-kernel+bounces-214022-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Thu, 13 Jun 2024 23:23:47 +0200
From: David Sterba <dsterba@suse.cz>
To: Johannes Thumshirn <Johannes.Thumshirn@wdc.com>
Cc: "dsterba@suse.cz" <dsterba@suse.cz>,
	Johannes Thumshirn <jth@kernel.org>, Chris Mason <clm@fb.com>,
	Josef Bacik <josef@toxicpanda.com>, David Sterba <dsterba@suse.com>,
	"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] btrfs: rst: remove encoding field from stripe_extent
Message-ID: <20240613212347.GB25756@twin.jikos.cz>
Reply-To: dsterba@suse.cz
References: <20240610-b4-rst-updates-v1-0-179c1eec08f2@kernel.org>
 <20240610-b4-rst-updates-v1-1-179c1eec08f2@kernel.org>
 <20240611143651.GH18508@suse.cz>
 <c7246728-aadb-4699-8fdf-060502c1092a@wdc.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <c7246728-aadb-4699-8fdf-060502c1092a@wdc.com>
User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12)

On Tue, Jun 11, 2024 at 04:33:19PM +0000, Johannes Thumshirn wrote:
> On 11.06.24 16:37, David Sterba wrote:
> > On Mon, Jun 10, 2024 at 10:40:25AM +0200, Johannes Thumshirn wrote:
> >> -#define BTRFS_STRIPE_RAID5	5
> >> -#define BTRFS_STRIPE_RAID6	6
> >> -#define BTRFS_STRIPE_RAID1C3	7
> >> -#define BTRFS_STRIPE_RAID1C4	8
> >> -
> >>   struct btrfs_stripe_extent {
> >> -	__u8 encoding;
> >> -	__u8 reserved[7];
> >>   	/* An array of raid strides this stripe is composed of. */
> >> -	struct btrfs_raid_stride strides[];
> >> +	__DECLARE_FLEX_ARRAY(struct btrfs_raid_stride, strides);
> > 
> > Is there a reason to use the __ underscore macro? I see no difference
> > between that and DECLARE_FLEX_ARRAY and underscore usually means that
> > it's special in some way.
> > 
> 
> Yes, the __ version is for UAPI, like __u8 or __le32 and so on.

I see, though I'd rather keep the on-disk definitions free of wrappers
that hide the types. We use the __ int types but that's all and quite
clear what it means.

There already are flexible members (btrfs_leaf, btrfs_node,
btrfs_inode_extref), using the empty[] syntax. The macro wraps the
distinction that c++ needs but so far the existing declarations have't
been problematic.  So I'd rather keep the declarations consistent.