Received-SPF: pass (google.com: domain of linux-kernel+bounces-214044-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Thu, 13 Jun 2024 14:58:17 -0700
From: Jakub Kicinski <kuba@kernel.org>
To: Tariq Toukan <ttoukan.linux@gmail.com>
Cc: Joe Damato <jdamato@fastly.com>, netdev@vger.kernel.org,
 linux-kernel@vger.kernel.org, nalramli@fastly.com, Saeed Mahameed
 <saeedm@nvidia.com>, Leon Romanovsky <leon@kernel.org>, "David S. Miller"
 <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Paolo Abeni
 <pabeni@redhat.com>, Richard Cochran <richardcochran@gmail.com>, "open
 list:MELLANOX MLX5 core VPI driver" <linux-rdma@vger.kernel.org>, Tariq
 Toukan <tariqt@nvidia.com>
Subject: Re: [net-next v5 2/2] net/mlx5e: Add per queue netdev-genl stats
Message-ID: <20240613145817.32992753@kernel.org>
In-Reply-To: <0a38f58a-2b1e-4d78-90e1-eb8539f65306@gmail.com>
References: <20240612200900.246492-1-jdamato@fastly.com>
	<20240612200900.246492-3-jdamato@fastly.com>
	<0a38f58a-2b1e-4d78-90e1-eb8539f65306@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Thu, 13 Jun 2024 23:25:12 +0300 Tariq Toukan wrote:
> > +		for (i = priv->channels.params.num_channels; i < priv->stats_nch; i++) {  
> 
> IIUC, per the current kernel implementation, the lower parts won't be 
> completed in a loop over [0..real_num_rx_queues-1], as that loop is 
> conditional, happening only if the queues are active.

Could you rephrase this? Is priv->channels.params.num_channels
non-zero also when device is closed? I'm just guessing from 
the code, TBH, I can't parse your reply :(

> I would like the kernel to drop that condition, and stop forcing the 
> device driver to conditionally include this part in the base.
> 
> Otherwise, the lower parts need to be added here.

You'd need a stronger (and clearly explained) argument to change
the core. If you're saying that the kernel should be able to dump
queue stats for disabled queues - that seems rather questionable.