Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758171AbYBGQ3d (ORCPT ); Thu, 7 Feb 2008 11:29:33 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755399AbYBGQ3Z (ORCPT ); Thu, 7 Feb 2008 11:29:25 -0500 Received: from pentafluge.infradead.org ([213.146.154.40]:39225 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755093AbYBGQ3Y (ORCPT ); Thu, 7 Feb 2008 11:29:24 -0500 Date: Thu, 7 Feb 2008 08:28:27 -0800 From: Arjan van de Ven To: tcamuso@redhat.com Cc: Yinghai Lu , Matthew Wilcox , Greg KH , Grant Grundler , Loic Prylli , Adrian Bunk , Linus Torvalds , Benjamin Herrenschmidt , Ivan Kokshaysky , Greg KH , linux-kernel@vger.kernel.org, Jeff Garzik , linux-pci@atrey.karlin.mff.cuni.cz, Martin Mares Subject: Re: [PATCH] Change pci_raw_ops to pci_raw_read/write Message-ID: <20080207082827.2b4e6112@laptopd505.fenrus.org> In-Reply-To: <47AB299D.4000500@redhat.com> References: <20080114230448.GL9847@does.not.exist> <20080115174643.GB28238@kroah.com> <20080115175641.GE18741@parisc-linux.org> <20080119165809.GB11553@colo.lackof.org> <479E1FA6.1030708@redhat.com> <20080128204431.GA15227@kroah.com> <20080128223141.GA31101@parisc-linux.org> <20080128225334.GD4720@kroah.com> <20080129025615.GC20198@parisc-linux.org> <20080129030340.GE20198@parisc-linux.org> <86802c440802022330o771cf98btcf750c790668b6e9@mail.gmail.com> <47AB299D.4000500@redhat.com> Organization: Intel X-Mailer: Claws Mail 3.2.0 (GTK+ 2.12.3; i386-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 850 Lines: 25 On Thu, 07 Feb 2008 10:54:05 -0500 Tony Camuso wrote: > Matthew, > > Perhaps I missed it, but did you address Yinghai's concerns? > > Yinghai Lu wrote: > > On Jan 28, 2008 7:03 PM, Matthew Wilcox wrote: > >> > >> -int pci_conf1_write(unsigned int seg, unsigned int bus, > >> +static int pci_conf1_write(unsigned int seg, unsigned int bus, > >> unsigned int devfn, int reg, int len, > >> u32 value) > > > > any reason to change pci_conf1_read/write to static? > > > nothing should use these directly. So static is the right answer ;) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/