Received-SPF: pass (google.com: domain of linux-kernel+bounces-214085-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <d57e27cc-3d9b-40da-a2a5-23c28b17a005@phytec.com>
Date: Thu, 13 Jun 2024 16:07:39 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 0/4] Add overlays to disable optional hardware in
 k3-am6xx-phycore-som boards
To: Vignesh Raghavendra <vigneshr@ti.com>, nm@ti.com, kristo@kernel.org,
 robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org
Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
 linux-kernel@vger.kernel.org, upstream@lists.phytec.de, w.egorov@phytec.de
References: <20240528225137.3629698-1-nmorrisson@phytec.com>
 <4ac40139-eda0-4f6a-8bbe-99110605f91e@ti.com>
 <5a773641-73a6-416e-8c52-eccc136f11ef@phytec.com>
 <629a95ac-3f40-412f-b983-312f434bfb2f@ti.com>
Content-Language: en-US
From: Nathan Morrisson <nmorrisson@phytec.com>
In-Reply-To: <629a95ac-3f40-412f-b983-312f434bfb2f@ti.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?RnJSbExFNFZocVZSbWdPaWVoWm5maXRFMjcwR3o1YXptejc2Q243dXlkazJ4?=
 =?utf-8?B?WWZpTTVSOVZRV3JRMWVZTkExamp1cUkrRElFMGpWVjFPZ3RIUFlmWlJ4elFP?=
 =?utf-8?B?bWQ2LzJUMDR5RU5zcmFhSE1ZYXNHUzVOeTFweXVkZVozK1prcVdXWSs2K3Av?=
 =?utf-8?B?a1dGcGw5M0VXc3EzbFZ5TU5pQmVMNWdQSTBWai84VVNNZjRpQ0VGOVZvNEIr?=
 =?utf-8?B?aDUwNjM3VjUwamI4cEd4ZHlhaDJjaTJQMm4xVEVzd0YzWGhqdHhESCtMOXF4?=
 =?utf-8?B?d1V6elF0UjlmMlBHaTkvcDhnd1F1M3dqRmRpM3NxOTFPdFRYbGtKTmxNUWdh?=
 =?utf-8?B?NjJlcHN0ZlZLWTVmd1dNb01kZ2RzVjkvMWVLVWZsYmF0OHR2eWdHOWpTYS9o?=
 =?utf-8?B?aXU3Q2Z3TUowSU9JSXZyR3hvYkh3aUtDTlhtQXJrK2ZDWEpEdk9UZGJadlBy?=
 =?utf-8?B?WHJqaFlZa0YrbzU0RloyaVRaRHdsaFJnUnhiL3owaHRDSWNuR0JLZTFadDd4?=
 =?utf-8?B?ZVVTMGFDTjkyZGJHeXh3Q21iLzlKM3pWTnhqZ0NNRUtaY1MyQjdyY0xxMjFl?=
 =?utf-8?B?UWhTS0pLR2JpTVZZNHhtbzRXTHJ6QytJMndhakl3dmxkYTBQRnUxVGJnTUNT?=
 =?utf-8?B?U1ErVVlzTmNmbUZ0RzJleVRrSWxsd2xqZDRQenpqQlI0ZG02Lzl6dzlpeWth?=
 =?utf-8?B?akgxMks1MDRlU09Lcjl3c2w1WW9IWXVVTWhZcWtmUXRwdGluN1YrVnN3NFNY?=
 =?utf-8?B?d0Z2c3VQSDlteU9TK3pzR05qK0JSWEtzTjBIa3dHSWRQY2FuMHFlUzhoOTBL?=
 =?utf-8?B?cCtKY2IwQU0xVVU2VFpuWFIzZVRjN2ZoVTNOTWZkNDJ5UHhLOEhsWnhMR2pi?=
 =?utf-8?B?RU9YaUIrckh1UVZFNVIrZGFhSXRtQU9LUWNPaytUM2hRQm5tenFSM09PZzAr?=
 =?utf-8?B?cEFKd1VvaTFueXlXN0lBbk5MTUVrSHBaVC9mNE14ZEFzUjZFa29XcVZRNzVY?=
 =?utf-8?B?b0JWa24vZkV2ZlY3UHF0aEIxMnVuUWpmdm9FOTA4R3BxSU1vRFp4V044NENK?=
 =?utf-8?B?NU5GTFowMmJBQkpib2xXaldlYWlzNldyS1B3bEM3VTdYc21CRTlmWWc5bzZx?=
 =?utf-8?B?OUs3K3ZoOXVIVzZwc28ya0Vhbys0VVZtcEVKbUU2QmR0V2dmSTBDT0lmWGFm?=
 =?utf-8?B?Q2lVclh2dS9TL0syemx1UFB3Zlg0TUdsQnNLWEc0cU1VMVN3WHFSYTJrdUVs?=
 =?utf-8?B?bko0M0RUamwrNWErSDE1NHN1WE51Rjh3Z0FZSU5rQ0VOdGlzQkhvQWtGaHp1?=
 =?utf-8?B?S0ZocFo3UlllQnV6SmM0TjU5R2xEL21LSW1NMXdBcUtuUUVRcXd2VE1vYXkw?=
 =?utf-8?B?aDBJY3JxMUFYdVVuMG1GTUxwTndnTUk1Z01qYlVQRURHU01XYnhybk1JZUZV?=
 =?utf-8?B?dkdFRndNNklhSnQ4R2V1NHgrRDNIVHFMY2w3c0JZdXNFS1YzWlVIT0wrbE9K?=
 =?utf-8?B?UzdqYVhUazJTL1JZQkU1UkxOajNkZndQVlZOVy8ycTNOWTkwTkJndEp3a2RI?=
 =?utf-8?B?cEZ0ektWaS9MZVgzWm80RzluZFVkNGxXWHZVTXR2R09BSkQraFl6dTZWWENQ?=
 =?utf-8?B?YTNQQXloZFYvYTB6L3hVWnM1cFoxKzFoL0xkL3hkQ0lRRDkrNEhsZG92VklQ?=
 =?utf-8?B?bU9XM3R6R1ZQVzhOS05BVTRzdDVWSHRSeFJqNFR3a2h0N2dhT3FEdVJYaHFo?=
 =?utf-8?B?ZUlBMmxWL3dsZnBvUm1KR2FtUnY5THk3MFltOGxxSXV0WTdZMnlDMkk3L3ow?=
 =?utf-8?B?aGExK3ZPU2xpaHd3b2xyQWdTOVdabTUzUWtwOVc5azdNSXZHQWNZRGJrMG5x?=
 =?utf-8?B?bCsvYzY0ckI0MG56Qk1QU1FQZzZVM3VMbWg2RCs4cFM5VkNxNzJuNDJLTlpo?=
 =?utf-8?B?Mkd4Y3hHV3l6Z01MUVhIV0dHVEQ2dHMrdEVPTzM1a25HQmVTQUQwdjNaMnJI?=
 =?utf-8?B?R1FkSDdYYm5IYTB2akFjUURPRWROOHI3dHRJeWpYUzNYeU1jTnMzWHdRK3BB?=
 =?utf-8?B?UHpwSzVMbExkYzhFWHJVUEtSMDhjU1JUQ21keDVOWGszK0t5MWxzVnZySEcw?=
 =?utf-8?Q?P2ApHJ+5ELh55eaT8/s/A0beG?=
X-OriginatorOrg: phytec.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5c009d15-9994-4e72-4ae8-08dc8bfda077
X-MS-Exchange-CrossTenant-AuthSource: SA1PR22MB5636.namprd22.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jun 2024 23:07:41.6037
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 67bcab1a-5db0-4ee8-86f4-1533d0b4b5c7
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: tbX1TqLecznWx0oCryB3Ca9ZJqyQTes39btQvYkbT9124Dpfgba12J03DtqkeskXwNjoh9F9+eZe+Cnn7qCsqg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO3PR22MB3245


On 6/12/24 3:19 AM, Vignesh Raghavendra wrote:
>
> On 05/06/24 04:45, Nathan Morrisson wrote:
>> Hi Vignesh,
>>
>> On 6/3/24 10:41 AM, Vignesh Raghavendra wrote:
>>> Hi Nathan,
>>>
>>> On 29/05/24 04:21, Nathan Morrisson wrote:
>>>> Add three overlays to disable the eth phy, rtc, and spi nor. These
>>>> overlays will be used to disable device tree nodes for components
>>>> that are optionally not populated.
>>>>
>>>> v2:
>>>>     - Add build time tests in makefile
>>>>
>>>> Nathan Morrisson (4):
>>>>     arm64: dts: ti: k3-am64-phycore-som: Add serial_flash label
>>>>     arm64: dts: ti: k3-am6xx-phycore-som: Add overlay to disable eth phy
>>>>     arm64: dts: ti: k3-am6xx-phycore-som: Add overlay to disable rtc
>>>>     arm64: dts: ti: k3-am6xx-phycore-som: Add overlay to disabl spi nor
>>>>
>>>>    arch/arm64/boot/dts/ti/Makefile               | 17 +++++++++++++++++
>>>>    .../boot/dts/ti/k3-am64-phycore-som.dtsi      |  2 +-
>>>>    .../ti/k3-am6xx-phycore-disable-eth-phy.dtso  | 19 +++++++++++++++++++
>>>>    .../dts/ti/k3-am6xx-phycore-disable-rtc.dtso  | 15 +++++++++++++++
>>>>    .../ti/k3-am6xx-phycore-disable-spi-nor.dtso  | 15 +++++++++++++++
>>>>    5 files changed, 67 insertions(+), 1 deletion(-)
>>>>    create mode 100644
>>>> arch/arm64/boot/dts/ti/k3-am6xx-phycore-disable-eth-phy.dtso
>>>>    create mode 100644
>>>> arch/arm64/boot/dts/ti/k3-am6xx-phycore-disable-rtc.dtso
>>>>    create mode 100644
>>>> arch/arm64/boot/dts/ti/k3-am6xx-phycore-disable-spi-nor.dtso
>>>>
>>> I am not sure if this a common practice to have overlays to disable
>>> missing components (at least I dont see such dtso in kernel). I would
>>> like to see an what DT maintainers feel as such dtsos can explode in
>>> numbers.
>>>
>>> Is this something that U-Boot can detect and fix up for the Linux DT?
>> We have an EEPROM on our board with information on what is populated on
>> that particular board. We will apply these overlays based on that EEPROM
>> data.
> Typical usage of overlay is to keep the minimum in baseboard and enable
> optional components in the overlay. But it would also depend on whats
> information is present in the EEPROM.
>
> Could you provide bit more color on whats in EEPROM and how each overlay
> would be applied? Please add the same to commit message and respin.

The EEPROM contains information about the configuration of the board. 
The standard configuration has an ethernet phy, rtc, and spi nor. These 
components can be left out to save cost, and that configuration 
information is what is stored in the EEPROM. If these components are not 
used, then we would use these overlays to change the device tree 
appropriately.

I will send a new version with this in the commit, and there is also a 
more detailed explanation at [1].

[1] 
https://lore.kernel.org/lkml/4e7dd467-20be-43ce-936d-200ede6d511b@phytec.de/

Regards,

Nathan

>
>>> Unpopulated SPI flash and RTC should ideally not be an issue as drivers
>>> would gracefully fail albeit with some sort of error msg.
>>> Not so sure about Eth PHYs though.
>>>
>>> Also, Are these dtso's mutually exclusive? ie can SoM have SPI flash but
>>> not RTC, have RTC and SPI Flash but no ETH PHY?
>> They are not mutually exclusive, you could have any combination of
>> overlays applied.
>>
>>
>> Regards,
>>
>> Nathan
>>