Received-SPF: pass (google.com: domain of linux-kernel+bounces-214129-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Fri, 14 Jun 2024 00:55:34 +0100
From: Andi Shyti <andi.shyti@kernel.org>
To: Aryan Srivastava <aryan.srivastava@alliedtelesis.co.nz>
Cc: Markus Elfring <Markus.Elfring@web.de>, 
	Robert Richter <rric@kernel.org>, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 1/2] i2c: octeon: refactor hlc r/w operations
Message-ID: <lx2mv6kbblao5ubjfxg4we6h62g63osbwct2hyuwygmp2u5nxz@j3iyezth2zd2>
References: <20240613025412.3848629-1-aryan.srivastava@alliedtelesis.co.nz>
 <20240613025412.3848629-2-aryan.srivastava@alliedtelesis.co.nz>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240613025412.3848629-2-aryan.srivastava@alliedtelesis.co.nz>

Hi Aryan,

> +/* Construct and send i2c transaction core cmd for read ops */
> +static int octeon_i2c_hlc_read_cmd(struct octeon_i2c *i2c, struct i2c_msg msg, u64 cmd)
> +{
> +	u64 ext = 0;
> +
> +	if (octeon_i2c_hlc_ext(i2c, msg, &cmd, &ext))
> +		octeon_i2c_writeq_flush(ext, i2c->twsi_base + SW_TWSI_EXT(i2c));

I think this check here is the only logical change I see. Right?

If so, can you please describe in the log why you made this
change?

Thanks,
Andi

> +	return octeon_i2c_hlc_cmd_send(i2c, cmd);
> +}