Received-SPF: pass (google.com: domain of linux-kernel+bounces-214159-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <1c06a79c-e1dc-4798-9fce-3082597eee3a@intel.com>
Date: Thu, 13 Jun 2024 17:55:51 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v4 03/19] x86/resctrl: Consolidate monitoring related data
 from rdt_resource
To: Babu Moger <babu.moger@amd.com>, <corbet@lwn.net>, <fenghua.yu@intel.com>,
	<tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>,
	<dave.hansen@linux.intel.com>
CC: <x86@kernel.org>, <hpa@zytor.com>, <paulmck@kernel.org>,
	<rdunlap@infradead.org>, <tj@kernel.org>, <peterz@infradead.org>,
	<yanjiewtw@gmail.com>, <kim.phillips@amd.com>, <lukas.bulwahn@gmail.com>,
	<seanjc@google.com>, <jmattson@google.com>, <leitao@debian.org>,
	<jpoimboe@kernel.org>, <rick.p.edgecombe@intel.com>,
	<kirill.shutemov@linux.intel.com>, <jithu.joseph@intel.com>,
	<kai.huang@intel.com>, <kan.liang@linux.intel.com>,
	<daniel.sneddon@linux.intel.com>, <pbonzini@redhat.com>,
	<sandipan.das@amd.com>, <ilpo.jarvinen@linux.intel.com>,
	<peternewman@google.com>, <maciej.wieczor-retman@intel.com>,
	<linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<eranian@google.com>, <james.morse@arm.com>
References: <cover.1716552602.git.babu.moger@amd.com>
 <8f73c9ec4c9999c262d9297d46a03209a8affe3f.1716552602.git.babu.moger@amd.com>
From: Reinette Chatre <reinette.chatre@intel.com>
Content-Language: en-US
In-Reply-To: <8f73c9ec4c9999c262d9297d46a03209a8affe3f.1716552602.git.babu.moger@amd.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eFVkVk5CQUJMMTNFTHlkbTZtM0lZWG9JZnFLdW5tSTJZUk5WWk41c0t1T0pS?=
 =?utf-8?B?eTJSaHF2SXJaTElEcEN1cVhsaVY4K09SY0pHZHhzS3I3enErL2pwVXAzcWFI?=
 =?utf-8?B?akVTVlp6RzUxUS9OcHhYL0FrRSthNFZzWXJLSWQzSGhBVlFwSHhDVEEvY2JG?=
 =?utf-8?B?Y0hUSEs3SEQ3Yy9VRWpLd01vSTBDVVZGL1lvV0huelRtQlZRZldiNGdWWDBC?=
 =?utf-8?B?ZENrVy9yZGFrU0lDMWRraFZwdTRYeDZhWHhsYU5aWWdEaExnaDI2Z2lyYnFk?=
 =?utf-8?B?YXVJbmVueHVWWDRzMEx4alJFV0ptU0IyWjFvTGNvK3crSVBxemw5bEdVYUtK?=
 =?utf-8?B?ayt1SzUrVUMxZDR2QS84VmdnNXcwR3dXZVpGWkRETWdrWlN6STVtUkZyN0hW?=
 =?utf-8?B?czdWNUNyVzZGclVCSGVhbnpubWxQYjlnWUlTU0lEbDVDMmlQWS9nTG10S0F6?=
 =?utf-8?B?ME9IQWhHSGJDRkJvYWVSZ3FBcm5zYXhic1llNmFiN2liSHNybWpHM0lmU1Z4?=
 =?utf-8?B?SVl1ZTNCbFYxeFY3WU5oRzBlUnc4SFFycCt1VklZNFBCVjJ2bVlqVzBweVhq?=
 =?utf-8?B?TC80SjZZeHU4V21jNHk2RU1scE1jVnlIUUdDZmFYOWdKR3lGaVZxWmJXUnh4?=
 =?utf-8?B?SkdTVDU0aURQMTBlcXlSZ3dpWEplWENCcUR0eE1ITitmMitjL0E1OXRRbjYw?=
 =?utf-8?B?dWJGSkNsem10YlQ1TUpMN2l6QjFEaDlxUVF6dHBGRThVZWJMTUhXMXBCd0xW?=
 =?utf-8?B?RjBRbjdXZjRFV0YrOXVrci9wZVdXM3orb0loSWxXWnB0VEIxTnZuVk55c1lt?=
 =?utf-8?B?VEQyZytYY3AySklqeHVoUks0ak9iWjdKQzlVU1Vka2xkY1FhUnprTzRZM3Jp?=
 =?utf-8?B?NENGaVk5YTh2MkpsUjJVVE83UnN1TC94dVVjYTgwWVpPLy9oNUhPQjhyZUxo?=
 =?utf-8?B?S1VOMVE4cytLSkhsSnlYOEQxZWNWRmdkQ3AyaWxudTJkNmRJWnVybFgySUZW?=
 =?utf-8?B?MEppWHJReFlueE9wUUhxdjdYaC9DR054WXp0MHYwTkxNcXBOUHBDWVFLNkRY?=
 =?utf-8?B?NDF3WVgvVEJGNHRtUlMwQ3VWSlo4ZWJENlpXaWFzbVd3Q3VQdDdUdEtXZ1pW?=
 =?utf-8?B?bzlickFsK1BySm5tVVR6YnhIeng3d0Z4Qjdnc1hCWE9XUVcxSnNDSldBbEt3?=
 =?utf-8?B?d3JKenBDYXJZZU5iV1RKMWlNVy9WVDdZdnh4U29GdENVL3ppZGltUlZjQmh1?=
 =?utf-8?B?QURpVUNqTUFHUEowd3ZQdDE3WERZb242blR0OTZUZjE2MTdmb3hXdDQ1QjBM?=
 =?utf-8?B?dHdRSDVpZGt3ZXZhLzVjUkdiTVQzSTVsL2hIZU5qWEZvMFFDVWVNM2xDNnpP?=
 =?utf-8?B?MCswbXk1cHJLb3krU1NsazNkT2JMYmFZK1RHanRnUmtCaHBMUGlBVSt0bnZD?=
 =?utf-8?B?WUpxUStKSmZ2bVhJMWQwVlhTVENWM2NqVmtmaE5aUk9mYW1HWWNPdFdJdzli?=
 =?utf-8?B?d3JhT1NISnIzSENyTGt6Wmx6T1dXbEpNVTBxYnpKOTRIWUUyRXRvZTZFMXRH?=
 =?utf-8?B?T2N2S1U5WlNldHdpSHVmc0RFQVA0eFl3SnMzTHV0SDEzTXpuL1p4cmlGYUhZ?=
 =?utf-8?B?TFpLS0pjd2tTSnBNcFFBejhOVnJpdUUrem05eFdJSlRtMEdvdjBiNUx1S0tY?=
 =?utf-8?B?c3lvd084MndWU3FUaTJhQW5JVG02TzI3MmladnpqU1pTd3UvdUFaZmwzdWhS?=
 =?utf-8?B?SlYrcTMwSktOc1ZmSFV1aS9MSHduNVd5bjcvcXlzVTFiTHVRK1UvVjFMbTB4?=
 =?utf-8?B?dExtZ0dZb21LRG1ic1NNTXBHV25uWmxRRUVSVVhMRDcvU25wY3pPNXpNMzI3?=
 =?utf-8?B?K3hOb3MwSnhwd05tSE11ZTBWbWRicFVDb21TbzZIL3J2UE9iUnBWWXdyVVE1?=
 =?utf-8?B?OHJHUFhFY0hqeWpMelh3SUpLWm5GRE1kaG9YQzdzN2RsdkkwOXVEdTU1dXdm?=
 =?utf-8?B?TlFMTU1EZ1RMT3VMclZHS2crUEJ0SmcrU1dKVEhBR05UcFU1VDhZalJWSHRM?=
 =?utf-8?B?blJQZWJNOVc0cG9ueTQ0Q0NYVUN6WDVaeXhuN1E4OUpMOVVOUnpBRjAxVC9u?=
 =?utf-8?B?dm14R1U5UEVWdTVNNnd4blJDb1ROUlMvclBscGN2S2N1RGJhR2pGdDIyWUNB?=
 =?utf-8?B?QWc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 3061fc46-889a-4307-7b6c-08dc8c0cbe66
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jun 2024 00:55:54.2916
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: uaOFrronT/n6piBFp8hfrZNKrvKpQSC1XQN0PMTrlT9HM+McrA5mM9hFjnGQBFnTtY/cqyxQfZxSn74WeVa+zOGjha7+hEOYhjvzNS6yfFc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB6861
X-OriginatorOrg: intel.com

Hi Babu,

On 5/24/24 5:23 AM, Babu Moger wrote:
> Consolidate all the data related to monitoring into separate structure
> for better readability.

This needs a better motivation because "better readability" is subjective.
You can motivate this work by noting that this is re-organization in preparation
for more monitoring specific properties that will clobber the existing resource
struct more. To support this organization the pattern of the cache allocation
and memory bandwidth allocation features that consolidate the feature specific
properties into a struct is followed.

Reinette