Received-SPF: pass (google.com: domain of linux-kernel+bounces-214162-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <69c72f43-6b1e-4c83-861c-375fe15a74b9@intel.com>
Date: Thu, 13 Jun 2024 17:57:23 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v4 05/19] x86/resctrl: Introduce resctrl_file_fflags_init
 to initialize fflags
To: Babu Moger <babu.moger@amd.com>, <corbet@lwn.net>, <fenghua.yu@intel.com>,
	<tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>,
	<dave.hansen@linux.intel.com>
CC: <x86@kernel.org>, <hpa@zytor.com>, <paulmck@kernel.org>,
	<rdunlap@infradead.org>, <tj@kernel.org>, <peterz@infradead.org>,
	<yanjiewtw@gmail.com>, <kim.phillips@amd.com>, <lukas.bulwahn@gmail.com>,
	<seanjc@google.com>, <jmattson@google.com>, <leitao@debian.org>,
	<jpoimboe@kernel.org>, <rick.p.edgecombe@intel.com>,
	<kirill.shutemov@linux.intel.com>, <jithu.joseph@intel.com>,
	<kai.huang@intel.com>, <kan.liang@linux.intel.com>,
	<daniel.sneddon@linux.intel.com>, <pbonzini@redhat.com>,
	<sandipan.das@amd.com>, <ilpo.jarvinen@linux.intel.com>,
	<peternewman@google.com>, <maciej.wieczor-retman@intel.com>,
	<linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<eranian@google.com>, <james.morse@arm.com>
References: <cover.1716552602.git.babu.moger@amd.com>
 <67c8cd614925496971496a8fab7459cf5c037652.1716552602.git.babu.moger@amd.com>
Content-Language: en-US
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <67c8cd614925496971496a8fab7459cf5c037652.1716552602.git.babu.moger@amd.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QWlTRU5UNUFmc1ZNYVd4NnVROUtqV2xWZDZDQlBOWEw2S2dkS2poNVpKY29R?=
 =?utf-8?B?OWZ1UXF2WmdEQkJqNkxxNzZNY2ozLzBkaXdsWkpqU3JIYlg2c0FlWDBxc0lZ?=
 =?utf-8?B?Zk1icEdjTXptdzh2Qm1YNGFTT2M0a0ZjSWFQbU9WKy8rTXFneHd0N1BqOU9M?=
 =?utf-8?B?b0FreTZlSDR2bjNLbFFlMW9WTEVNNlgvRFV0SXJVT29Xa1pTeFk1NnNpZnBY?=
 =?utf-8?B?NnhnaWNTTEpKMlp5WXhEaEtRNi82WVk4SXQyUk4xQ1lQRmJtTks4RVJ5NTZH?=
 =?utf-8?B?cHVqOWVieStCbDRhaS9yclgyUjN4VW5UV3ovdGFIOUljSWRST3hmQ0tTM1dH?=
 =?utf-8?B?MSs5QkdmUzdRaks0SEVEZE5aeFJpK1VyVkIvVVpML2xtdUhCMTdibXlvUjhm?=
 =?utf-8?B?TGpQWHdsMXY0c2JGaU1ib010SEtJNlpoZWJhRE5jWlMxVmw4U2c0SXA0SGxi?=
 =?utf-8?B?Q09FNXJWQkMrZG1nNXNBUnlQTkV2RmhPU2ZraU4wclNtR3JDVU1XcFJ5NFNv?=
 =?utf-8?B?Z3hqa2laSEd2OTRQOW43Ynp2cmxnYVBCR2xTMjgveTBzL0F3Q0RmNlpOVGJ3?=
 =?utf-8?B?VU56LzlVNXhYNEMzelNxdkZEdmpyY1pxVFI0dS9rcVp5R09jR1R4OGdxR0dK?=
 =?utf-8?B?b1dZU0pYOUxRWXZEUjc5Z2VTRVNkYW5OZG9NSjhSMDU4Z25oc20rb3ZtQWlY?=
 =?utf-8?B?ZXV0RmN3Ymk0YTVSVTBrelAyU2RtcktQVzdJQXhkdTFCYit1c0lSdWxRRzNJ?=
 =?utf-8?B?ZHJBbWoxN2p1T1lhbEx3eXBCTEpJYWdBR3ZBUFFtWWJWQy9vdDk1aGNzU3Z2?=
 =?utf-8?B?ajB3Q2s4UmlSK2JBdTlCczhUY2dmYWVXOGlaWjh0WkE4S25xeDZ6YmhvdmYy?=
 =?utf-8?B?NE1zUUFaUW9odTY1MU02THE1aVl4WWVoL0FtUG9LZTU2SGY3aittbTFzbFNN?=
 =?utf-8?B?UmJGU0dnR1lENDR3dDRwV0RSWTYwR3Y4UWVoVXc0S0gzeEtKMkd0V09VL0Zu?=
 =?utf-8?B?TnY3aWFibDBDYVlKajVRd3NBS2k3aWdZVUlyRklFNnM2M2YrcnMvQld6Z2VO?=
 =?utf-8?B?OGVuYzF5Z2NkUXpGTWY1TmNReTdnaDcvUERSTTlaNjhSWFpNV21lc0ZPQ3FH?=
 =?utf-8?B?b0VRS3ljcFZ4cVIyMklBRlFQbmlNYVhrenVaKzN0bnNwcHBqRWNkdUhZR1Rq?=
 =?utf-8?B?cXBTdllvNk13eW9uWkg4MjBQbGMrUE1TUWxDcG1KNEJsTENUKytsWHhSbTE4?=
 =?utf-8?B?aVI2enA1V3FGWElwMVZwOFRnMnFBSS9sOEk2c0Nta1ViV04wZjRmNUR4UHJz?=
 =?utf-8?B?VjlTeCtiQmxCZ1daQU55UlRXN2ViaTF5OUJPWUMrbkpmVnh4OTYrODVYUVlG?=
 =?utf-8?B?VlhqVmdkcmVHQ1FpbDRNV3U5WmxvZ29wQ2RNdngzMkY3elIySGhXYUR6YzlW?=
 =?utf-8?B?cHJFRVNoUWRKODQ1bGFONERMQUEzdzlVL2Jra0FhcHd4akxDb09TaFRmMHBY?=
 =?utf-8?B?cFNmM0E4dlFtUjFLYjI4ekp4RGMrK1N0dmdCVG1aOFcvejF1VDNiM3hYYWY0?=
 =?utf-8?B?OVFPdDhGY2JTSnZ0V0l0emQvTG9OdFdpL1VhYWZnYjFZS3h2KzRQUVE4eTVG?=
 =?utf-8?B?MWRCc3V3K001L3RpNExxRjY3WnU3V0wyTFFLeGFUQnFwYlNSaUJDMHN3SUVr?=
 =?utf-8?B?ci9UclFabVRkbGsweU9GNkFzSndTM2hlN2NpUk1MV0JUNExrL2hqNE5HTXlF?=
 =?utf-8?B?Wk5qdGY5SnRPa2huQUEwTWU3MURiYW45RlNpZVIyRC9LaFZRbWdPaS9DQU5R?=
 =?utf-8?B?SGx4YktTVHNmSFI1WDhmVjV0QkZaRkduU1NJYUVuMzl4TGRJU0RJVlBBQWN1?=
 =?utf-8?B?eFF4dG96SSs2Yy9aSytiMmtoTlZFQ004b2t1RnhhdHB6N0VLckdKeXV4M0hV?=
 =?utf-8?B?V2JCL0Q5ZGVGR0swbGxVd0hTTDcxSnN0VkhFQ1IzbnN3RFRhZm53YkNHazlx?=
 =?utf-8?B?dGhWaDZlOVcyclQ1dysxWlJqL2FlbzNWZHgyWXNxV3d5aVBEbkkzNDY0OHp0?=
 =?utf-8?B?cXNQcVVPS1A2VjNxdUQxaStKVmRxVzRkWjVRcG5UODBMSFRPTzl3eUJYSWJL?=
 =?utf-8?B?MnRoVXpudm9XM0lSaUV5Y2kxNldHWS81ZTF6dHNocDZUVzZzR0pBY3VoMlNP?=
 =?utf-8?B?N0E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 4f337092-938f-4307-e234-08dc8c0cf5e0
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jun 2024 00:57:27.3864
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mrrCghDFuHnh5oKN0TzdAKtruFBLxBzEuORPvFivfY3lVqvDnimdMIwdt7aYqGLGcvtVYVgRHoJN2DW/kIC7pvz5B5710ck/nsYE8Wg9h98=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB6861
X-OriginatorOrg: intel.com

Hi Babu,

Shortlog: "Introduce resctrl_file_fflags_init() ..."


On 5/24/24 5:23 AM, Babu Moger wrote:
> The functions thread_throttle_mode_init() and mbm_config_rftype_init()

You can drop "The functions".

> both initialize fflags for resctrl files. Adding the new files will

"Adding the new files" -> "Adding new files"? (this should be in new
paragraph)

> involve adding another function to initialize the fflags. All of this

Solution should be in new paragraph and written in imperative mood.

> can be simplified by adding a new function resctrl_file_fflags_init()
> and passing the file name and flags to be initialized.
> 
> Consolidate multiple fflags initialization into resctrl_file_fflags_init()
> and remove thread_throttle_mode_init() and mbm_config_rftype_init().
> 
> Signed-off-by: Babu Moger <babu.moger@amd.com>
> ---

Patch looks good.

Reinette