Received-SPF: pass (google.com: domain of linux-kernel+bounces-214163-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <23aa42c1-6b55-4d29-8995-29fbddf98ed4@intel.com>
Date: Thu, 13 Jun 2024 17:57:51 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v4 06/19] x86/resctrl: Introduce interface to display
 number of ABMC counters
To: Babu Moger <babu.moger@amd.com>, <corbet@lwn.net>, <fenghua.yu@intel.com>,
	<tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>,
	<dave.hansen@linux.intel.com>
CC: <x86@kernel.org>, <hpa@zytor.com>, <paulmck@kernel.org>,
	<rdunlap@infradead.org>, <tj@kernel.org>, <peterz@infradead.org>,
	<yanjiewtw@gmail.com>, <kim.phillips@amd.com>, <lukas.bulwahn@gmail.com>,
	<seanjc@google.com>, <jmattson@google.com>, <leitao@debian.org>,
	<jpoimboe@kernel.org>, <rick.p.edgecombe@intel.com>,
	<kirill.shutemov@linux.intel.com>, <jithu.joseph@intel.com>,
	<kai.huang@intel.com>, <kan.liang@linux.intel.com>,
	<daniel.sneddon@linux.intel.com>, <pbonzini@redhat.com>,
	<sandipan.das@amd.com>, <ilpo.jarvinen@linux.intel.com>,
	<peternewman@google.com>, <maciej.wieczor-retman@intel.com>,
	<linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<eranian@google.com>, <james.morse@arm.com>
References: <cover.1716552602.git.babu.moger@amd.com>
 <6fdb1c3df8960a9d634a7a904421c63406b1a4b7.1716552602.git.babu.moger@amd.com>
From: Reinette Chatre <reinette.chatre@intel.com>
Content-Language: en-US
In-Reply-To: <6fdb1c3df8960a9d634a7a904421c63406b1a4b7.1716552602.git.babu.moger@amd.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UWUrZVk4YkdWR0gzK2xNZlpBM1phRjBkU2tZbVhXSG1UUmZKa25EaUVQRWdJ?=
 =?utf-8?B?amo4THk3VTZaelp3QzJVQ2RubzQ4VUUzQXNUL3c0Mk14R0JVbkFYOUxUVmZx?=
 =?utf-8?B?RjlDQlpNQVV3c1RMN2FBTFNkWnV5aE5KRVF2S1E3eEtkNUwrNGtmUFh0YkFZ?=
 =?utf-8?B?VnVraENwNDJjY29EL0NWWUZjZzdLSkJOU25ZRnlvWTF6cTloWHFIZmpxNHVm?=
 =?utf-8?B?YXprVGM3b0lRYkMrTG5oNWdxYTZMbjRkMEhaUnB6a3NJUUZURm80T0FkQ1R5?=
 =?utf-8?B?ZXBxSzY1U2p0dnNlOW0vV0dyNGhEanlIb0pGdEc2R0dlalI4VzM5UTZKeFc5?=
 =?utf-8?B?R2JhbVI1TC91dHIvdHdHSGF5b1F2R1NFUjRPYWFTb2dEanVvWlBqd3NaSDJt?=
 =?utf-8?B?bW9kWk1mRGJqbnlUUWNVelY4TkNEWFNRU01mblBXb1NGd2hWdEhTam14TGNC?=
 =?utf-8?B?QW1PWlI3Qzltd1RvQndxVlI0dTNac0xKMDBZWTVYT0t4TUVZaU1rWHJ1Q21o?=
 =?utf-8?B?WkRyOXpuTjVSeFpza1M4NTNmRzNsNlF0S0FEc3ZBOGh6QXhSQ0xOQUx0YjZ5?=
 =?utf-8?B?am5ERGloTFlCM3ZvcDZTZVV6RkxQSnZPbW1qelVHeUZpZlA0RWxnM3lZNlpD?=
 =?utf-8?B?N1hiZnlHSkFPOU9uTTBFSkFFY1J5STQ3c1NQMWdxbG5HTmE0aHUwTElJSU1t?=
 =?utf-8?B?b3hoSXBKMkRuZzJlSHRidEwxa09oUEFGSDlrenFvdTlGZHpnRjgveVlsdWhH?=
 =?utf-8?B?M0NEaVM3RVpzL2s4UkhmR2h2YVBoVDBnYWRiWDN0WmdjUGNoTy9RSDc1Nit0?=
 =?utf-8?B?bkZITnU3dHRiRk9XelJRaTk5UnFJa0x6M3orczlES2Zjd3J1bDJKSmxmM1FL?=
 =?utf-8?B?VDV5SDZYaGpyYnB5QXNIeWJEMVFySDlXa3ZLbnJDM3FGak5RM0dsN2NiMUlG?=
 =?utf-8?B?dDFpWkkyZkEzRWYvU2ZMcVFZZEwrMktDWHhlSlUvZjY3OSt0aTdxV2ZoQU1o?=
 =?utf-8?B?RjNiRGFtMFpYR3oxMEFzNEZJRDYzTkppcVpiNjRkdHZvNjNUZDk5V2tiWFFQ?=
 =?utf-8?B?a3J6S0xRbUgxZjNpT3EyZzNwZ0JuK1VtRTVSVjRiNHl1RWpsRklCOENjWkdR?=
 =?utf-8?B?aFNwd0k4T1Z1aFo3TEFoczRUdWQrazJqYkpnaVFNVVZqWnhVV1U4UE9tSVhY?=
 =?utf-8?B?ZDZ0SjkyMTgyY3JLVkZINm5Ua3lHaERpODBJK0dvNTFUOUZJQWZzcThKaTlw?=
 =?utf-8?B?SDlLcFZrZURaaTNRckxvb0V0aDBPeUU5cjFoL1BKcXhZa1ovWWlxUUZmNVo2?=
 =?utf-8?B?cmdleVBqRHpCbjFhelVwVEM1cmdTbHFNYktjN3NtbW01dlRaTXJsKzRXUjNk?=
 =?utf-8?B?dHF3ZXBRK3ZtTWRXTFFtWWtqcmZWN2pLSTdPWjcrSUsrOTRRalozcFp6QkZE?=
 =?utf-8?B?cFJZa1AraHUwaG5TT1l1SStua3hXR2VjMElvS0NSVzdJbkxOOWRTeGRiT2hU?=
 =?utf-8?B?YTMwQ0RCRjVOK1d3L3N4S3lyajdvdXZpZ1I5UmJid1V4T3d2bnp0a2Foam8v?=
 =?utf-8?B?aHE1S0FlamxRYzdpMXJYWHo2alduVUhYVmcxcmc4NUVVNmlkcXBQRTVBdE5j?=
 =?utf-8?B?NXhjS3RtUXJCaWVBREd6TVczSk5QbmlKd0ZKY0hVeVBDN0FpZjIxVnlYVTZ6?=
 =?utf-8?B?R3dyenFDN0RFTm1IV0dtSk5tNEoxOUJFSXdRMDdoaHhkY3oydDlKUVlPbFl0?=
 =?utf-8?B?NldkTVFwdzlHUm5tTklHWVF3djdJNEp5b29FL1EzelpXZTBZT1ZnU21HbnJZ?=
 =?utf-8?B?bmRXRXRzRmIzMDlIUWdQcHdlMFRIYnp6bUJxQmpldlJoNXd0SnFwS2hNODgw?=
 =?utf-8?B?OTB1Z0ZzV3RJZFlZM3NETXhMYnNwb25SZDVuR3A5dFZOTDNLUE52YWNHWk1n?=
 =?utf-8?B?UllycUJHTFUzbFA2RWU1Qi9iRzdmQ20wTDRROTJRZVhUUTNQWjFtWUFjS3Fi?=
 =?utf-8?B?WTg5OW5VTlozeFRyelhsYTNmRFYxTnVqbUl4RWhZR0FMRGw5ZVB3b2RkQTNX?=
 =?utf-8?B?WlBiZlY2dllQK1EvbFkzWGFFY1c5N1g5VWJEMGRxYlFub0dQMk9OaWtFZ3Jh?=
 =?utf-8?B?U0hJamJ4V2xlOE5CRmg4Vit0SUJlelZVM0hKNDdlY1Blem13K0VSaGl1bGhv?=
 =?utf-8?B?L1E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: e440f6d2-3944-4329-42f9-08dc8c0d0625
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jun 2024 00:57:54.6386
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: DSkC5k0bwiGCQzH953Hhk10KbvKGzdMmBP8IBoRg5m2CjVH3VpauI2kpmQgLxP+UBvX4Ic+wgWZoy7qgEVMSnXz8m6gXBB5YsRtz49pabuU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR11MB8567
X-OriginatorOrg: intel.com

Hi Babu,

On 5/24/24 5:23 AM, Babu Moger wrote:
> The ABMC feature provides an option to the user to assign a hardware
> counter to an RMID and monitor the bandwidth as long as the counter
> is assigned. Number of assignments depend on number of ABMC counters
> available.

Take care that this interface will not just be used by ABMC. I assumed that
when the user switches to "soft-RMID" then the value of "num_cntrs" will change?

> 
> Provide the interface to display the number of ABMC counters supported.
> 
> Signed-off-by: Babu Moger <babu.moger@amd.com>
> ---
> v4: Changed the counter name to num_cntrs. And few text changes.
> 
> v3: Changed the field name to mbm_assign_cntrs.
> 
> v2: Changed the field name to mbm_assignable_counters from abmc_counters.
> ---
>   Documentation/arch/x86/resctrl.rst     |  4 ++++
>   arch/x86/kernel/cpu/resctrl/monitor.c  |  1 +
>   arch/x86/kernel/cpu/resctrl/rdtgroup.c | 16 ++++++++++++++++
>   3 files changed, 21 insertions(+)
> 
> diff --git a/Documentation/arch/x86/resctrl.rst b/Documentation/arch/x86/resctrl.rst
> index 02790efaabcc..7ab8172ef208 100644
> --- a/Documentation/arch/x86/resctrl.rst
> +++ b/Documentation/arch/x86/resctrl.rst
> @@ -257,6 +257,10 @@ with the following files:
>   	    # cat /sys/fs/resctrl/info/L3_MON/mbm_local_bytes_config
>   	    0=0x30;1=0x30;3=0x15;4=0x15
>   
> +"num_cntrs":
> +	Available when ABMC feature is supported. The number of ABMC counters
> +	available for configuration.

This can only be understood by folks already familiar with AMD's ABMC feature. There is
no information about what "ABMC feature" is, what an "ABMC counter" is and what
"configuration" can be done with it.

Do you think this num_cntrs will only be used by ABMC? What will happen when user
enables "soft-RMID" or some other mode?

Reinette