Received: by 2002:a89:413:0:b0:1fd:dba5:e537 with SMTP id m19csp506964lqs; Thu, 13 Jun 2024 17:58:38 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVnk+id/TLgmQezZ4+i6hs5KKHVUXi0Ogbz2XiBH+G0sIynygEuq/md0n4BAmfoKSbKMEdXL5KxBo+8aNWVoj/J4HXJpFXGzgrVB1279g== X-Google-Smtp-Source: AGHT+IH4NUWsm3o2i0u17Z3eR9ml1RWGCQcPfjyCt3BHkg51dZn4lE/55QITOEfbQoMRThBdiHlR X-Received: by 2002:a17:906:4109:b0:a6f:5a48:7b90 with SMTP id a640c23a62f3a-a6f60d413f1mr72634166b.38.1718326718723; Thu, 13 Jun 2024 17:58:38 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1718326718; cv=pass; d=google.com; s=arc-20160816; b=0YVdNOsN7yohs1SXSW+plNhQc//+oXzSOu5FyLeNl3NeGl5tKeFc0qmvY5ADB/IXXk 0YnZ1+qHClb/3WnF6aBEYs+oa/HANJQQUfA45hm6c3hQeSWKqloLfAzVlTBq0uUGGOkH xShZUZXIx0WZfIuorReN5n44Wnvj3LPqs+KX6Q7AAh011mFlMv1evHaLynhEAFI5vQj7 uBTkvkTWeDamI6YVYWPUX3BKhBkKxYN8HMyO3zohiDQXwxhMILvRmqDNsyWqlH1R35MO 1PRgKe67L+APAQT7aAC5lbEG+vFM0Y+pJrjS2MfNpOEdZM+VYhKY2mysPVXYXQ3PR4ZR Qxdg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=9ldipDhK2HeoWKfUxvk6ycjiBCm7fBF9kAFryiAWR/k=; fh=6qDCUBeIV0fcb2uHEPZQSYe1u17wWht3pNX+p92lUNY=; b=QVqwGYt9QdaGe/xjOy0kBMYCTr5Ay3M4NBzHCCDhhhO0BdGFY7D1Y4LvtrtDLjqdg6 BGJXPtjumHx4F0y7dvVG/hgv97KVOco4iPVjmj9M0LE59E2bbguGvAzYaRH12yKdNQu5 1jVWW4e56O1m6/+LSdWnQlD5DEWAIOXeQ2kU6NNGVcJY63WntJLmS1UitIGdUbHxj24a fCOQ4TGZNmiiNYW+l9SwU8U8r4fgi6PMvY/ct08w/R7mm7vgsnN2BB7FEqC61gPgumqS An20qR2uMp8I4YBGgyD95syjqoCbYCwQLOks87JqsFmlEVOjNfTRylxfEbBpsLSHio2T 4B7w==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=hs9w6OOB; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-214164-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-214164-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id a640c23a62f3a-a6f56e80fe1si113823266b.1020.2024.06.13.17.58.38 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Jun 2024 17:58:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-214164-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=hs9w6OOB; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-214164-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-214164-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 5FC7A1F21EA2 for ; Fri, 14 Jun 2024 00:58:38 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 25EB77464; Fri, 14 Jun 2024 00:58:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="hs9w6OOB" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4AC504C6C; Fri, 14 Jun 2024 00:58:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718326702; cv=none; b=R2D0isyjyOZnS9iBHaHfZ3Xgg9c9Pa6472j69q1d2lIAdUVLrz6ipQ37QbDvVrHwmwc4kAvsj6EsAEOy7z9URx83fEbksHZGgFQ/8kG4rWF6j9fXrwm5gq8C3CvfC7TUQxA9Grt2oy4aICJxiz5AhUxUEaV6tcdU+D1wt9kXBbY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718326702; c=relaxed/simple; bh=eZ0oO/hp8jBzO9spY4az2MZLGrlN+qaHba4qll3lrUs=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ccrIFyXLfv00EWW+IJHpIyufN7oVnsZKo4JfX6VLFI5amGlmu/NugL3NT6kWeTbhfCMxpOmaOq+hA0GXzjq/xIPe5pfhB9i9lKJD0rSLeUb4sjhrCW8X0lAFWSzj402X6Gq3VYeKkjil23Ckpugm7Mtv5AX01MZtxa0IGpn060s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=hs9w6OOB; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id C0A0CC2BBFC; Fri, 14 Jun 2024 00:58:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1718326701; bh=eZ0oO/hp8jBzO9spY4az2MZLGrlN+qaHba4qll3lrUs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=hs9w6OOB31nuIDTpPBfnS9broNlapG+tstyCX+ee6oy/npOlNIkdNH9lkSpfU6ikE jvgeu6r2dSjze+eaGcB4O359HRq5Y1OLbdTjIr9Tsg4kcKHCLHUsmxtV/7Xqe79Na9 cHdgSTKbdK0nIs9XWyNL3DhcN/kb5Y66VL7WBLwNQahQ+abi60zzwYHSMLi5QOc0Lj s1T1KTErE1kOyBSEvNu1leWyaOlGKFopl/4gTWIdlkbwDNYY4fTsjuQC7YGJXxYeRu PJNboDQ4JpQJenPgcHr+HT3QAZKgK3uuhMwmZd0dQAJTbCnOT+UYQW0cJ81YU/9sOe MPjbDh7EJzMfw== Date: Thu, 13 Jun 2024 17:58:19 -0700 From: Jakub Kicinski To: Maxime Chevallier Cc: davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, Andrew Lunn , Eric Dumazet , Paolo Abeni , Russell King , linux-arm-kernel@lists.infradead.org, Christophe Leroy , Herve Codina , Florian Fainelli , Heiner Kallweit , Vladimir Oltean , =?UTF-8?B?S8O2cnk=?= Maincent , Jesse Brandeburg , Marek =?UTF-8?B?QmVow7pu?= , Piergiorgio Beruto , Oleksij Rempel , =?UTF-8?B?Tmljb2zDsg==?= Veronese , Simon Horman , mwojtas@chromium.org, Nathan Chancellor , Antoine Tenart Subject: Re: [PATCH net-next v13 01/13] net: phy: Introduce ethernet link topology representation Message-ID: <20240613175819.035a1e8e@kernel.org> In-Reply-To: <20240607071836.911403-2-maxime.chevallier@bootlin.com> References: <20240607071836.911403-1-maxime.chevallier@bootlin.com> <20240607071836.911403-2-maxime.chevallier@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 7 Jun 2024 09:18:14 +0200 Maxime Chevallier wrote: > +static inline struct phy_device > +*phy_link_topo_get_phy(struct net_device *dev, u32 phyindex) nit: * on the previous line