Received-SPF: pass (google.com: domain of linux-kernel+bounces-214185-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Fri, 14 Jun 2024 03:35:25 +0200
From: Sebastian Reichel <sebastian.reichel@collabora.com>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Rob Herring <robh@kernel.org>, 
	Krzysztof Kozlowski <krzk+dt@kernel.org>, Conor Dooley <conor+dt@kernel.org>, 
	Bjorn Andersson <andersson@kernel.org>, Hans de Goede <hdegoede@redhat.com>, 
	Ilpo =?utf-8?B?SsOkcnZpbmVu?= <ilpo.jarvinen@linux.intel.com>, Bryan O'Donoghue <bryan.odonoghue@linaro.org>, 
	Heikki Krogerus <heikki.krogerus@linux.intel.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, 
	Konrad Dybcio <konrad.dybcio@linaro.org>, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, 
	linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-usb@vger.kernel.org, 
	linux-arm-msm@vger.kernel.org, Nikita Travkin <nikita@trvn.ru>
Subject: Re: [PATCH v6 4/6] power: supply: lenovo_yoga_c630_battery: add
 Lenovo C630 driver
Message-ID: <r5wjdxqdechzxbyqwbyz7ou6nbxqewb6bruvklvcek2dhspixf@ujavcd3ky7n7>
References: <20240612-yoga-ec-driver-v6-0-8e76ba060439@linaro.org>
 <20240612-yoga-ec-driver-v6-4-8e76ba060439@linaro.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="xulyxrxhy6ccwuiy"
Content-Disposition: inline
In-Reply-To: <20240612-yoga-ec-driver-v6-4-8e76ba060439@linaro.org>


--xulyxrxhy6ccwuiy
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Wed, Jun 12, 2024 at 12:59:35PM GMT, Dmitry Baryshkov wrote:
> On the Lenovo Yoga C630 WOS laptop the EC provides access to the adapter
> and battery status. Add the driver to read power supply status on the
> laptop.
>=20
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
>  drivers/power/supply/Kconfig                    |   9 +
>  drivers/power/supply/Makefile                   |   1 +
>  drivers/power/supply/lenovo_yoga_c630_battery.c | 500 ++++++++++++++++++=
++++++
>  3 files changed, 510 insertions(+)
>=20
> diff --git a/drivers/power/supply/Kconfig b/drivers/power/supply/Kconfig
> index 3e31375491d5..55ab8e90747d 100644
> --- a/drivers/power/supply/Kconfig
> +++ b/drivers/power/supply/Kconfig
> @@ -167,6 +167,15 @@ config BATTERY_LEGO_EV3
>  	help
>  	  Say Y here to enable support for the LEGO MINDSTORMS EV3 battery.
> =20
> +config BATTERY_LENOVO_YOGA_C630
> +	tristate "Lenovo Yoga C630 battery"
> +	depends on OF && EC_LENOVO_YOGA_C630

The driver should no longer depend on OF. Otherwise LGTM.
Thanks for reworking it.

Greetings,

-- Sebastian

--xulyxrxhy6ccwuiy
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAmZrnlUACgkQ2O7X88g7
+po9/g/+LchaOK3fxp4Ks0qfIV6s6rPwUjxhMA9+JLpq62BTpdYsklPtbF3aCjJE
8eJzchrPFDxhP0/jJFYIMYQsy4dBY5GJS3VK02fflNhSgLgLy8aLlFbafrYIu+Av
GmWi/M6UcvTJ366avMqazRvWbwqomMzQ6yUkA9dqYNTo9WnjWV6ereiWTkRlonFo
GN61nFbjoMiNS7fvb216KEq2EbZ+RdZjzup0k/b10Zyu+zX6iIbyoWQ8ALdQXyK8
TsMshTv9R/Mbk3pVp+0EIxPPnbkTG2GkrzJmK2pE8Nh3Cs3fVC9zjojZtj9XtZID
RZYMjk+2l/1xZEEnQfUK8SBzRx3DtHSG5dDJr7IHaqWfphVI2BGQwgujsGsbuu4r
rKKv6k7tyAXMXa3KHNzTcf7msmTnn3cipWnaBY3OtJ4Q088aXCSKxti1l0zFSjGN
UXzgECgLeNMSbWEEZZ0TqBEY+ye8YBpV6/Q0cv6YfFfl0yr16tqsStj9vFNR7FFS
hicmJpxzRvTwuvVOV0GpgxNiA51aqnaxXI4lDNHfCKHQ97Hq50BeNkd3almuYjgO
F8e53wz2aopNqBT4WSOSLi4MAZbGQRG7kiVCyl2IBPnBMkoShBqWqdF6BWLuYodc
+xLePf7j6ThMA1q1+JuLpv2rpvsEPrWyoYTHAdRGqee37XiKaUQ=
=J71+
-----END PGP SIGNATURE-----

--xulyxrxhy6ccwuiy--