Received-SPF: pass (google.com: domain of linux-kernel+bounces-214187-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <915bebc0-03bb-453f-b468-6cd8aec08de5@intel.com>
Date: Thu, 13 Jun 2024 18:42:15 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v4 09/19] x86/resctrl: Initialize ABMC counters bitmap
To: Babu Moger <babu.moger@amd.com>, <corbet@lwn.net>, <fenghua.yu@intel.com>,
	<tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>,
	<dave.hansen@linux.intel.com>
CC: <x86@kernel.org>, <hpa@zytor.com>, <paulmck@kernel.org>,
	<rdunlap@infradead.org>, <tj@kernel.org>, <peterz@infradead.org>,
	<yanjiewtw@gmail.com>, <kim.phillips@amd.com>, <lukas.bulwahn@gmail.com>,
	<seanjc@google.com>, <jmattson@google.com>, <leitao@debian.org>,
	<jpoimboe@kernel.org>, <rick.p.edgecombe@intel.com>,
	<kirill.shutemov@linux.intel.com>, <jithu.joseph@intel.com>,
	<kai.huang@intel.com>, <kan.liang@linux.intel.com>,
	<daniel.sneddon@linux.intel.com>, <pbonzini@redhat.com>,
	<sandipan.das@amd.com>, <ilpo.jarvinen@linux.intel.com>,
	<peternewman@google.com>, <maciej.wieczor-retman@intel.com>,
	<linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<eranian@google.com>, <james.morse@arm.com>
References: <cover.1716552602.git.babu.moger@amd.com>
 <395f8ad5bba4e572cb8bcee11fa19b02cc950253.1716552602.git.babu.moger@amd.com>
From: Reinette Chatre <reinette.chatre@intel.com>
Content-Language: en-US
In-Reply-To: <395f8ad5bba4e572cb8bcee11fa19b02cc950253.1716552602.git.babu.moger@amd.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V0hUcXYzRCs4RE1XZEg0clRpTjZtNFBxNnJaYWRTd243bmdxNjlDNlJQd29V?=
 =?utf-8?B?eHhZZ0RIV21jWFg3TVZ4NjJtMGhvY0gvenpNSDdnUU11TjM1MHlBKzFGVUFS?=
 =?utf-8?B?RU5GRDRzSFVZWmJIUVBWSjRNMUlTUW5ELzlxZGF4MCtBWEJpSFhxbnUvUkFC?=
 =?utf-8?B?S1RybU55VmVkRmxIZWt2WVBNL2FOb29Fa0tCaW1GQzkvT1Ftcks2Q2VtTEth?=
 =?utf-8?B?T0EvaW9OVkJ3enA4QmdSMEkwT2swci9TRCtJTUF6c0FTcXpOeTA0SE8zZFgv?=
 =?utf-8?B?ckN3REd4SUhKNm9aaUhIeDNPZXU4dm5IWXdnRysrNUZhUEdUQ0hCclhaVDB0?=
 =?utf-8?B?dnRBbFF5S3gvdW1mZkMvN21ubnM2TGdzWDhwdVF1QmhXUVZLZW1HZzUzemFM?=
 =?utf-8?B?blh0TUxUQVNZckNiQzM1MXptejRlWHhlREtLM1dXL1d4bi81OTFOR3Jza3RU?=
 =?utf-8?B?cURBOHJqTjg0b2lFNE9IVlordXpFelFEaFY5ditwRzVLRWF6U01DbnpOZWlS?=
 =?utf-8?B?enZXcnJ1Qy82bUlLYXpwb05MOHZsZDBNNnRSUXdTUzUwZE1xK1pTMGE4akZZ?=
 =?utf-8?B?MDN4eWdteTVNUFlDbG9kUmdCdG9QNmdxdVk2VVdjM0JOanRjNGY3Mktrd0k2?=
 =?utf-8?B?eGFPcnpPZnF3OUFrbSs0dVViNkpMaDJZMGdFMUgxTU1uVFFGcWh0OGlEaFZ4?=
 =?utf-8?B?V0g2TDFTVGhpemNYTmRPY2ZGSXA4MVlHSndCRVBiTWF4VTFUOVpBVE00aVBW?=
 =?utf-8?B?RVd6VGdKdjRyRldCay94dVdWdWZEYTNZdWEwNis2UlIzalZhR09BM0lBdFV4?=
 =?utf-8?B?S0MxUDR0VVgwOXo3ZEErY1JEMm5aV0Rzdmt0TUtEZ25XblBsYlpYZFY0OXh4?=
 =?utf-8?B?OVBpajN2cWZaYTlnS1VNM2QxbHJUa2FwMFFxclZNQmptVGdETTlsbnJ0RXN0?=
 =?utf-8?B?VTZxQjE2VWVBcnZUOWt0c0lscm1nRWt0NEVqL2pLZ2NGNHZhclJ1MVdmbG5i?=
 =?utf-8?B?WXA1dHRkYU83bVMvRWFkTVlWQUU0WkMyUVkwUVlQZE1YT01GYS9WbC9sWGdK?=
 =?utf-8?B?U2pNdjNSTlhmejlzZ1pPRXZSVjRHSmppWFB3blZuemJPYWpMaTdOYzhHRm9m?=
 =?utf-8?B?dEJFV09nNURmY0ZHMU8xNk1Wc2lseWpaSjU5T1oyaXNRcnBtQUJnek9ZbnlN?=
 =?utf-8?B?NTk3VEY3V3I3M3pVeU9Ic2RpUUpVMUwxR3p3ZWNVbUZud2krTzI3YXNxbzNo?=
 =?utf-8?B?R0xpdGErdm9QWHBCdEJ2cnB3OGlyb2N5ZnJMa0ZkdDNlMExRUjNycUhkdnpm?=
 =?utf-8?B?U1BQckcvMzArQk1vSW85Z2RhODVwU3NMNE1WS08wRUpGcmJQdld5YVJCZEZR?=
 =?utf-8?B?dHFmU2JMNG9nK0NoL292eW50djBMaDlwTTI2NmdVdzA4bjNRNzhsbmVjTU1r?=
 =?utf-8?B?YmkyZ1JwWG91N0pwWmo4ZHhpTys2ajF0ZHVNTUsza0w2NU5LRSt4UjBCaFZ4?=
 =?utf-8?B?Ni92azc1NktvYTVvR3hESTRnbFNyVTkxMXRMSEZ1WXFBam93RTN1eXJmMkxQ?=
 =?utf-8?B?Y1p0WTZhYVY1NmFKSEJuKzdkTjVKUUlvbEdrSDdMVUJJSVlkUFNvV3RVN2Zz?=
 =?utf-8?B?cWVRUlp5c3NTMjBZQU1lWU1aRzdOS1ZXT1k0SWhqMDJucDNtM0w5a2c1Y2hz?=
 =?utf-8?B?aHNMZTZFR01ITXFaSFlnTEZDQWtXdTdJZ0U1OGF4c0VJbjUxbzRQTWtNeGQ3?=
 =?utf-8?B?bzkrL0ptSVNPTXA4NmV2d203NG5VMytnV0tIWUV0N3lhd1Q2WkwxcTlTWEhD?=
 =?utf-8?B?bHo0UU1kL1lkcGczbzFaYWJaa0hyTzZ3ak9haGdURjBXeEJKQVVCNjNrbXFG?=
 =?utf-8?B?ek9wWnRJWThaUkwramZXY1hHS0h1NVdhZTV5OHR1UUFySWFyNGRIWW0yL3Rz?=
 =?utf-8?B?WlhsaDIvVWVtRkN5WTJCVmdZaTgvTjJqclA5cTNmb0ZBbG1hVXRvUU93blFh?=
 =?utf-8?B?Q3ZIUHlUMldJRHlROUdrcEhQT1VXT3U2Yi9iUFRZajJ4NGFVYVlqVTNqUVpa?=
 =?utf-8?B?UUFNSGVlT21SQ21LNTlrWGtBdUx5UThIa3pkTDJjNVFQQzdRdEZKdHNqY1Nh?=
 =?utf-8?B?QXhkVnd0UnJNckZpN3BtQ3V5WGkyYXBLaWhUakJIL2gxMEtPMVoyTzI3MmZt?=
 =?utf-8?B?Unc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: d5fcbf1e-9885-43d8-9033-08dc8c133cbc
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jun 2024 01:42:23.2252
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8tOWMHroDeElFwYe0o0GqZbVjjtdhT0a/Mj9ZAJQETzlKhba1qu2d6+/dgH5L5FC6gVOgxZVLqEKhVe5LTxzynbvsgYXVVI758BeWdcXPWg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB6885
X-OriginatorOrg: intel.com

Hi Babu,

On 5/24/24 5:23 AM, Babu Moger wrote:
> Hardware provides a set of counters when the ABMC feature is supported.
> These counters are used for enabling the events in resctrl group when
> the feature is supported.
> 
> Introduce num_cntrs_free_map bitmap to track available and free counters.
> 
> Signed-off-by: Babu Moger <babu.moger@amd.com>
> ---
> v4: Changed the name to num_cntrs where applicable.
>      Used bitmap apis.
>      Added more comments for the globals.
> 
> v3: Changed the bitmap name to assign_cntrs_free_map. Removed abmc
>      from the name.
> 
> v2: Changed the bitmap name to assignable_counter_free_map from
>      abmc_counter_free_map.
> ---
>   arch/x86/kernel/cpu/resctrl/rdtgroup.c | 23 +++++++++++++++++++++++
>   1 file changed, 23 insertions(+)
> 
> diff --git a/arch/x86/kernel/cpu/resctrl/rdtgroup.c b/arch/x86/kernel/cpu/resctrl/rdtgroup.c
> index 3071bbb7a15e..400ae405e10e 100644
> --- a/arch/x86/kernel/cpu/resctrl/rdtgroup.c
> +++ b/arch/x86/kernel/cpu/resctrl/rdtgroup.c
> @@ -186,6 +186,23 @@ bool closid_allocated(unsigned int closid)
>   	return !test_bit(closid, &closid_free_map);
>   }
>   
> +/*
> + * ABMC Counter bitmap and length for tracking available counters.
> + * ABMC feature provides set of hardware counters for enabling events.
> + * Each event takes one hardware counter. Kernel needs to keep track
> + * of number of available counters.
> + */
> +static unsigned long num_cntrs_free_map;

Why does variable have "num" in its name? That seems strange. How
about just "mon_cntrs_free_map

> +static u32 num_cntrs_free_map_len;

Same comment about "num" ... also, any special reason why u32 is needed?

> +
> +static void num_cntrs_init(void)

mon_cntrs_init() ?

> +{
> +	struct rdt_resource *r = &rdt_resources_all[RDT_RESOURCE_L3].r_resctrl;
> +
> +	bitmap_fill(&num_cntrs_free_map, r->mon.num_cntrs);
> +	num_cntrs_free_map_len = r->mon.num_cntrs;
> +}
> +
>   /**
>    * rdtgroup_mode_by_closid - Return mode of resource group with closid
>    * @closid: closid if the resource group
> @@ -2459,6 +2476,12 @@ static int resctrl_abmc_set_all(enum resctrl_res_level l, bool enable)

resctrl_abmc_set_all() was initially created as a complement of
resctrl_abmc_set_one() ... but with more initialization added to
resctrl_abmc_set_all() this relationship becomes vague.

>   	struct rdt_resource *r = &rdt_resources_all[l].r_resctrl;
>   	struct rdt_domain *d;
>   
> +	/*
> +	 * The bitmap num_cntrs_free_map needs to be reset when switching
> +	 * the monitor mode.

This comment puts in words what can be understood by just looking at the code.
What would be useful would be to explain _why_ this needs to be done ...
what happens to the previously assigned counters?


> +	 */
> +	num_cntrs_init();
> +
>   	/*
>   	 * Update QOS_CFG MSR on all the CPUs associated with the resource
>   	 * Hardware counters will reset after switching the monotor mode.

Reinette