Received-SPF: pass (google.com: domain of linux-kernel+bounces-214192-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Fri, 14 Jun 2024 03:47:09 +0200
From: Sebastian Reichel <sebastian.reichel@collabora.com>
To: Ilpo =?utf-8?B?SsOkcnZpbmVu?= <ilpo.jarvinen@linux.intel.com>
Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>, 
	linux-pm@vger.kernel.org, Rob Herring <robh@kernel.org>, 
	Krzysztof Kozlowski <krzk+dt@kernel.org>, Conor Dooley <conor+dt@kernel.org>, 
	Bjorn Andersson <andersson@kernel.org>, Hans de Goede <hdegoede@redhat.com>, 
	Bryan O'Donoghue <bryan.odonoghue@linaro.org>, Heikki Krogerus <heikki.krogerus@linux.intel.com>, 
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Konrad Dybcio <konrad.dybcio@linaro.org>, 
	devicetree@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>, 
	platform-driver-x86@vger.kernel.org, linux-usb@vger.kernel.org, linux-arm-msm@vger.kernel.org, 
	Nikita Travkin <nikita@trvn.ru>
Subject: Re: [PATCH v6 4/6] power: supply: lenovo_yoga_c630_battery: add
 Lenovo C630 driver
Message-ID: <yrysv4c2xeazfi2w3g35qsyoz6b4k3uunzpgj3cdtbyussufqn@5fnuoeubwjnr>
References: <20240612-yoga-ec-driver-v6-0-8e76ba060439@linaro.org>
 <20240612-yoga-ec-driver-v6-4-8e76ba060439@linaro.org>
 <4fc43c56-f801-909a-9178-166d275a5fee@linux.intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="tqsq4jiejojoj7cg"
Content-Disposition: inline
In-Reply-To: <4fc43c56-f801-909a-9178-166d275a5fee@linux.intel.com>


--tqsq4jiejojoj7cg
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Thu, Jun 13, 2024 at 10:57:41AM GMT, Ilpo J=E4rvinen wrote:
> > +	adp_cfg.supplied_to =3D (char **)&yoga_c630_psy_bat_psy_desc_mA.name;
>=20
> This is not problem with your patch but I'm wondering why supplied_to=20
> needs to be non-const char *. Are those strings expected to be altered by=
=20
> something, I couldn't find anything to that effect (the pointer itself=20
> does not become const if supplied_to is changed to const char **)?

No, they are not supposed to be modified. It should be fine to make
the struct member const char **, patches are welcome :)

-- Sebastian

--tqsq4jiejojoj7cg
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAmZroRkACgkQ2O7X88g7
+ppBkg/9H0Vh77I1df6YmgtH3Dc3JT3L5qfTx7EDy6jHu7ihZ6qWM7UoWR6UbThB
eM9iqWs+qw9CbO+oiHX4TwHItM8ua6CjwOTJaXN3LRvQ86tZ1S3oYFYQRz3cqHSy
guEdkIELM9rKsTguKre5bJrXNcfQ5T6jjrAJx+60/Y+pJGzJD7SimNGRmBU9erSp
HBMQ548Ct5roKoNqzauPnGRCXslMVSGAk9vmGu3dv4C1VFr30ndPeRnK4YfPLl50
cjEu8x8MenIvkNSA7mpIFZem4NBnmQVWVtfi6sMuvfH230pnKi6SvNKr4daPrYMI
atHouDXhMUMcMg6/p+ARuk/1BcW3kBl3H+2piHY1qj6Riuv+zch4Ah0Wz3SZQmdA
GiKlfLZVk4LPx5e3EIUR8cNXUrNOVwj7GnH8D+OIgnPIoMQNufNPYFvCCFWipqjP
OnrfAXz1ebAFpREjHm9rfLk7PvYmWnTLS2F19cfmTbC+bQqulgvclLOITdOQxr3V
okhD1SjFC6Wm+SkwnNFOsNSf1aEwOnpOJkhvdKS0dRAY5AkCH1H5baTAZal+hGdg
GA3qo6hCZTjGGofYSp302ltyJQ9Nn61PI48gBa79+7ovYMkrZsYmWnHJibxnFcQI
SnHurPxpcCALPl8osrReAKV8CUVAsP4KL6+NbdgcQdyF1UxEH3w=
=xOfT
-----END PGP SIGNATURE-----

--tqsq4jiejojoj7cg--