Received-SPF: pass (google.com: domain of linux-kernel+bounces-214210-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <87bdeabe-7fe4-47fd-9903-8603a07b6938@collabora.com>
Date: Fri, 14 Jun 2024 07:35:13 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v5] drm/ci: add tests on vkms
Content-Language: en-US
To: Maxime Ripard <mripard@kernel.org>
Cc: dri-devel@lists.freedesktop.org, airlied@gmail.com, daniel@ffwll.ch,
 rodrigosiqueiramelo@gmail.com, melissa.srw@gmail.com, mairacanal@riseup.net,
 hamohammed.sa@gmail.com, robdclark@gmail.com,
 maarten.lankhorst@linux.intel.com, tzimmermann@suse.de,
 daniels@collabora.com, helen.koike@collabora.com,
 guilherme.gallo@collabora.com, sergi.blanch.torne@collabora.com,
 linux-kernel@vger.kernel.org
References: <20240611091037.558969-1-vignesh.raman@collabora.com>
 <20240613-bipedal-eccentric-locust-91632b@houat>
 <bd430442-6074-44b1-ba62-d3fa9e7bf28e@collabora.com>
 <20240613-swine-of-abstract-flowers-c8d171@houat>
From: Vignesh Raman <vignesh.raman@collabora.com>
In-Reply-To: <20240613-swine-of-abstract-flowers-c8d171@houat>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Maxime,

On 13/06/24 22:58, Maxime Ripard wrote:
> Hi,
> 
> On Thu, Jun 13, 2024 at 01:56:10PM GMT, Vignesh Raman wrote:
>> On 13/06/24 13:07, Maxime Ripard wrote:
>>> Hi,
>>>
>>> On Tue, Jun 11, 2024 at 02:40:37PM GMT, Vignesh Raman wrote:
>>>> diff --git a/drivers/gpu/drm/ci/xfails/vkms-none-flakes.txt b/drivers/gpu/drm/ci/xfails/vkms-none-flakes.txt
>>>> new file mode 100644
>>>> index 000000000000..56484a30aff5
>>>> --- /dev/null
>>>> +++ b/drivers/gpu/drm/ci/xfails/vkms-none-flakes.txt
>>>> @@ -0,0 +1,15 @@
>>>> +# Board Name: vkms
>>>> +# Bug Report: https://lore.kernel.org/dri-devel/61ed26af-062c-443c-9df2-d1ee319f3fb0@collabora.com/T/#u
>>>> +# Failure Rate: 50
>>>> +# IGT Version: 1.28-g0df7b9b97
>>>> +# Linux Version: 6.9.0-rc7
>>>> +kms_cursor_legacy@long-nonblocking-modeset-vs-cursor-atomic
>>>> +kms_flip@basic-flip-vs-wf_vblank
>>>> +kms_flip@flip-vs-expired-vblank-interruptible
>>>> +kms_flip@flip-vs-wf_vblank-interruptible
>>>> +kms_flip@plain-flip-fb-recreate-interruptible
>>>> +kms_flip@plain-flip-ts-check
>>>> +kms_flip@plain-flip-ts-check-interruptible
>>>> +kms_flip@flip-vs-absolute-wf_vblank
>>>> +kms_flip@flip-vs-absolute-wf_vblank-interruptible
>>>> +kms_flip@flip-vs-blocking-wf-vblank
>>>
>>> We should have the header for every line here
>>
>> All the flakes in these tests were observed with version
>> 6.9.0-rc7/1.28-g0df7b9b97. So can we group them together?
>>
>> If we update this file for different IGT/kernel version, we can add a
>> separate header for each test.
> 
> If we don't however, we have no way to tell in a couple months whether
> those flakes were there before we were adding those metadata, or if the
> metadata applies to everything, or only a subset.

I will send a v6 with this change. Thanks.

Regards,
Vignesh