Received: by 2002:a89:413:0:b0:1fd:dba5:e537 with SMTP id m19csp537251lqs; Thu, 13 Jun 2024 19:24:17 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXmLBjbGEyGE4zfYR+/8NrZhbDPnkJ9MWR07A98jViR/2QwTwXx5do9v7frbzaS9hCtscqTrcQSLkor9uKMhPNmZyOAVRyqE0shbDnIAA== X-Google-Smtp-Source: AGHT+IGbQVbVC0tYVvpDsGRglp9C9fk5h4wSsv4kui2BYZvVBsF9bJcXeh2czVRTWoUJE+KwQcu9 X-Received: by 2002:a05:6e02:1a02:b0:375:9d6d:12fc with SMTP id e9e14a558f8ab-375e0e31adfmr12506805ab.19.1718331857170; Thu, 13 Jun 2024 19:24:17 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1718331857; cv=pass; d=google.com; s=arc-20160816; b=qnD81JdttyUgyqbEhej2A7WKZpKs9hFYNQ1MblybfPdIla4xDPqZ+2HnNigyyw9Kie 0c+LmwOyJvaE5o7dZpTwKaF1bwUMECT4jlY9yUG6tYEr/TSl/ElXxBe/42EUC35SNoVC Bm3X2C733fEjzqtaByyoOnta47O8DlacUGUxF/3u5JGt6JctEhxH5qDi3U+YG9PX+AnE z7BjHgbBNl3HrqrLCr3cSc6+7mVFCQehyGtJmkrpEKCNoxvP/em7PxRBZ4naoxUFzhbQ 6LtgNHZraESTUPUKvWOCZzQOiT5UN/bx7T7MCDo9XsBXpe3Cnfv/fLDr2LNm9WP57Uxg UGrg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=3wbXBl4iTgVDeRdgFASpmQd/bkRz1fit9xhsn00Vf2s=; fh=zUqfdkhys9tKnN0KtPjNYbnfRijrUzm0vo0ZLZbiZZs=; b=juycVcKVxQRSvfgrqIGkmzFp3PHL83KoICxOrWN+cBzF7nJqnEhJ02GZWl8vr/by51 uIorq6jUVu0LPOhHEju+b/Ym86cGkdyloerQDEeI/hVgzg/6eiYXUIOHzUPZ3iy9Nc3N IcC31DLC7nmzP8IPCEI9n1/2ecFYL9BYjh5lQaFiplNVkLxmsZij7PKAJTIeErUuV1W2 LNHeD1y/zRls7p63yhqWR+U1p7ON6fC6cFCBNz+V5Tio2dTA35AFzjXu82Y+FlhxAhlF tQaGZh1o7RZZOBgntlvoHcDkLHBP4gSOFzQBtRr+/QvCYBOyMTg5a87B1k7JZBXhiQ9y 7dVA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2023-11-20 header.b=BJLDlIkc; arc=pass (i=1 spf=pass spfdomain=oracle.com dkim=pass dkdomain=oracle.com dmarc=pass fromdomain=oracle.com); spf=pass (google.com: domain of linux-kernel+bounces-214222-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-214222-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=oracle.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id 41be03b00d2f7-6fede81ff83si2416840a12.234.2024.06.13.19.24.16 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Jun 2024 19:24:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-214222-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2023-11-20 header.b=BJLDlIkc; arc=pass (i=1 spf=pass spfdomain=oracle.com dkim=pass dkdomain=oracle.com dmarc=pass fromdomain=oracle.com); spf=pass (google.com: domain of linux-kernel+bounces-214222-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-214222-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=oracle.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id B7A5C2834A0 for ; Fri, 14 Jun 2024 02:24:16 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6D196183079; Fri, 14 Jun 2024 02:24:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="BJLDlIkc" Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2E0B42836A; Fri, 14 Jun 2024 02:24:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.177.32 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718331847; cv=none; b=X15I5JSIgY3MGqMx9gKxRKMegnBlv9ikRWYMGdkhl6TuO1f6POtlFe46/GH7zrpkg77cLe19UrKPjhOXQv13/FCj1ROGFH+PbsQ0zrszUfUHVGxm1f2LPB/Ri8U6EnpD+V/Rf61Qhwyagtm7iocgpzHnqrKEukTSx/w5qkK8Fgc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718331847; c=relaxed/simple; bh=3FQ3MEtOrZtut3EegPkICwKG9Bx9tibnLwOSZ/KO8Hk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=jgvm2EMuppU0G3XNhHYyOF7iKSeefudbhbpoU0LgI1QKrAhzWzq5RrapYqBNAdGUlzgTshiHtKfTXIWBaQ3bJaM27TNuZDA9bZCMtMeKbVQ5utQzv5UAB6iVORO6a3XjqWb9EQH2brBK1n9+o2jk4Gb/hWl4LsaPCKp85vY1jcY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=BJLDlIkc; arc=none smtp.client-ip=205.220.177.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 45E1fRRS009891; Fri, 14 Jun 2024 02:23:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; s= corp-2023-11-20; bh=3wbXBl4iTgVDeRdgFASpmQd/bkRz1fit9xhsn00Vf2s=; b= BJLDlIkcV3nwUQ1tmNQv/Yj/FRgeuN/7w9xNfzdSk11fGtSBID98N8V2Ap9wFbyT MiW0Lk8yFGvKolOFBAPV0n0N6nVdKi78zSkY4ry8TS7Zm7vOrMJRsugGJTDN6f59 VLKtJSh5qcBMI/wdnkPyYGCTLv6Zxb8eJ03/qZvFIXAa7tn5W9fVKrjPROvftiEq 913zD0nHZJUPfuBPjLvs7btdcwDuO9nRbDwbEdsW5ajQGDjuraOo4+N6ItiCYHpw GcRxx64XwgQRJYB1Ho45C4vtkrqrhv0Iiual4rokjhRokGeHdM2QDHIVsdnswHnt Pc2lGXSpN8podzDnwC7X5Q== Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta03.appoci.oracle.com [138.1.37.129]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3ymh19ar65-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 14 Jun 2024 02:23:46 +0000 (GMT) Received: from pps.filterd (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 45E1dakL012556; Fri, 14 Jun 2024 02:23:45 GMT Received: from pps.reinject (localhost [127.0.0.1]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3ynca1vrjp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 14 Jun 2024 02:23:45 +0000 Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 45E2NhG3009531; Fri, 14 Jun 2024 02:23:45 GMT Received: from ca-mkp2.ca.oracle.com.com (mpeterse-ol9.allregionaliads.osdevelopmeniad.oraclevcn.com [100.100.251.135]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTP id 3ynca1vrfh-2; Fri, 14 Jun 2024 02:23:45 +0000 From: "Martin K. Petersen" To: linux-scsi@vger.kernel.org, Joel Slebodnick Cc: "Martin K . Petersen" , linux-kernel@vger.kernel.org, alim.akhtar@samsung.com, avri.altman@wdc.com, bvanassche@acm.org, James.Bottomley@HansenPartnership.com, peter.wang@mediatek.com, manivannan.sadhasivam@linaro.org, ahalaney@redhat.com, beanhuo@micron.com Subject: Re: [PATCH] scsi: ufs: core: Free memory allocated for model before reinit Date: Thu, 13 Jun 2024 22:23:01 -0400 Message-ID: <171833164847.271429.16176301177294117604.b4-ty@oracle.com> X-Mailer: git-send-email 2.45.1 In-Reply-To: <20240613182728.2521951-1-jslebodn@redhat.com> References: <20240613182728.2521951-1-jslebodn@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-06-13_15,2024-06-13_02,2024-05-17_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=963 adultscore=0 phishscore=0 suspectscore=0 malwarescore=0 mlxscore=0 spamscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2405010000 definitions=main-2406140014 X-Proofpoint-GUID: qKSmDeCooTkvJLEx_S1zgxQ3b7iJ95n- X-Proofpoint-ORIG-GUID: qKSmDeCooTkvJLEx_S1zgxQ3b7iJ95n- On Thu, 13 Jun 2024 14:27:28 -0400, Joel Slebodnick wrote: > Under the conditions that a device is to be reinitialized within > ufshcd_probe_hba, the device must first be fully reset. > > Resetting the device should include freeing U8 model (member of > dev_info) but does not, and this causes a memory leak. > ufs_put_device_desc is responsible for freeing model. > > [...] Applied to 6.10/scsi-fixes, thanks! [1/1] scsi: ufs: core: Free memory allocated for model before reinit https://git.kernel.org/mkp/scsi/c/135c6eb27a85 -- Martin K. Petersen Oracle Linux Engineering