Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758027AbYBGRUa (ORCPT ); Thu, 7 Feb 2008 12:20:30 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756114AbYBGRUR (ORCPT ); Thu, 7 Feb 2008 12:20:17 -0500 Received: from gateway.drzeus.cx ([85.8.24.16]:34763 "EHLO smtp.drzeus.cx" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756063AbYBGRUP (ORCPT ); Thu, 7 Feb 2008 12:20:15 -0500 Date: Thu, 7 Feb 2008 18:19:17 +0100 From: Pierre Ossman To: Frank Seidel Cc: Philip Langdale , sdhci-devel@list.drzeus.cx, linux-kernel@vger.kernel.org, Andrew de Quincey Subject: Re: [PATCH v2] mmc: extend ricoh_mmc to support Ricoh RL5c476 Message-ID: <20080207181917.18b11638@poseidon.drzeus.cx> In-Reply-To: <200802070920.39120.fseidel@suse.de> References: <200801311838.24743.fseidel@suse.de> <200802041925.43081.fseidel@suse.de> <20080207090834.3c6fde7d@poseidon.drzeus.cx> <200802070920.39120.fseidel@suse.de> X-Mailer: Claws Mail 3.2.0 (GTK+ 2.12.7; i386-redhat-linux-gnu) Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwCAMAAABg3Am1AAAAAXNSR0IArs4c6QAAADNQTFRFEgwFRSofeTwxZEI1h1lFl1ZHeGBetHZk24VzuZJ43p2GsbKw/Lmg2MTL/NO3/+/Q//fpWFujUwAAAk5JREFUSMeNlVcWnDAMRd0bLux/tVGxiAEzic7hZ+Zd1IU6NtbYdn8daic/cgj52CPqLQ8hOBdjzsD8G2hHsCiPBS2/nTyABi93zvsYUyql1v6KSz30AeUAJLAK1uuDUI94WA7GDsAePtRDfwFRgP7DA8vvwOgQ1R5oYQUKAwOsfwDHDcAcWH+e5xagiooey1SwSAy0L8C7BaDKdgKWoNQtIjYEfHQGzMcKwNgCpLdgBn14ZzXNSPkJWK201vjiHMkXZg7AuQWCA7G2DPTiMSIsLSZxbgEIwlqEjE+9WBu0yaWOHwDLLQE9WmMieCBgtG1IAFgBzo7tlojGtbI3wFljuU4JdL3ghPeO+tFr2QHG0DOBSuN0kofaU302zmKbcTrgAWDUywG0OvXELi6gZScAdq6WnhYgvYDGu0YQjYSZs3ROID0B4y+jjpWyAhjePWkAjKwD5o09xioNBoro/+YQZjzTg8ce1CJtwFvwAMDFBEjv6cgI0P/u0DqtGJOjNSAm4e0jABxsgDYXSADQw2wwsFyzdePCAviE48QexseKNiGcp4jgKNEVAGC7QEwY5+S6Qpf50NzujHrdYgEKH0o8ZJ/AQR8HAGiaugDjG2i4ddZx4wToPwB0gQsEfjyFRKf1M+kLQC8u5iuoX8BhxYCQJPZXQ7LQdDnQR87/BdCpQQSJpREh7EMSQOvpYwJaqbAHgrUXkWehxhmUUjpsQ+IDSHlzEvidywrtDYSpnHVioNbstBLi9o3Dn/WqZ3Nw1pUQy8bN3/QdiPiVUZfpP4cDVEKd2cXEAAAAAElFTkSuQmCC X-Face: @{|$W51qEixc&6}dq_38NM^&.vv|'{O)ae?DMZ1%VYxuhN2}5VpQ!'gx[{V+8Xw'+cV5*491_)-SU2YT8s@4`H;@:ELS'/P(@.JxxJi/C8mG0H#A^R X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1530 Lines: 46 This is a MIME-formatted message. If you see this text it means that your E-mail software does not support MIME-formatted messages. --=_hera.drzeus.cx-19376-1202404814-0001-2 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Thu, 7 Feb 2008 09:20:38 +0100 Frank Seidel wrote: > >=20 > > Wouldn't it be prudent to have a check that this is indeed a R5C832, > > and a failure mode if it's none of the two known devices?=20 >=20 > Also thought about that, but as far as i can see this cannot happen since > we only probe for those two devices and deny to continue if anything else > /those two were not found in the beginning. >=20 Can never be too careful though. :) I've applied the patch for now. Feel free to keep digging and finding some = docs for those regs though. Rgds Pierre --=_hera.drzeus.cx-19376-1202404814-0001-2 Content-Type: application/pgp-signature; name="signature.asc" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.8 (GNU/Linux) iEYEARECAAYFAkerPZUACgkQ7b8eESbyJLhUQgCeMon45EHakEoKTmUs0/eS7nKG 0JYAn1pgKcN2Nxdol6ZOEVjtSF7i8uSa =CvxB -----END PGP SIGNATURE----- --=_hera.drzeus.cx-19376-1202404814-0001-2-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/