Received-SPF: pass (google.com: domain of linux-kernel+bounces-214336-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Fri, 14 Jun 2024 12:14:15 +0800
From: Chen Yu <yu.c.chen@intel.com>
To: K Prateek Nayak <kprateek.nayak@amd.com>
CC: Chunxin Zang <spring.cxz@gmail.com>, Honglei Wang
	<jameshongleiwang@126.com>, <mingo@redhat.com>, Peter Zijlstra
	<peterz@infradead.org>, <juri.lelli@redhat.com>,
	<vincent.guittot@linaro.org>, <dietmar.eggemann@arm.com>,
	<rostedt@goodmis.org>, <bsegall@google.com>, <mgorman@suse.de>,
	<bristot@redhat.com>, <vschneid@redhat.com>, Mike Galbraith <efault@gmx.de>,
	<linux-kernel@vger.kernel.org>, <yangchen11@lixiang.com>, Jerry Zhou
	<zhouchunhua@lixiang.com>, Chunxin Zang <zangchunxin@lixiang.com>
Subject: Re: [PATCH v2] sched/fair: Reschedule the cfs_rq when current is
 ineligible
Message-ID: <ZmvDl80DQRvtOkoh@chenyu5-mobl2>
References: <20240529141806.16029-1-spring.cxz@gmail.com>
 <ZmKVjmuC4kGrUH5V@chenyu5-mobl2>
 <2E6EB0D6-D913-4205-B7DD-35EF4FA25667@gmail.com>
 <Zmrd2hwqHB8RQjqB@chenyu5-mobl2>
 <112FECA8-5D21-406F-814C-ACBE63351CBB@gmail.com>
 <ZmryuDqw2fEhHNni@chenyu5-mobl2>
 <9d83771f-3d12-25f0-c3f8-70dd7942e9ce@amd.com>
 <4c285c36-6893-c0c4-1061-0d7e16445e9d@amd.com>
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <4c285c36-6893-c0c4-1061-0d7e16445e9d@amd.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?gXGkeqUYDzCGURF7vLCU51ZW/U6hD+cralQSIGMsB69gVaQc/1aoWXl/ez?=
 =?iso-8859-1?Q?aJu/2NffKVUNBhreI5ShEONdQOgg8kPPVIiTa7Zrocik+PG6oKnf5W5d1A?=
 =?iso-8859-1?Q?lYMJVpKvfs0CW+bX7oGqW1BZ/CuBiDo7eicKcgxg2jnRSPlXtkP8YQS6+E?=
 =?iso-8859-1?Q?031BhJ8T/MmRv/T4uE/Hy2KrH4cTBueqEO+nLkFiV1k9AEdQo64QmCdIOS?=
 =?iso-8859-1?Q?gj7xuO5N2Wq5xUWmIO1J9bA0s5bWptXgU9ry240vNv7fnUYD5x/7zcx+LV?=
 =?iso-8859-1?Q?kIETNJN1kVHz0VRIovGXiITtYBE0uRDFQhkAjLjjHC1KabJFv7ZM5KcL50?=
 =?iso-8859-1?Q?iy6NZ5SMoUDzWeNs+0u9jb4nAeBU6uvreca5FogOm7tv48hWkPK0g/IisL?=
 =?iso-8859-1?Q?8dc5xCdB0ypXLWP48UpzcIUF9c3+5ySWoeVy6WnSAkaQgHLmhB8b8Ekt5w?=
 =?iso-8859-1?Q?oGU6FdBJQtw0h4r2TiS8kbB3kn4Ip5EC0dGl1ShA4z7JKvuuS6npLfc6zs?=
 =?iso-8859-1?Q?JF50j6pav6/+Dn4ef2oO8MRsrkMLI2VCfUconObzcrljIIfi6VYo2Ehrsm?=
 =?iso-8859-1?Q?HFjdyvRFVyZwbf4TBLtIvtZvHuqF7zKtw5izC+ze5kABqJ4fjKtG3mBPD6?=
 =?iso-8859-1?Q?U2UnT0MwxXHQzYz+kc0JspmC/JRKQ09L4xEkO/hoyhqpU28JRzpxFQ5Ksq?=
 =?iso-8859-1?Q?4n8RrmCVz264bvIq5YnUbm+keAH2RbdeTpw2buSXNZM4mwrplbinpYojoo?=
 =?iso-8859-1?Q?HJs8NsY0VCK02hj3dQpXeE05tIW//rWVjFbisahYIV67wNIfwaDNmFaAgQ?=
 =?iso-8859-1?Q?Rr5/VNwh7SF5DiC1JrOMQ7zza7eHnjD6ZMaTcC8iDMfssevx8n+zdS7xXj?=
 =?iso-8859-1?Q?kPxqjGizufzLLfFq/ph3cpqu89Zplx/NnqgDzUQo54+XpmlzX0ASS3B4E8?=
 =?iso-8859-1?Q?31ZgqKfFjp57gH9nBeEeL7pr8OoJz0ZHt43sZuLfjDwEiVbRV+GpuYZWrf?=
 =?iso-8859-1?Q?+I2fdhNv2JtK34VXjMAKVqFm8VW1oaDFQ592VBMtUC/PaBspm0SIq8F7Uw?=
 =?iso-8859-1?Q?8IXxxwOGwEcbyMIsN8kk/nQGFk0uWVKVhi1+JBFGd7dWp84EV/36LKgvuO?=
 =?iso-8859-1?Q?JlfXCoRcaKPoL0Y6h7JLZ0rmmLlK4rK9YtTF89xELdbXdAHhPmBPWwSKBd?=
 =?iso-8859-1?Q?6aZROfeV6YLgLOCQZ8t0h9ClHue02cGPDb27rVmLyJd6ePFJMMa/A+8g0V?=
 =?iso-8859-1?Q?nqwSOUxY8Z1fZ5e5+Fq3BRHH1mT899Na2YhfWl2WiVPV4V0fxHvUsY3uXy?=
 =?iso-8859-1?Q?IZH59YcStFIe/+PAClx6Q7Ocm6HPYjkVnHDY9mdKWfb2L/MnruJfQcSERo?=
 =?iso-8859-1?Q?10/gJcSPgmnJqMrrtyPi0s3yIjAHAuOE7qBgxWgSDc/8nUlxJMhqnxgrqW?=
 =?iso-8859-1?Q?9dep+/WxEr/JBjIHIuJcqO8MgwCxOIr2tzHrR9CRn8hPHORX4FzBUZu48x?=
 =?iso-8859-1?Q?ROV+donlGNepogJg8jlTmEqHDULk55puQxARbFAUFJd3PNV6vGE40J1cnC?=
 =?iso-8859-1?Q?5Z9zQLv7lK9w0T3gmGqquM2nJh6Xd8wMrD0N80OkHQ40pNTNtL9glTDyiG?=
 =?iso-8859-1?Q?uwcPpdVmf43HaMPJK9VgX5MNloYppwrxR/?=
X-MS-Exchange-CrossTenant-Network-Message-Id: da3000b2-5b93-4be7-4d79-08dc8c287cd7
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6020.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jun 2024 04:14:30.2096
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FpzJfV/6DnGJ7EvOJaXV6S/5Q7MxO/IwmBaJg9FBSrDY7i9YzVyMbT4Q6aaWl9sgr+RqPySvfvRo/Nm1d8CEmw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB6176
X-OriginatorOrg: intel.com

Hi Prateek,

On 2024-06-14 at 08:46:54 +0530, K Prateek Nayak wrote:
> Hello Chenyu,
> 
> > > +static bool check_curr_preempt(struct cfs_rq *cfs_rq, struct
> > > sched_entity *curr)
> > > +{
> > > +??? if (sched_feat(RUN_TO_PARITY) || cfs_rq->nr_running <= 1 ||
> > > +??????? !entity_eligible(cfs_rq, curr))
> > 
> > Shouldn't this return false if "entity_eligible(cfs_rq, curr)" returns
> > true since curr is still vruntime eligible on cfs_rq?
> > 
> > Would it better to have check_curr_preempt() as follows:
> > 
> >  ????if (sched_feat(RUN_TO_PARITY) || cfs_rq->nr_running <= 1)
> >  ??????? return false;
> > 
> >  ????return entity_eligible(cfs_rq, curr);
> 
> The above return should have been:
> 
> 	return !entity_eligible(cfs_rq, curr);
> 
> Which returns true once curr is not vruntime eligible on cfs_rq.
> Sorry for the oversight.
>

Yes, you are right, thanks for catching this.

thanks,
Chenyu