Received-SPF: pass (google.com: domain of linux-kernel+bounces-214338-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Fri, 14 Jun 2024 09:56:47 +0530
From: Raju Lakkaraju <Raju.Lakkaraju@microchip.com>
To: Horatiu Vultur <horatiu.vultur@microchip.com>
CC: Raju Lakkaraju <Raju.Lakkaraju@microchip.com>, <netdev@vger.kernel.org>,
	<davem@davemloft.net>, <kuba@kernel.org>, <linux-kernel@vger.kernel.org>,
	<bryan.whitehead@microchip.com>, <andrew@lunn.ch>, <linux@armlinux.org.uk>,
	<sbauer@blackbox.su>, <hmehrtens@maxlinear.com>, <lxu@maxlinear.com>,
	<hkallweit1@gmail.com>, <edumazet@google.com>, <pabeni@redhat.com>,
	<wojciech.drewek@intel.com>, <UNGLinuxDriver@microchip.com>, "kernel test
 robot" <lkp@intel.com>
Subject: Re: [PATCH net V4 2/3] net: lan743x: Support WOL at both the PHY and
 MAC appropriately
Message-ID: <ZmvGhwxFNYx1OV4c@HYD-DK-UNGSW21.microchip.com>
References: <20240612172539.28565-1-Raju.Lakkaraju@microchip.com>
 <20240612172539.28565-3-Raju.Lakkaraju@microchip.com>
 <20240613071532.tx376cehgvqjgyqx@DEN-DL-M31836.microchip.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
In-Reply-To: <20240613071532.tx376cehgvqjgyqx@DEN-DL-M31836.microchip.com>

Hi Horatiu,

The 06/13/2024 09:15, Horatiu Vultur wrote:
> The 06/12/2024 22:55, Raju Lakkaraju wrote:
> 
> Hi Raju,
> 
> > Prevent options not supported by the PHY from being requested to it by the MAC
> > Whenever a WOL option is supported by both, the PHY is given priority
> > since that usually leads to better power savings.
> > 
> > Fixes: e9e13b6adc338 ("lan743x: fix for potential NULL pointer dereference with bare card")
> 
> I am not sure if you run checkpatch.pl, but this gives you a warning.

I ran the checkpatch.pl on individual files and not on patches.

> The sha has too many chars.

Yes. instead of 12 chars, paste the 13 chars. I will fix this issue in next
version of patch series.

> 
> > Signed-off-by: Raju Lakkaraju <Raju.Lakkaraju@microchip.com>
> > Reviewed-by: Wojciech Drewek <wojciech.drewek@intel.com>
> > Reported-by: kernel test robot <lkp@intel.com>
> > Closes: https://lore.kernel.org/oe-kbuild-all/202406052200.w3zuc32H-lkp@intel.com/
> 
> I still don't think you should add the 'Reported-by' and 'Closes' tags
> here because you introduced the issue in first V3 of this patch series.
> Because the intel robot says: "If you fix the issue in a separate
> patch/commit (i.e. not just a new version of the same patch/commit),
> kindly add following tags".
> 

Ok. I will remove.
> -- 
> /Horatiu

-- 
Thanks,                                                                         
Raju