Received-SPF: pass (google.com: domain of linux-kernel+bounces-214348-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <58681eb0-cf36-4aa2-906e-a1a8daa2b969@linux.alibaba.com>
Date: Fri, 14 Jun 2024 13:03:27 +0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2] mm: shmem: fix getting incorrect lruvec when replacing
 a shmem folio
To: Matthew Wilcox <willy@infradead.org>
Cc: akpm@linux-foundation.org, hughd@google.com, mhocko@kernel.org,
 roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev,
 hannes@cmpxchg.org, nphamcs@gmail.com, yosryahmed@google.com,
 linux-mm@kvack.org, linux-kernel@vger.kernel.org
References: <5ab860d8ee987955e917748f9d6da525d3b52690.1718326003.git.baolin.wang@linux.alibaba.com>
 <Zmu3YVFfUA6_uToA@casper.infradead.org>
From: Baolin Wang <baolin.wang@linux.alibaba.com>
In-Reply-To: <Zmu3YVFfUA6_uToA@casper.infradead.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit


On 2024/6/14 11:22, Matthew Wilcox wrote:
> On Fri, Jun 14, 2024 at 08:49:13AM +0800, Baolin Wang wrote:
>>    * Charge @new as a replacement folio for @old. @old will
>> - * be uncharged upon free. This is only used by the page cache
>> - * (in replace_page_cache_folio()).
>> + * be uncharged upon free. This is used by the page cache
>> + * and shmem (in replace_page_cache_folio() and
>> + * shmem_replace_folio()).
> 
> Please just delete this sentence.  Functions do not keep track of who
> their callers are.

Sure. This sentence seems less helpful. Will do in v3.