Received: by 2002:a89:413:0:b0:1fd:dba5:e537 with SMTP id m19csp598733lqs; Thu, 13 Jun 2024 22:45:48 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUAQgcEHXO0I2yPASWhoYaMUhrlo1WWsZtdUa7RQGufo5DXKEWSWgVVpxpqUemuCYa/oapiGZDEdsBmGnAca3nb6gAFKDKjfmu+wrUdqA== X-Google-Smtp-Source: AGHT+IHWLngAGsNhM5viOqhjxicPyvd9zftFUyd8zBjxJbp7IlhRyBw97bOGMPcbCExbLkDbYa9C X-Received: by 2002:a17:90a:df91:b0:2c2:c96c:5390 with SMTP id 98e67ed59e1d1-2c4db13505cmr1935193a91.1.1718343947939; Thu, 13 Jun 2024 22:45:47 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1718343947; cv=pass; d=google.com; s=arc-20160816; b=AY0GLkoc/GBLoVyGYH3xUNfZB94mRX5LCaAmkFvox6gWuyLAhn9v5KgLNW7nlzQxRk Fhqxiqo/1WIAqRa+M5CrwBKjES1s5IhA/USmL9CxDrUmhAhqsoIAv9JjlN2vQUcHxvHB i1XmCsFMijepRw5Fd5r/UA3K4AHXYwFFRuE29zTtQTFx1MblVL/AiFJEEGqN+jxvr23b sN/pImTVmRcLnEyukIBsmlFtIOGJ85ZugbNPclplYT9un8WmFOx7+QdqebBbZ1eI/UuE qH8HONUj1sssTpCvTS3gc3Xvzj8GcxDVgnktSSpXeimYcfkbVzFtHvJpHveXuIBhVpAr iA3g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:references :message-id:subject:cc:to:from:date; bh=6o1eZepDhm9E7Wauk1FQ+44IVCpgwBbLrxaxIKggJwg=; fh=CI17YZbl6fdKWK7YP0nfF/tYz5LYLimH0FyX0LkBp3k=; b=guWC4SuLg971YmuUOyILsAlijWYnW/2bKNZ2uisYWtN3TVAaYOVwzOI2jdA7my37EL vKSWt7UoRsaZdiFgYXFHXKRL9b/mScrvCVEWlteb5HwbNuU55D6uzr3C+jcKW5G7DEwQ egEIUzRJuYDAbZuQMSx7+N7f9DO9exJFBttMswEhBsHlC3E2cJ+k5YWyJ/b/lY+kpIca WSPopgDsuSnPANVKlexly0nIF6krhT28CoC4wLNlfRl4VuFcJGi0JtoSXhTn6serp8a2 WR5iZCMA96kl3kH9uu9VtttNfqklWyUkdl76TeCYWIKYv3opbjReB8hlCiTg4E2LAxOv MapQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=lst.de); spf=pass (google.com: domain of linux-kernel+bounces-214373-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-214373-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id 98e67ed59e1d1-2c4c461efbesi2907392a91.50.2024.06.13.22.45.47 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Jun 2024 22:45:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-214373-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=lst.de); spf=pass (google.com: domain of linux-kernel+bounces-214373-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-214373-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 6CAB6283DAA for ; Fri, 14 Jun 2024 05:45:47 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A43D71474C5; Fri, 14 Jun 2024 05:45:41 +0000 (UTC) Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C61A913213E; Fri, 14 Jun 2024 05:45:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718343941; cv=none; b=Nsw2HoYdpvZ2vYfgOOMXjMF3NDiuhbGtwBGxRXIV4ldKS47tH6jrs2oHfonEizVOKNLT4UEgVSfeL7n9qr13ZdJT+sP7MMFLmfRu37xXalNrrxwzEBj6QmuQ4LfpkdStdCZCMwwha6Dhbd6MiLhMf6ryWcA3cmSrq27SKmp+lFc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718343941; c=relaxed/simple; bh=6o1eZepDhm9E7Wauk1FQ+44IVCpgwBbLrxaxIKggJwg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=YNDRIxIIPU0FxxDA24o9LARmX7p6dd4HZCDgiz+ehmyAlbFt/iJBfwV4tSCGwUaE8o73Jk4u+/HDjKFgilMsHsM2ov4Kz67TGqbDszqivhzSIWj6dBu/Z65sR7Bf8PDsqfbpS688+0mpIRagPcUTlmU+uy/8Pgcvm1Q/7u8+6lk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de Received: by verein.lst.de (Postfix, from userid 2407) id D008868CFE; Fri, 14 Jun 2024 07:45:34 +0200 (CEST) Date: Fri, 14 Jun 2024 07:45:34 +0200 From: "hch@lst.de" To: Gulam Mohamed Cc: kernel test robot , "oe-lkp@lists.linux.dev" , "lkp@intel.com" , "linux-block@vger.kernel.org" , "ltp@lists.linux.it" , "linux-kernel@vger.kernel.org" , "yukuai1@huaweicloud.com" , "hch@lst.de" , "axboe@kernel.dk" Subject: Re: [PATCH V4 for-6.10/block] loop: Fix a race between loop detach and loop open Message-ID: <20240614054534.GA9969@lst.de> References: <20240607190607.17705-1-gulam.mohamed@oracle.com> <202406112130.a572f72-oliver.sang@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) On Thu, Jun 13, 2024 at 09:10:37PM +0000, Gulam Mohamed wrote: > I looked at the LTP test case failure and also the function tst_detach_device_by_fd() which failed. Our kernel patch will defer all the attempts to detach a loop device to the last close, to fix an issue. > The tst_detach_device_by_fd() in LTP test case will open the loop device and repeatedly checks for error code ENXIO. As the new approach, as I mentioned above, will defer the detach to last close and the last close happens *only* when the LTP test function tst_detach_device_by_fd() returns, the test will obviously fail. So, Can you please modify the LTP test case to accommodate the new behaviour of kernel code for loop detach? > Please let us know your comments. I still think simply setting the rundown state is the better approach..