Received-SPF: pass (google.com: domain of linux-kernel+bounces-214393-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: Avri Altman <Avri.Altman@wdc.com>
To: Joel Slebodnick <jslebodn@redhat.com>, "linux-scsi@vger.kernel.org"
	<linux-scsi@vger.kernel.org>
CC: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"alim.akhtar@samsung.com" <alim.akhtar@samsung.com>, "bvanassche@acm.org"
	<bvanassche@acm.org>, "James.Bottomley@HansenPartnership.com"
	<James.Bottomley@HansenPartnership.com>, "martin.petersen@oracle.com"
	<martin.petersen@oracle.com>, "peter.wang@mediatek.com"
	<peter.wang@mediatek.com>, "manivannan.sadhasivam@linaro.org"
	<manivannan.sadhasivam@linaro.org>, "ahalaney@redhat.com"
	<ahalaney@redhat.com>, "beanhuo@micron.com" <beanhuo@micron.com>,
	"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: RE: [PATCH] scsi: ufs: core: Free memory allocated for model before
 reinit
Thread-Topic: [PATCH] scsi: ufs: core: Free memory allocated for model before
 reinit
Thread-Index: AQHavb95/lPaUQt0S0akgSoqvJltDLHGHZ0AgACuniA=
Date: Fri, 14 Jun 2024 06:27:44 +0000
Message-ID:
 <DM6PR04MB65754C0FF7EA562C33BCB0FBFCC22@DM6PR04MB6575.namprd04.prod.outlook.com>
References: <20240613182728.2521951-1-jslebodn@redhat.com>
 <20240613200202.2524194-1-jslebodn@redhat.com>
In-Reply-To: <20240613200202.2524194-1-jslebodn@redhat.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?mILFjHIB9XqhDW3SdsxRzBaXyZWy4b+dOH7fvYR5pgMH4ya6lU8XvhKosiR/?=
 =?us-ascii?Q?xqHkj2nN6pHjT76Ig4chqG+K/eS8TtjXJ5yEXIzdSg2eW+JEcLWMqtePlb9C?=
 =?us-ascii?Q?Tf8s3EkR3+4VTM2xzBV9abJiKUP4IpwQ/PGfMpa0InJetgo8Xf/8Xb66gl2F?=
 =?us-ascii?Q?n8LnMfmhFj2gZyReXS9tccCxCDrbQMXUqGtbRxWtK67E1+73nqyjFsGjVhS5?=
 =?us-ascii?Q?iN+Qbc7c8uKNVydFZYeaXra6Zgd+B9yo8zaBwnpPoKVJGfurIkdg51vyNb2v?=
 =?us-ascii?Q?XbFGtfzynK+tDFEFZo0C6BFNz7ppVi+B/J7xvX4R3QLdGINmTpRlqOCcqhep?=
 =?us-ascii?Q?kKjJyj0w5qK+FetgtaC2Dq+qMh65ZFU8u32UpEs598nRePMBLMdrd5bPLAGR?=
 =?us-ascii?Q?FZRgtWDIbFuw1NWZ6zTsM8tGHb/+BQ1C21/0nZFz8ChqhDCX/CLti1crJ2Ij?=
 =?us-ascii?Q?CKPH46DQAzUhb0wJjORAWJg9r2Hy8epvdqJAirU1mF6m+PqG8nOIss225dPW?=
 =?us-ascii?Q?fI93zjjj9d62GMzsW39SKuT5ZJK4tmePvWNIQL/ACRIgvy/0cSt0zGs4Txub?=
 =?us-ascii?Q?lsNoU9eb+Gf381zSfo9sTBr49DnZzeDzDdMPl//o5txHbFPcMCefj7W5XRhM?=
 =?us-ascii?Q?0fGomoCvK/UzsURrT6c9lZtllxuzb6pYUq7DwKnINPdoXXQJFYv760ZASP8h?=
 =?us-ascii?Q?mzuXZ90OhEgL0SJdDi6vDnXXYe6Jq2Udf7yj8t2fzywA6YDOix1Q3KMTIfOP?=
 =?us-ascii?Q?GlAUf/lafYsnGAVcKS0bM0NBJG00PXcXH93qqhrzTWIh9SZ3k30UijqTDYsV?=
 =?us-ascii?Q?8h/syh4ZHYIDA4oJNomiZ/yYTjVws8LboBzdvm/dmF0X5JdSLhgxpn/sy+lc?=
 =?us-ascii?Q?K5NvaoCqRR4OwyLot28B1OIIm3jswd1gq8a/bKl3hDOS7TpmBkcn1ktJRY+s?=
 =?us-ascii?Q?8Qk3THfu+sEXPwqH1vrADb02CATiu4SyBsKFuyHjZPc1B5QtrnI23KkhFdqB?=
 =?us-ascii?Q?nB5rtIBG57/VmfDWt98wfGyYZE4SPdnyKuIDy5QiihrNupKorilTtpYh5nli?=
 =?us-ascii?Q?liabVmD+gFrlJ9WU/mNepyqg5Zb0r4AAvXA86D5eDWuQ3DvyDabUVmE4IWBC?=
 =?us-ascii?Q?SK40HOZZtXcpNNgxUa7+bQqAptfvHJ9TszJyy0VPIVKqSzrTNUmg1WzMikNW?=
 =?us-ascii?Q?XPDM1IpxmLIIKEC7PNMafgh3tL8t2S3oxDQSCLrXYrmimfr4iiNF7t07Dwbh?=
 =?us-ascii?Q?M9JRAcfERcBQRzzJHNE+33ScBO8wNUp6V5EMiMiR7rCUPhlQsEALLBMOou+H?=
 =?us-ascii?Q?IhbFjCRXqmE1vh9KzIeByQxHu/i0onRAcZ3pV5zFEWIw4BjwzjrXhOf/c1ad?=
 =?us-ascii?Q?+JWugX+4JTHyynKYi9R0oCwUJSqWl57/oXUDPDVvCyevPEpmPgLoFXoQLaob?=
 =?us-ascii?Q?s5FsOdQxE2ge+ZMZtMAfUFiOsnpHVJEtosHXiBsUgxchmZ+hF7haDBUOZ+mb?=
 =?us-ascii?Q?llQ39oMZc3uqzcOJF4Oq1sDEW/AmlK3eyv47AE3q0UK91P/+7hwLZ88KWKik?=
 =?us-ascii?Q?QuT0wjs3rPOEQjS1VSbAAv6GNTG5AQrY+rWopVtqohCpOymw141T1UxJKnw8?=
 =?us-ascii?Q?rFpkDtoupHX5Je3s01czEV5JrqIBh8I+hci1t5iw+J4e?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0:
	Qu2pwIqNo6KuZ99d37sGo5cQ3Da88M9YRKzpYUDZy2BDJTdz4LiWC9UyFh7sTA4YtiLfb9YV6ZPmrr/L/RFZzFdho4xOu2PdOqPcXXuwVxrHgcBuUe4iE6M4cSNwBNHK9VUwddkaq+aqSz7SB6A2yaoy0UE+ySVJdYjfHglqthUt7w7IWeF035AgbYfgzjWrIDcMLl7gifu92yAcb+lvieoSKAlihkBSbgh+HvKWAXr7nB3pedtAkhIMPEoVVZBWwcEy9ibPlAP0V4KD3ZUO+ZGhTdM0mkBJfkz6s+ZIR9xouRD6hZpKo2qv2WwQncNNIThN/gCYO+ERzDSg47wSM0M3I/sK5uj7rmXi1og/nQmUdQCV5b8pAFZ/d4BS8rdHCJp8f0uPW1suJ4eE1td4KNmAzIQ8XoRpk3w0unlocp3lHIUShqvY8IYa6WgtowJIpTr4eQ2OJ5S1MB7e0fAt40Ryl3ve+IHayfZbJKh9ThWukro5tKOhaCtPUK7IfEW4Fo1wA0HxUJkBxxqBNs5JOPyyeZoNHBRINNILvBEzKWIlGc6EPR9dNJ414dgX0ixmSqnzKkxYdq3VBIdTu6IK2lOQuH1QaIH+TnefMypi4EQr3rABSXHI86SEIPjwsEr2
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR04MB6575.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f36293e4-869f-4a32-834e-08dc8c3b1a0e
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Jun 2024 06:27:44.7267
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: lTi48hEFUuajPq0+e31f/yXfErI5/qJ+2s9ia6oISipmRli3dZpX1jaWwsOuqgVwSoctPMN2/phy1Jl3hWJRlA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR04MB7795

> Under the conditions that a device is to be reinitialized within ufshcd_p=
robe_hba,
> the device must first be fully reset.
>=20
> Resetting the device should include freeing U8 model (member of
> dev_info)  but does not, and this causes a memory leak.
> ufs_put_device_desc is responsible for freeing model.
>=20
> unreferenced object 0xffff3f63008bee60 (size 32):
>   comm "kworker/u33:1", pid 60, jiffies 4294892642
>   hex dump (first 32 bytes):
>     54 48 47 4a 46 47 54 30 54 32 35 42 41 5a 5a 41  THGJFGT0T25BAZZA
>     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
>   backtrace (crc ed7ff1a9):
>     [<ffffb86705f1243c>] kmemleak_alloc+0x34/0x40
>     [<ffffb8670511cee4>] __kmalloc_noprof+0x1e4/0x2fc
>     [<ffffb86705c247fc>] ufshcd_read_string_desc+0x94/0x190
>     [<ffffb86705c26854>] ufshcd_device_init+0x480/0xdf8
>     [<ffffb86705c27b68>] ufshcd_probe_hba+0x3c/0x404
>     [<ffffb86705c29264>] ufshcd_async_scan+0x40/0x370
>     [<ffffb86704f43e9c>] async_run_entry_fn+0x34/0xe0
>     [<ffffb86704f34638>] process_one_work+0x154/0x298
>     [<ffffb86704f34a74>] worker_thread+0x2f8/0x408
>     [<ffffb86704f3cfa4>] kthread+0x114/0x118
>     [<ffffb86704e955a0>] ret_from_fork+0x10/0x20
>=20
> Fixes: 96a7141da332 ("scsi: ufs: core: Add support for reinitializing the=
 UFS
> device")
> Cc: <stable@vger.kernel.org>
>=20
> Reviewed-by: Andrew Halaney <ahalaney@redhat.com>
> Reviewed-by: Bart Van Assche <bvanassche@acm.org>
> Signed-off-by: Joel Slebodnick <jslebodn@redhat.com>
Reviewed-by: Avri Altman <avri.altman@wdc.com>


> ---
>  drivers/ufs/core/ufshcd.c | 1 +
>  1 file changed, 1 insertion(+)
>=20
> diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c index
> 0cf07194bbe8..a0407b9213ca 100644
> --- a/drivers/ufs/core/ufshcd.c
> +++ b/drivers/ufs/core/ufshcd.c
> @@ -8787,6 +8787,7 @@ static int ufshcd_probe_hba(struct ufs_hba *hba, bo=
ol
> init_dev_params)
>             (hba->quirks & UFSHCD_QUIRK_REINIT_AFTER_MAX_GEAR_SWITCH)) {
>                 /* Reset the device and controller before doing reinit */
>                 ufshcd_device_reset(hba);
> +               ufs_put_device_desc(hba);
>                 ufshcd_hba_stop(hba);
>                 ufshcd_vops_reinit_notify(hba);
>                 ret =3D ufshcd_hba_enable(hba);
> --
> 2.40.1