Received-SPF: pass (google.com: domain of linux-kernel+bounces-214397-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <6b45e79b-84a6-4935-adce-cc8b0d0dd7ea@ibv-augsburg.net>
Date: Fri, 14 Jun 2024 08:12:50 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 00/13] OMAP mailbox FIFO removal
To: Andrew Davis <afd@ti.com>, Jassi Brar <jassisinghbrar@gmail.com>,
 Hari Nagalla <hnagalla@ti.com>, Nick Saulnier <nsaulnier@ti.com>,
 Bjorn Andersson <andersson@kernel.org>,
 Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20240410135942.61667-1-afd@ti.com>
 <b5c8d134-edcb-4a1a-8940-b26047c9b79d@ibv-augsburg.net>
 <4d7c1525-a3d1-48f3-9e9c-eb61527a1b23@ti.com>
From: Dominic Rath <dominic.rath@ibv-augsburg.net>
In-Reply-To: <4d7c1525-a3d1-48f3-9e9c-eb61527a1b23@ti.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 13.06.2024 14:22, Andrew Davis wrote:
>> We looked into this some time ago, and noticed that the IRQ approach 
>> caused problems in the virtio/rpmsg code. I'd like to understand if 
>> your change was for the same reason, or something else we missed before.
>>
> 
> It is most likely the same reason. Seems despite its name, 
> rproc_vq_interrupt() cannot
> be called from an IRQ/atomic context. As the following backtrace shows, 
> that function
> calls down into functions which are not IRQ safe. So we needed to keep 
> it threaded:

Thanks for confirming. This is exactly what we've been seeing.

Regards,

Dominic