Received-SPF: pass (google.com: domain of linux-kernel+bounces-214413-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Precedence: bulk
MIME-Version: 1.0
References: <000000000000871190061acd8fed@google.com> <20240614010522.2261016-1-lizhi.xu@windriver.com>
In-Reply-To: <20240614010522.2261016-1-lizhi.xu@windriver.com>
From: Miklos Szeredi <miklos@szeredi.hu>
Date: Fri, 14 Jun 2024 08:53:57 +0200
Message-ID: <CAJfpegtiqWwr93_rtXU3YyJLmtHOtP8TAKQN0FLKVN5Yaz1EZw@mail.gmail.com>
Subject: Re: [PATCH] ovl: avoid deadlock in ovl_create_tmpfile
To: Lizhi Xu <lizhi.xu@windriver.com>
Cc: syzbot+b778ac10fe2a0cd72517@syzkaller.appspotmail.com, amir73il@gmail.com, 
	linux-kernel@vger.kernel.org, linux-unionfs@vger.kernel.org, 
	syzkaller-bugs@googlegroups.com
Content-Type: text/plain; charset="UTF-8"

On Fri, 14 Jun 2024 at 03:05, Lizhi Xu <lizhi.xu@windriver.com> wrote:
>
> ovl_copy_up() will retrieve sb_writers, and ovl_want_write will also retrieve
> sb_writers, adjusting the order of their execution to avoid deadlocks.
>
> Reported-by: syzbot+b778ac10fe2a0cd72517@syzkaller.appspotmail.com
> Signed-off-by: Lizhi Xu <lizhi.xu@windriver.com>

Thank you.

This is already fixed in:

git://git.kernel.org/pub/scm/linux/kernel/git/overlayfs/vfs.git #overlayfs-next

Will send a pull request to Linus in the following weeks.

Thanks,
Miklos