Received-SPF: pass (google.com: domain of linux-kernel+bounces-214410-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Fri, 14 Jun 2024 08:51:30 +0200
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Teddy Engel <engel.teddy@gmail.com>
Cc: Dan Carpenter <dan.carpenter@linaro.org>,
	Philipp Hortmann <philipp.g.hortmann@gmail.com>,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/6] staging: rtl8192e: Cleanup multiple issues
Message-ID: <2024061403-obedient-decoy-d3eb@gregkh>
References: <cover.1718291024.git.engel.teddy@gmail.com>
 <ee01dbd2-fe83-46cf-9ceb-279a06ce9aad@gmail.com>
 <c0f2bca8-a7e6-4874-b5fc-98911a7c09d8@moroto.mountain>
 <CACP1t+uF6R6zDNDsL-ZZOnvWM-t2w097P0tMpxuSsj7=AXvJGA@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CACP1t+uF6R6zDNDsL-ZZOnvWM-t2w097P0tMpxuSsj7=AXvJGA@mail.gmail.com>

On Thu, Jun 13, 2024 at 08:34:37PM +0100, Teddy Engel wrote:
> On Thu, 13 Jun 2024 at 20:22, Dan Carpenter <dan.carpenter@linaro.org>
> wrote:
> 
> > On Thu, Jun 13, 2024 at 09:05:03PM +0200, Philipp Hortmann wrote:
> > > On 6/13/24 17:16, Teddy Engel wrote:
> > > > Remove some unused constants, macros, and structs.
> > > > Capitalize a constant.
> > > >
> > > > No specific patch order required.
> > > >
> > > > Teddy Engel (6):
> > > >    staging: rtl8192e: Remove unused constant IC_VersionCut_E
> > > >    staging: rtl8192e: Remove unused struct phy_ofdm_rx_status_rxsc
> > > >    staging: rtl8192e: Remove unused constant WA_IOT_TH_VAL
> > > >    staging: rtl8192e: Capitalize constant RegC38_TH
> > > >    staging: rtl8192e: Remove unused macro dm_tx_bb_gain_idx_to_amplify
> > > >    staging: rtl8192e: Remove unnecessary pre-declaration of struct
> > > >      net_device
> > > >
> > > >   drivers/staging/rtl8192e/rtl8192e/r8190P_def.h | 8 --------
> > > >   drivers/staging/rtl8192e/rtl8192e/rtl_cam.h    | 1 -
> > > >   drivers/staging/rtl8192e/rtl8192e/rtl_dm.c     | 4 ++--
> > > >   drivers/staging/rtl8192e/rtl8192e/rtl_dm.h     | 6 +-----
> > > >   drivers/staging/rtl8192e/rtl8192e/rtl_pci.h    | 1 -
> > > >   5 files changed, 3 insertions(+), 17 deletions(-)
> > > >
> > >
> > >
> > > Hi Teddy,
> > >
> > > please combine patch 1 and 3 (Remove unused constant ...) . You can
> > change
> > > more than one item in a patch. But it has to be of the same kind.
> > >
> >
> > Could you combine that with the earlier patch that deleted
> > IC_VersionCut_C as well?  (Unless that has already been merged).
> >
> > regards,
> > dan carpenter
> >
> > Hey Dan,
> 
> I registered to the mailing list (very) recently so unfortunately I don't
> have that change showing in my mail history...

lore.kernel.org has the history of the list since it was started, no
need to be subscribed to see everything that has happened :)

thanks

greg k-h