Received-SPF: pass (google.com: domain of linux-kernel+bounces-214475-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <a15da17a-f196-4356-a744-5c8e1104e7c0@siemens.com>
Date: Fri, 14 Jun 2024 09:44:34 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 2/2] arm64: dts: ti: k3-am65: Move SerDes mux nodes under
 the control node
To: Andrew Davis <afd@ti.com>, Nishanth Menon <nm@ti.com>,
 Vignesh Raghavendra <vigneshr@ti.com>, Tero Kristo <kristo@kernel.org>,
 Rob Herring <robh+dt@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
 Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
 linux-kernel@vger.kernel.org
References: <20240326185627.29852-1-afd@ti.com>
 <20240326185627.29852-2-afd@ti.com>
From: Jan Kiszka <jan.kiszka@siemens.com>
Content-Language: en-US
Autocrypt: addr=jan.kiszka@siemens.com; keydata=
 xsFNBGZY+hkBEACkdtFD81AUVtTVX+UEiUFs7ZQPQsdFpzVmr6R3D059f+lzr4Mlg6KKAcNZ
 uNUqthIkgLGWzKugodvkcCK8Wbyw+1vxcl4Lw56WezLsOTfu7oi7Z0vp1XkrLcM0tofTbClW
 xMA964mgUlBT2m/J/ybZd945D0wU57k/smGzDAxkpJgHBrYE/iJWcu46jkGZaLjK4xcMoBWB
 I6hW9Njxx3Ek0fpLO3876bszc8KjcHOulKreK+ezyJ01Hvbx85s68XWN6N2ulLGtk7E/sXlb
 79hylHy5QuU9mZdsRjjRGJb0H9Buzfuz0XrcwOTMJq7e7fbN0QakjivAXsmXim+s5dlKlZjr
 L3ILWte4ah7cGgqc06nFb5jOhnGnZwnKJlpuod3pc/BFaFGtVHvyoRgxJ9tmDZnjzMfu8YrA
 +MVv6muwbHnEAeh/f8e9O+oeouqTBzgcaWTq81IyS56/UD6U5GHet9Pz1MB15nnzVcyZXIoC
 roIhgCUkcl+5m2Z9G56bkiUcFq0IcACzjcRPWvwA09ZbRHXAK/ao/+vPAIMnU6OTx3ejsbHn
 oh6VpHD3tucIt+xA4/l3LlkZMt5FZjFdkZUuAVU6kBAwElNBCYcrrLYZBRkSGPGDGYZmXAW/
 VkNUVTJkRg6MGIeqZmpeoaV2xaIGHBSTDX8+b0c0hT/Bgzjv8QARAQABzSNKYW4gS2lzemth
 IDxqYW4ua2lzemthQHNpZW1lbnMuY29tPsLBlAQTAQoAPhYhBABMZH11cs99cr20+2mdhQqf
 QXvYBQJmWPvXAhsDBQkFo5qABQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEGmdhQqfQXvY
 zPAP/jGiVJ2VgPcRWt2P8FbByfrJJAPCsos+SZpncRi7tl9yTEpS+t57h7myEKPdB3L+kxzg
 K3dt1UhYp4FeIHA3jpJYaFvD7kNZJZ1cU55QXrJI3xu/xfB6VhCs+VAUlt7XhOsOmTQqCpH7
 pRcZ5juxZCOxXG2fTQTQo0gfF5+PQwQYUp0NdTbVox5PTx5RK3KfPqmAJsBKdwEaIkuY9FbM
 9lGg8XBNzD2R/13cCd4hRrZDtyegrtocpBAruVqOZhsMb/h7Wd0TGoJ/zJr3w3WnDM08c+RA
 5LHMbiA29MXq1KxlnsYDfWB8ts3HIJ3ROBvagA20mbOm26ddeFjLdGcBTrzbHbzCReEtN++s
 gZneKsYiueFDTxXjUOJgp8JDdVPM+++axSMo2js8TwVefTfCYt0oWMEqlQqSqgQwIuzpRO6I
 ik7HAFq8fssy2cY8Imofbj77uKz0BNZC/1nGG1OI9cU2jHrqsn1i95KaS6fPu4EN6XP/Gi/O
 0DxND+HEyzVqhUJkvXUhTsOzgzWAvW9BlkKRiVizKM6PLsVm/XmeapGs4ir/U8OzKI+SM3R8
 VMW8eovWgXNUQ9F2vS1dHO8eRn2UqDKBZSo+qCRWLRtsqNzmU4N0zuGqZSaDCvkMwF6kIRkD
 ZkDjjYQtoftPGchLBTUzeUa2gfOr1T4xSQUHhPL8zsFNBGZY+hkBEADb5quW4M0eaWPIjqY6
 aC/vHCmpELmS/HMa5zlA0dWlxCPEjkchN8W4PB+NMOXFEJuKLLFs6+s5/KlNok/kGKg4fITf
 Vcd+BQd/YRks3qFifckU+kxoXpTc2bksTtLuiPkcyFmjBph/BGms35mvOA0OaEO6fQbauiHa
 QnYrgUQM+YD4uFoQOLnWTPmBjccoPuiJDafzLxwj4r+JH4fA/4zzDa5OFbfVq3ieYGqiBrtj
 tBFv5epVvGK1zoQ+Rc+h5+dCWPwC2i3cXTUVf0woepF8mUXFcNhY+Eh8vvh1lxfD35z2CJeY
 txMcA44Lp06kArpWDjGJddd+OTmUkFWeYtAdaCpj/GItuJcQZkaaTeiHqPPrbvXM361rtvaw
 XFUzUlvoW1Sb7/SeE/BtWoxkeZOgsqouXPTjlFLapvLu5g9MPNimjkYqukASq/+e8MMKP+EE
 v3BAFVFGvNE3UlNRh+ppBqBUZiqkzg4q2hfeTjnivgChzXlvfTx9M6BJmuDnYAho4BA6vRh4
 Dr7LYTLIwGjguIuuQcP2ENN+l32nidy154zCEp5/Rv4K8SYdVegrQ7rWiULgDz9VQWo2zAjo
 TgFKg3AE3ujDy4V2VndtkMRYpwwuilCDQ+Bpb5ixfbFyZ4oVGs6F3jhtWN5Uu43FhHSCqUv8
 FCzl44AyGulVYU7hTQARAQABwsF8BBgBCgAmFiEEAExkfXVyz31yvbT7aZ2FCp9Be9gFAmZY
 +hkCGwwFCQWjmoAACgkQaZ2FCp9Be9hN3g/8CdNqlOfBZGCFNZ8Kf4tpRpeN3TGmekGRpohU
 bBMvHYiWW8SvmCgEuBokS+Lx3pyPJQCYZDXLCq47gsLdnhVcQ2ZKNCrr9yhrj6kHxe1Sqv1S
 MhxD8dBqW6CFe/mbiK9wEMDIqys7L0Xy/lgCFxZswlBW3eU2Zacdo0fDzLiJm9I0C9iPZzkJ
 gITjoqsiIi/5c3eCY2s2OENL9VPXiH1GPQfHZ23ouiMf+ojVZ7kycLjz+nFr5A14w/B7uHjz
 uL6tnA+AtGCredDne66LSK3HD0vC7569sZ/j8kGKjlUtC+zm0j03iPI6gi8YeCn9b4F8sLpB
 lBdlqo9BB+uqoM6F8zMfIfDsqjB0r/q7WeJaI8NKfFwNOGPuo93N+WUyBi2yYCXMOgBUifm0
 T6Hbf3SHQpbA56wcKPWJqAC2iFaxNDowcJij9LtEqOlToCMtDBekDwchRvqrWN1mDXLg+av8
 qH4kDzsqKX8zzTzfAWFxrkXA/kFpR3JsMzNmvextkN2kOLCCHkym0zz5Y3vxaYtbXG2wTrqJ
 8WpkWIE8STUhQa9AkezgucXN7r6uSrzW8IQXxBInZwFIyBgM0f/fzyNqzThFT15QMrYUqhhW
 ZffO4PeNJOUYfXdH13A6rbU0y6xE7Okuoa01EqNi9yqyLA8gPgg/DhOpGtK8KokCsdYsTbk=
In-Reply-To: <20240326185627.29852-2-afd@ti.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?NE5tYlJybG9FeW1nbVN1Y3NIb3pyMkl3NG5WeWFWZWRTbE95dy9uNGxXZSsx?=
 =?utf-8?B?WHlpWlhwczBwOEQrMlIxcDlFTVZQZFpXTVAxeHczc2JZOVArbm5MblRGNmVp?=
 =?utf-8?B?eEhabzZKT3BTb0lmRWF6K0ovNU41dzhiNHdoWFRBSDJmUW00eDdFZ1NNUDJj?=
 =?utf-8?B?N3d4UlNvYzViZC9zK2F6WVE5TWdTLzV1czU5R2hZUlVacVE3bEFIbHFFVnND?=
 =?utf-8?B?N01RSkJrSjRRUWNZdFFlWDB4ZVJtSXVkSVEvM04vaytaelNYaVc0NERycEd1?=
 =?utf-8?B?dFk1MXBSeGI3NlFlSGJBQ2FKdkEzZU40ZXdhaVpNZnNhM3ZDTDVBamRXUDB2?=
 =?utf-8?B?MS9hNm52Uk5iKzlmbDIvYW5TVDlHbWc3ZDgwQTYvOEZGNlZIakgyeW84MHNa?=
 =?utf-8?B?QjcvTnlFWHFaY2Y2SUdoQml4UzE1RmZSc0V1bzZjcTNlOVdhVTFuTWJsdWp1?=
 =?utf-8?B?VnpkV0E5VjZ6c2pON3ZvQTZyVzVOSlpWMDBPTDNPOE8ycFFrTTI4UnM4YXZk?=
 =?utf-8?B?Vk9WZDFQUDFpQ0hpYk1ndk9keEtjeDJ3VzYrRVozWllta2pUNkRRV2dXckpo?=
 =?utf-8?B?T0o1Wm9IaDY5Mi9YR0F1dXhLYXAyZUlHdmxvT08vc0VWdGFSTnUvT0N0VHk0?=
 =?utf-8?B?bmozNXYyeTgvcDFCM293MzhuOXFkekp3aStzMU5sK0NlUkROR2REM0tWZ21u?=
 =?utf-8?B?V1pYRnhFejRtYUhUUnorR0hzZ0xVakNkRFdDRU4wclU0U0lWRURLUGZmNXJX?=
 =?utf-8?B?aW1DNURIS1VURTRnNWFGQk1IVlF5MFNNUWVvU241MXdXWDlQZ1R6NVJHZHBF?=
 =?utf-8?B?WHRUcHVoRXZweUd2QXZncnd2QlhaV3QwcWNNZXdSY3ZqbXJ0WVMyQm9aUk1I?=
 =?utf-8?B?bzJyRktSSHh0TU1lcEhhOTBXanEySnlBaW9lQjJMaFhLVmJwdlZkK0lqWWVL?=
 =?utf-8?B?QzI5cURqVm1peEdQTFJPMDNCVGg3NWJxWDJlU0NpZngzNE1ERVBHR3NpM3Yr?=
 =?utf-8?B?VUZ4L2FVdGRIUTk1cWpNZDlsOUt5OFdEVFVjdXpsZ3dTSVpLLzBhbHdpZnZ0?=
 =?utf-8?B?YnlUVk5iKzdHVmZZaWtzNTNYQTBmQ253WHVtcVlVd0RJT2djMkN0cDdtYUU4?=
 =?utf-8?B?YW8rZGpqdEkzNGNUNURyUDR1aUxLZ2IvaVoweVA3UytjZ3M2RkhJcTFhTFhC?=
 =?utf-8?B?UmZKTjRWS2Q0TUpUazllaUxEbDY1TkdVd1J4S21JQ3NETHdlNnV0ZzlZZ2cx?=
 =?utf-8?B?UTAxYkFEZHAzVjBBYy9US2pORGFpUnd3Rzg3dmRwT3ZNbzUvc29YT2JQU1Aw?=
 =?utf-8?B?T040R3RYN1RFTXBuU2cwZmpaU3UwQW1Qek5Lc0JicjFRYmkwMkZIRVRoR1lI?=
 =?utf-8?B?ei9XYWN6RVFoRHRJZWZUSW15RURBRUpzT1lueFVkNk9zdXhUUFdPVW1veThH?=
 =?utf-8?B?SFBWUWhMbHd4d2dkcXlla1BCUzc1SUc5MVoreUx2cVFiSWhJb0s0Um9DQ2Ir?=
 =?utf-8?B?Y2NIcGwwTDV4ckV1S1UrSjVzUVpHZi9GdkZWcU9pQm9aOXpWR1VwY0dvNlJN?=
 =?utf-8?B?b256V1llTzd4SEszMkdYd0ZMajFIODBWaUdIdW0vaUJUMngxUFBySXIyWDBu?=
 =?utf-8?B?S3lSYXNlUjdHZVpVVUhEVThabkJncmJOVDVXZ2hOMnhZRDc4YW0xTWkyeEFR?=
 =?utf-8?B?TFIwQVlSMzAvUU5FT3F1d0MzckFXT1g5bGQrd2ljT3dCaXVoeHVlTGVzV1VI?=
 =?utf-8?B?YkdTMHBzaHU4cUtpd2plUFUvOTQ4RW92aXdmc013NUZXbnc2bzJhQk94Qzk3?=
 =?utf-8?B?RUgzSlJZOUpHQzdQeE1hbFlsL2FSS09aN3J0S213VGlCOVZZczhaRDJ0Z0l1?=
 =?utf-8?B?TGFYNlNCdVZlNU9hbzRBV3VtRkFKeURHUVN6OFZEU0RlN2xxZythalljRkF0?=
 =?utf-8?B?N1o2R3ZiV3ZkVkRRa3NWNTh1aTRBZzd1UjlZNDRxQ09TeUJ2S2x4cjNudlF0?=
 =?utf-8?B?ZTVabWxCUzBtZ1lZUkd6Q2FGdXpMOGZudmZza0ZGTGNPR2FBdE4xUEtCUFIr?=
 =?utf-8?B?N1ZIaXhkQ0JHN0RxVVM0aTVWbmRRN1FxQlVJRVdqTlpTM0YzUDVveGltUUd2?=
 =?utf-8?B?MnI2VEU3bFpwOEFCZ1FSVHV6bklTSElwWTV6VmFPUngyR0tmVjZ5ZTFuVk9u?=
 =?utf-8?B?Umc9PQ==?=
X-OriginatorOrg: siemens.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3c25db51-7ed1-454e-3daf-08dc8c45d712
X-MS-Exchange-CrossTenant-AuthSource: AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jun 2024 07:44:37.0497
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 72yr9zulkqW/OnGWvPKu+4BiJ2vfo0R9rhUQTbjmBZnhE5MiyQhjxVj6eyLRGKSdhcj+8Q7pHV+TbsoDp7ekmw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA2PR10MB8718

On 26.03.24 19:56, Andrew Davis wrote:
> These SerDes lane select muxes use bits from the same register as
> the SerDes clock select mux. Make the lane select mux a child
> of the SerDes control node.
> 
> This removes one more requirement on scm-conf being a syscon node
> which will later be converted to fix a couple DTS check warnings.
> 
> Signed-off-by: Andrew Davis <afd@ti.com>
> ---
>  arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 21 +++++++++++++--------
>  1 file changed, 13 insertions(+), 8 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> index 738c5c4acbcd2..5ce67e6a33600 100644
> --- a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> @@ -66,7 +66,7 @@ serdes0: serdes@900000 {
>  		assigned-clock-parents = <&k3_clks 153 8>, <&k3_clks 153 4>;
>  		ti,serdes-clk = <&serdes0_clk>;
>  		#clock-cells = <1>;
> -		mux-controls = <&serdes_mux 0>;
> +		mux-controls = <&serdes0_mux 0>;
>  	};
>  
>  	serdes1: serdes@910000 {
> @@ -81,7 +81,7 @@ serdes1: serdes@910000 {
>  		assigned-clock-parents = <&k3_clks 154 9>, <&k3_clks 154 5>;
>  		ti,serdes-clk = <&serdes1_clk>;
>  		#clock-cells = <1>;
> -		mux-controls = <&serdes_mux 1>;
> +		mux-controls = <&serdes1_mux 0>;
>  	};
>  
>  	main_uart0: serial@2800000 {
> @@ -485,18 +485,23 @@ scm_conf: scm-conf@100000 {
>  		serdes0_clk: clock@4080 {
>  			compatible = "ti,am654-serdes-ctrl", "syscon";
>  			reg = <0x4080 0x4>;
> +
> +			serdes0_mux: mux-controller {
> +				compatible = "mmio-mux";
> +				#mux-control-cells = <1>;
> +				mux-reg-masks = <0x0 0x3>; /* lane select */
> +			};
>  		};
>  
>  		serdes1_clk: clock@4090 {
>  			compatible = "ti,am654-serdes-ctrl", "syscon";
>  			reg = <0x4090 0x4>;
> -		};
>  
> -		serdes_mux: mux-controller {
> -			compatible = "mmio-mux";
> -			#mux-control-cells = <1>;
> -			mux-reg-masks = <0x4080 0x3>, /* SERDES0 lane select */
> -					<0x4090 0x3>; /* SERDES1 lane select */
> +			serdes1_mux: mux-controller {
> +				compatible = "mmio-mux";
> +				#mux-control-cells = <1>;
> +				mux-reg-masks = <0x0 0x3>; /* lane select */
> +			};
>  		};
>  
>  		dss_oldi_io_ctrl: dss-oldi-io-ctrl@41e0 {

This change breaks serdes setup on the IOT2050 SM (k3-am6548-iot2050-
advanced-sm.dts), possibly on more of our devices as well:

platform 5500000.pcie: deferred probe pending: platform: supplier 900000.serdes not ready
platform 900000.serdes: deferred probe pending: (reason unknown)

And PCI remains unavailable. Digging a bit into it, it seems the change 
is causing a circular consumer/provider dependency between serdes0 and 
serdes1:

root@iot2050-debian:~# ls -l /sys/bus/platform/devices/900000.serdes/
total 0
lrwxrwxrwx 1 root root    0 Jun 14 07:10 consumer:platform:5500000.pcie -> ../../../virtual/devlink/platform:900000.serdes--platform:5500000.pcie
lrwxrwxrwx 1 root root    0 Jun 14 07:10 consumer:platform:910000.serdes -> ../../../virtual/devlink/platform:900000.serdes--platform:910000.serdes
-rw-r--r-- 1 root root 4096 Jun 14 07:10 driver_override
-r--r--r-- 1 root root 4096 Jun 14 07:10 modalias
lrwxrwxrwx 1 root root    0 Jun 14 07:10 of_node -> ../../../../firmware/devicetree/base/bus@100000/serdes@900000
drwxr-xr-x 2 root root    0 Jun 14 07:10 power
lrwxrwxrwx 1 root root    0 Jun 14 07:00 subsystem -> ../../../../bus/platform
lrwxrwxrwx 1 root root    0 Jun 14 07:10 supplier:platform:44083000.system-controller:clock-controller -> ../../../virtual/devlink/platform:44083000.system-controller:clock-controller--platform:900000.serdes
lrwxrwxrwx 1 root root    0 Jun 14 07:10 supplier:platform:44083000.system-controller:power-controller -> ../../../virtual/devlink/platform:44083000.system-controller:power-controller--platform:900000.serdes
lrwxrwxrwx 1 root root    0 Jun 14 07:10 supplier:platform:910000.serdes -> ../../../virtual/devlink/platform:910000.serdes--platform:900000.serdes
-rw-r--r-- 1 root root 4096 Jun 14 07:00 uevent
-r--r--r-- 1 root root 4096 Jun 14 07:10 waiting_for_supplier
root@iot2050-debian:~# ls -l /sys/bus/platform/devices/910000.serdes/
total 0
lrwxrwxrwx 1 root root    0 Jun 14 07:14 consumer:platform:900000.serdes -> ../../../virtual/devlink/platform:910000.serdes--platform:900000.serdes
-rw-r--r-- 1 root root 4096 Jun 14 07:14 driver_override
-r--r--r-- 1 root root 4096 Jun 14 07:14 modalias
lrwxrwxrwx 1 root root    0 Jun 14 07:14 of_node -> ../../../../firmware/devicetree/base/bus@100000/serdes@910000
drwxr-xr-x 2 root root    0 Jun 14 07:14 power
lrwxrwxrwx 1 root root    0 Jun 14 07:00 subsystem -> ../../../../bus/platform
lrwxrwxrwx 1 root root    0 Jun 14 07:14 supplier:platform:44083000.system-controller:clock-controller -> ../../../virtual/devlink/platform:44083000.system-controller:clock-controller--platform:910000.serdes
lrwxrwxrwx 1 root root    0 Jun 14 07:14 supplier:platform:44083000.system-controller:power-controller -> ../../../virtual/devlink/platform:44083000.system-controller:power-controller--platform:910000.serdes
lrwxrwxrwx 1 root root    0 Jun 14 07:14 supplier:platform:900000.serdes -> ../../../virtual/devlink/platform:900000.serdes--platform:910000.serdes
-rw-r--r-- 1 root root 4096 Jun 14 07:00 uevent
-r--r--r-- 1 root root 4096 Jun 14 07:14 waiting_for_supplier

Note that we normally disable serdes1 on this device as it was not 
required so far. Enabling the node does not solve the issue, though:

platform 5500000.pcie: deferred probe pending: platform: supplier 900000.serdes not ready
platform 900000.serdes: deferred probe pending: (reason unknown)
platform 910000.serdes: deferred probe pending: (reason unknown)

Jan

-- 
Siemens AG, Technology
Linux Expert Center