Received-SPF: pass (google.com: domain of linux-kernel+bounces-214573-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Fri, 14 Jun 2024 14:11:38 +0530
From: Jai Luthra <j-luthra@ti.com>
To: Jayesh Choudhary <j-choudhary@ti.com>
CC: <linux-kernel@vger.kernel.org>, <nm@ti.com>, <vigneshr@ti.com>,
        <robh@kernel.org>, <u-kumar1@ti.com>, <kristo@kernel.org>,
        <krzk+dt@kernel.org>, <conor+dt@kernel.org>,
        <linux-arm-kernel@lists.infradead.org>, <devicetree@vger.kernel.org>
Subject: Re: [PATCH v2] arm64: dts: ti: k3-j722s-evm: Enable analog audio
 support
Message-ID: <4jf5dh54yc3jvvhacdcx52nfsk2uhuab7dvbnjulm45uqp4dse@artxmi5a2ebu>
References: <20240612051246.41117-1-j-choudhary@ti.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20240612051246.41117-1-j-choudhary@ti.com>

Hi Jayesh,

Thanks for the patch.

On Jun 12, 2024 at 10:42:46 +0530, Jayesh Choudhary wrote:
> The audio support on J722S-EVM is using TLV320AIC3106[0] codec
> connected to McASP1 serializers.
> 
> - Add the nodes for sound-card, audio codec and McASP1.
> - Add hog for TRC_MUX_SEL to select between McASP and TRACE signals
> - Add hogs for GPIO_AUD_RSTn and MCASP1_FET_SEL which is used to
>   switch between HDMI audio and codec audio.
> - Add pinmux for MCASP1 and AUDIO_EXT_REFCLK1.
> - Add syscon node for audio_refclk1 to set the enable bit in
>   CTRL_MMR reg and select the parent clock for the external clock.
> 
> [0]: <https://www.ti.com/lit/gpn/TLV320AIC3106>
> 
> Signed-off-by: Jayesh Choudhary <j-choudhary@ti.com>

Reviewed-By: Jai Luthra <j-luthra@ti.com>

> ---
> 
> This patch depends upon the bcdma driver fix posted upstream:
> <https://lore.kernel.org/all/20240607-bcdma_chan_cnt-v2-1-bf1a55529d91@ti.com/>
> 
> v1 patch:
> <https://lore.kernel.org/all/20240611082820.17442-1-j-choudhary@ti.com/>
> 
> Changelog v1->v2:
> - Fix dtb warning for pin-muxing
> 
>  arch/arm64/boot/dts/ti/k3-j722s-evm.dts | 121 ++++++++++++++++++++++++
>  1 file changed, 121 insertions(+)
> 
[...]
> 

-- 
Thanks,
Jai

GPG Fingerprint: 4DE0 D818 E5D5 75E8 D45A AFC5 43DE 91F9 249A 7145