Received-SPF: pass (google.com: domain of linux-kernel+bounces-214605-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: John Garry <john.g.garry@oracle.com>
To: axboe@kernel.dk, paolo.valente@unimore.it
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
        jiapeng.chong@linux.alibaba.com, hch@lst.de,
        John Garry <john.g.garry@oracle.com>
Subject: [PATCH 0/3] Some block sparse fixes
Date: Fri, 14 Jun 2024 09:03:42 +0000
Message-Id: <20240614090345.655716-1-john.g.garry@oracle.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?uJc3LM6ntn0aXSOsliGkvau0jdMJ7g9zgTYxvBtRItJk0kauG+TBwzgqdrAJ?=
 =?us-ascii?Q?7ZKUnp6ohBtd/eNybkTbOEmtXO48J0O9hRjDNE5Ru/PLRefaTUw8V8GLxMdR?=
 =?us-ascii?Q?hT79j80KEyVP+BnAiHj/XZ++kpC4vT3S9s9V72eX64f81Mbb9G3ldJ1b+FnI?=
 =?us-ascii?Q?mXg5wLR80qfNXkV3aijT69yaW5qgsMlvJGiItZlSySvVCWEWxxxTKampQjIW?=
 =?us-ascii?Q?dHnTMywdczHx5/CwvaUIj4u+hA/I6RW8j8tCtJWLQuHp+eeLLX9H1B8QLmcU?=
 =?us-ascii?Q?0CFua0ycFy2qsbYoLR5a9Dntrd6CLHEVZt3vvK+R9fCySjPeOasJ31i+y05d?=
 =?us-ascii?Q?j53u7qVxKTkz9e1PoPivBBzjFGuWscBZBpUyPhpDgljP5uWMYbaFuxjMhcyc?=
 =?us-ascii?Q?iebRhqWtp9xDNTFhMVEcdO2Fp4an3GjHT9CL/E1skviBm/yfYDJBTe+UK971?=
 =?us-ascii?Q?ltJIJyzKWxD4D/o6dKPyEbfI0fS78z+4BalcYPofIQmANcVLKkntefglhnO4?=
 =?us-ascii?Q?iHyn8BuU/nvwYHYOxIUVokNLpfXVyWn4EMUBmI60YszcYXy7OLGuOa2XmeYE?=
 =?us-ascii?Q?VTI25J5XDCMdkCuHc545Trt9IQKzEEw2/AyG6IKFH6lFCzicadxeKy4bHJHG?=
 =?us-ascii?Q?VwxEARk1QLJObBWOIpLJiN8z4kAGJ426AAxkzJjM912dEHLTYkD2Qkm+2vpP?=
 =?us-ascii?Q?QF9CK58Hclad0ubgNw5xOUxphaKgL2s9dnx3blXFdoh3TRQTg+mdCoE1YfgA?=
 =?us-ascii?Q?G3iUaPbiQZTBlnFnzmziwCsO97ShaMwmwCUzjKqkFTPXT5KfV0PVbYlwWgwJ?=
 =?us-ascii?Q?4svkjhZqXO0vQrvPyMxZ6M2llTxnEMJgf+X3DZyjPrpcvt/xlY0tZR0jvW5Y?=
 =?us-ascii?Q?eUHGiT0NYjV3UotK5X7QcHXyyHTfLXTX46cPoFxD88FnU3Fuwe4YYmGDlH/S?=
 =?us-ascii?Q?lhykw3SlcmX2eLHBEf8SOvAy1DhiAc/VQ8IsUFfZayUnhXC4YgC0ynd/PHqK?=
 =?us-ascii?Q?2meaoVh1d8KIA8221S6L/6jZwaKCQUqd/oHyyT3CQ4C8Xwm7ZD2TMVhtJJ1I?=
 =?us-ascii?Q?9qIHGPdfPVBrJhZeN7LML62tV1kAZdb1KNEO4xWGkGhnKbWnxkg5gEvaWUw0?=
 =?us-ascii?Q?+cBBVCuI7pQm/KIXmeZ8WCavo4Y5+rtOBqPKuE+h1yzfZdzBYJvbuA3tdP0x?=
 =?us-ascii?Q?5ieJ43N1vxj1nOmRccJaeJiUeiTBOQSRIJvtPz03wNr7ye5WRCKeDklYjb6g?=
 =?us-ascii?Q?8Gg0LhUQEFqCrs8C7xOTJuFLyhFF4k1AP0Y4hzrz9TBsUHpF/by3Ymb6ymX5?=
 =?us-ascii?Q?ARYq9dLmQbUuMwE3U/nKJFde0+oujDi34z0ENpNa1t2QAipjFMlf22FOpyov?=
 =?us-ascii?Q?wv4rgXszP/G4UVEEwmo8E7rO2SeqpHktWk+6rFWLmxbZBOUnbGlELddY7QJA?=
 =?us-ascii?Q?CDRX1WBKGDMfGjUzo604Rqct9N9X36h+HqnAgZ3b1IZAL1MldsW6D1IrcTTw?=
 =?us-ascii?Q?1OAA8ESbgREbpSrkkRgz+3EfMVemMCiTuO/OHw43tPfPtTDhAS0JBwpU4XPe?=
 =?us-ascii?Q?USXr44BrOVpvkfagpJ2mss66HP5T4h2dIzArBUyYIGJqUYcNe0ccklk7q0AO?=
 =?us-ascii?Q?0w=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	OtP4+7hJrvlSXmq41Bck2xopqdANsNf1kou94xOkUX4umfD7yfeTYLo8Y9CB3NDj5ahG4Df4HFw34v5NrlkRyFiKr/CWHkyJRSFiWhSvdtxNV2RGCrAwHA8lZ2LjIG8EThpOZ1j0lSD0X79H041d8gQra5C8tD/qWVF1ahCta8LEl+7ZbJYohzPzjA1p1pMl2Fyf1mOKSscDYpkDuco+BIQ/LrV3NIKhkCxGxarGqNkwId/bLZhpHL2+SV9EvzsPgIXlM4uKdL6wih3DA0L9XlQpMgukFTqm/IAIPlJjdcQK4srr9QxkoGcVoEiYsf49P6uqP5gIirXPvZLbPVWEGrhMgiQmgy7exaQBIkmPNf4BulVU4OQ2quAkdsShUp824DHP7ihFkSQpOjyjnuhnfkHU7ouRM+jbcptn5KTJyOftRy5r3xEDI7IrxI2qJ4frbx4I8JlRLCLKL0EP21kY3q/fYRbNgmkhlLtd5uI10xmPCi2oRgp1rFuUN/UnFiNZLtyfmzFejWVTleJBz42u0f2d36m2JSJvrZbFluUfwEfuf/ZpK+922krjgbCdhxyFR+0xWQcyXFETsJxKlJYObRx3wfhV43cMAb23tM0dMT8=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f7a2d8c7-7f1c-4a7a-fa2a-08dc8c50eb37
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jun 2024 09:03:55.2551
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: TqpLuK2wutBS+R0ZuXrKcRvlJW6H/Xu05NjjdInXxqYMvxLZ+eHILHRqINRci0FStPAzP+/bNjhJUfTk0YrHkg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR10MB8105
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16
 definitions=2024-06-13_15,2024-06-13_02,2024-05-17_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=806 adultscore=0
 phishscore=0 suspectscore=0 malwarescore=0 mlxscore=0 spamscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2405010000 definitions=main-2406140061
X-Proofpoint-GUID: gQhU8tHiCAgloQITOn_AFb7Ge3LopG5-
X-Proofpoint-ORIG-GUID: gQhU8tHiCAgloQITOn_AFb7Ge3LopG5-

Branches for-6.11/block and block-6.10 both have the following sparse
build issues:

block/bdev.c:388:17: warning: symbol 'blockdev_mnt' was not declared.
Should it be static?
block/blk-settings.c:266:9: warning: context imbalance in
'queue_limits_commit_update' - wrong count at exit
block/blk-cgroup.c:834:5: warning: context imbalance in
'blkg_conf_prep' - wrong count at exit
block/blk-cgroup.c:965:9: warning: context imbalance in
'blkg_conf_exit' - wrong count at exit
block/blk-iocost.c:732:9: warning: context imbalance in 'iocg_lock' -
wrong count at exit
block/blk-iocost.c:743:28: warning: context imbalance in 'iocg_unlock'
- unexpected unlock
block/blk-zoned.c:595:30: warning: context imbalance in
'disk_get_and_lock_zone_wplug' - wrong count at exit
block/blk-zoned.c: note: in included file (through include/linux/blkdev.h):
./include/linux/bio.h:592:9: warning: context imbalance in
'blk_zone_wplug_handle_write' - unexpected unlock
block/blk-zoned.c:1747:31: warning: context imbalance in
'blk_revalidate_seq_zone' - unexpected unlock
block/bfq-iosched.c:5498:9: warning: context imbalance in
'bfq_exit_icq' - different lock contexts for basic block

This series contains changes to resolve some of those issues. Some issues
are not addressed, as follows:
- for zoned stuff, as mentioned by Damien at [0], they are not worth
  solving
- for blk-iocost.c issues, at [1] Tejun says that lockdep does a better
  job (than sparse)
- for blk-cgroup.c issues, at [2] again Tejun says that lockdep does a
  better job

I am reposting the patch from Jiapeng Chong, as it was never picked up.

[0] https://lore.kernel.org/linux-block/5e04760e-1334-4514-b2d0-be0d7df33865@kernel.org/
[1] https://lore.kernel.org/linux-block/ZmtwqDsMnTJHQB6o@slm.duckdns.org/
[2] https://lore.kernel.org/lkml/Y7x9t+4EwXFl7OwS@slm.duckdns.org/

Jiapeng Chong (1):
  bdev: make blockdev_mnt static

John Garry (2):
  block: Drop locking annotation for limits_lock
  block: BFQ: Refactor bfq_exit_icq() to silence sparse warning

 block/bdev.c           |  2 +-
 block/bfq-iosched.c    | 38 ++++++++++++++++++++------------------
 block/blk-settings.c   |  1 -
 include/linux/blkdev.h |  1 -
 4 files changed, 21 insertions(+), 21 deletions(-)

-- 
2.31.1