Received-SPF: pass (google.com: domain of linux-kernel+bounces-214609-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: Pankaj Gupta <pankaj.gupta@nxp.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
CC: Jonathan Corbet <corbet@lwn.net>, Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley
	<conor+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>, Pengutronix Kernel
 Team <kernel@pengutronix.de>, Fabio Estevam <festevam@gmail.com>, Rob Herring
	<robh@kernel.org>, Krzysztof Kozlowski <krzk+dt@kernel.org>,
	"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"imx@lists.linux.dev" <imx@lists.linux.dev>,
	"linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>
Subject: RE: [EXT] Re: [PATCH v2 4/5] firmware: imx: add driver for NXP
 EdgeLock Enclave
Thread-Topic: [EXT] Re: [PATCH v2 4/5] firmware: imx: add driver for NXP
 EdgeLock Enclave
Thread-Index: AQHarP9ayLdOqCtfLEqTQR0Rf+AVuLGmMeuAgAAZRgCAAAXWAIAgyBqQ
Date: Fri, 14 Jun 2024 09:05:49 +0000
Message-ID:
 <AM9PR04MB86047886B5191D94C3E68C4C95C22@AM9PR04MB8604.eurprd04.prod.outlook.com>
References: <20240523-imx-se-if-v2-0-5a6fd189a539@nxp.com>
 <20240523-imx-se-if-v2-4-5a6fd189a539@nxp.com>
 <ZlBtNSeh2VyZsVxq@pengutronix.de>
 <AM9PR04MB860424A71753DBB56D2CEF5895F52@AM9PR04MB8604.eurprd04.prod.outlook.com>
 <ZlCHTqJ0Umgh3LCw@pengutronix.de>
In-Reply-To: <ZlCHTqJ0Umgh3LCw@pengutronix.de>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?+ej4eAQhntdhORZXeWN53wFMvILO6/kah7D5WQXb48euG8dG/blNRHeo0The?=
 =?us-ascii?Q?GAi+3R9NBtrnrH7W6OsUHqoJGfYn4Lj8DjfWlBpg3KoZMZJjRqqDfRWZgby2?=
 =?us-ascii?Q?aZkL0dyp2S0CyKNNmSutNUsk6AnpGMeUA5ADySyZsn018Y06DVUuJaL/Htpq?=
 =?us-ascii?Q?pv1ZGcoxRTIjVh6hdYn0UGQZEBw548fMhUMsyXKPw+/yGEIN7SRlojHSf06q?=
 =?us-ascii?Q?SxreArXGdE9Y2YFPFE89XPVPpuM7OeHrFD7gxEtt3meiY806riK8XT6LLR7/?=
 =?us-ascii?Q?sDADPolnJ4NWdfdjNs50RaMgtzGo3Jh4ueSSUlI1/5ADEqvnDAn5YWZDzB/y?=
 =?us-ascii?Q?wP5mqn4TKPlBKQOX7Z3jVQsSREGbfg1ahucvuco0etfqbEP7I9oWqSZFk4DL?=
 =?us-ascii?Q?rOMrsMqaCMpuBfMVEiTQ1Y+FwXuUa9Nd+s0ANlfF6fZ8LRpLjXAVYWg5z79v?=
 =?us-ascii?Q?+MJzDZh0xXe+MGXqiO8AYGXxSKSGoCu27SIvExJcH0D+Z9VfuYY6aahXuAen?=
 =?us-ascii?Q?rBHW3thDdlADVT8g95OUI76N2dV5vTKVN/rSzjyFcenS+np0d19WMmdmfTWQ?=
 =?us-ascii?Q?b8nTIKzPlz1J7MHjyFTI9gM7B2nlGDJ/PXZPwrUbYj5Ot5BG1GOZMFUxCzsS?=
 =?us-ascii?Q?Gql/OmDPYdOm/jImdjxsenA4M0lLXNfOH2BRE+gjKju9GbjphvvsWDwEKenC?=
 =?us-ascii?Q?Ova3KAhic0DKfXI8uiFTweByF47Iy0Q9AMuNKor8k0dHkdcmqnenrfzm6Gsg?=
 =?us-ascii?Q?ZTx9Ogdm8MGJ0Z103StsC3XO3pJ7uTVW9bLwI3CijdVSPzgfaHU6v3veWBIi?=
 =?us-ascii?Q?iu8vghxMVyDueynjUAf5w6jKDVjjKAqMbErBbxZYqgboHUDmUVAE1Zg2bg1Q?=
 =?us-ascii?Q?DoDFQqWcI4+iyiapT1jVB4PdfSuKRz7FkiffBQs29fE3KcKASxU1qaTfQjbF?=
 =?us-ascii?Q?3Dq4uE8jqp/4KT+w8COuS12v0SuAOkpypSRMbpXe209+N5UWqGeSwPVy9IZh?=
 =?us-ascii?Q?W11dbG+bcCae35EchF9Qe/EL3iIeg4ibN1k8JRi8yX7TwJMBUS/QNbYc6cQ4?=
 =?us-ascii?Q?wWPUIRFj444QG4V9eTa5XIiqw2DSi8qBTIcrX8lB73ThHevrg+IpFptXfmKs?=
 =?us-ascii?Q?LGrYL58sRMmw2taHB/bBooQaVahJd+7jgYpzIBRB7KS3ZdBbRtx50lyVG0yp?=
 =?us-ascii?Q?J312rk8J8dGajUjh4P83hqEHlJk0UzdR203GgceDb7kH1gDyzcIkNNI7iSex?=
 =?us-ascii?Q?KqV2ne2lIgGhDgm/pzEg/VIKuGhbFh3Ygbe9yHoQyyB6MBEDKvXBGsZ7NINm?=
 =?us-ascii?Q?sRmfpxzsAKG3s3EN1zp4U6i8un/p+fpEnVN08yvIvNRrNRe6UTjUzbAreWAa?=
 =?us-ascii?Q?wEokLrEshPeB1e+mw9pONC50GlMZIl/oJ/ActAsE5HA2oDg3j5ms60Kbec2Q?=
 =?us-ascii?Q?/aq06WQLAkoooHmDhGKe3SAjhGfAi9cRhwTGZj1Qokc8t5soDQUbQsAMDGkE?=
 =?us-ascii?Q?lu1rSQiixLgnHcATWV8tmvWflRU12BgfV5HURN0+h7F/zMDnpWdOpGlnmatV?=
 =?us-ascii?Q?QtVguexkBCTepUS4vRxkVXKY4cQ3tdWJBtzbBxFI?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM9PR04MB8604.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2e90997a-5e33-4421-ee7b-08dc8c512fa4
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Jun 2024 09:05:49.8986
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: BHwN3FG3VBxVP8Eafn94DYw2fc+ACivUKk8WVtbq/fL0Ex/lLOVanQ19kJMjsLzcHe7efDpmM+I1qIoG3zKlcQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB7171


> -----Original Message-----
> From: Sascha Hauer <s.hauer@pengutronix.de>
> Sent: Friday, May 24, 2024 5:56 PM
> To: Pankaj Gupta <pankaj.gupta@nxp.com>
> Cc: Jonathan Corbet <corbet@lwn.net>; Rob Herring <robh+dt@kernel.org>;
> Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>; Conor Dooley
> <conor+dt@kernel.org>; Shawn Guo <shawnguo@kernel.org>; Pengutronix
> Kernel Team <kernel@pengutronix.de>; Fabio Estevam
> <festevam@gmail.com>; Rob Herring <robh@kernel.org>; Krzysztof
> Kozlowski <krzk+dt@kernel.org>; linux-doc@vger.kernel.org; linux-
> kernel@vger.kernel.org; devicetree@vger.kernel.org; imx@lists.linux.dev;
> linux-arm-kernel@lists.infradead.org
> Subject: Re: [EXT] Re: [PATCH v2 4/5] firmware: imx: add driver for NXP
> EdgeLock Enclave
>
> Caution: This is an external email. Please take care when clicking links =
or
> opening attachments. When in doubt, report the message using the 'Report
> this email' button
>
>
> On Fri, May 24, 2024 at 12:08:14PM +0000, Pankaj Gupta wrote:
> >
> >
> > > -----Original Message-----
> > > From: Sascha Hauer <s.hauer@pengutronix.de>
> > > Sent: Friday, May 24, 2024 4:04 PM
> > > To: Pankaj Gupta <pankaj.gupta@nxp.com>
> > > Cc: Jonathan Corbet <corbet@lwn.net>; Rob Herring
> > > <robh+dt@kernel.org>; Krzysztof Kozlowski
> > > <krzysztof.kozlowski+dt@linaro.org>; Conor Dooley
> > > <conor+dt@kernel.org>; Shawn Guo <shawnguo@kernel.org>;
> Pengutronix
> > > Kernel Team <kernel@pengutronix.de>; Fabio Estevam
> > > <festevam@gmail.com>; Rob Herring <robh@kernel.org>; Krzysztof
> > > Kozlowski <krzk+dt@kernel.org>; linux-doc@vger.kernel.org; linux-
> > > kernel@vger.kernel.org; devicetree@vger.kernel.org;
> > > imx@lists.linux.dev; linux-arm-kernel@lists.infradead.org
> > > Subject: [EXT] Re: [PATCH v2 4/5] firmware: imx: add driver for NXP
> > > EdgeLock Enclave
> > >
> > > Caution: This is an external email. Please take care when clicking
> > > links or opening attachments. When in doubt, report the message
> > > using the 'Report this email' button
> > >
> > >
> > > On Thu, May 23, 2024 at 04:19:35PM +0530, Pankaj Gupta wrote:
> > > > NXP hardware IP(s) for secure-enclaves like Edgelock Enclave(ELE),
> > > > are embedded in the SoC to support the features like HSM, SHE &
> > > > V2X, using message based communication interface.
> > > >
> > > > The secure enclave FW communicates on a dedicated messaging
> > > > unit(MU) based interface(s) with application core, where kernel is
> running.
> > > > It exists on specific i.MX processors. e.g. i.MX8ULP, i.MX93.
> > > >
> > > > This patch adds the driver for communication interface to
> > > > secure-enclave, for exchanging messages with NXP secure enclave HW
> > > > IP(s) like EdgeLock Enclave (ELE) from Kernel-space, used by
> > > > kernel management layers like
> > > > - DM-Crypt.
> > > >
> > > > Signed-off-by: Pankaj Gupta <pankaj.gupta@nxp.com>
> > > > ---
> > > >  drivers/firmware/imx/Kconfig        |  12 +
> > > >  drivers/firmware/imx/Makefile       |   2 +
> > > >  drivers/firmware/imx/ele_base_msg.c | 286 +++++++++++++++++++
> > > > drivers/firmware/imx/ele_base_msg.h |  92 +++++++
> > > >  drivers/firmware/imx/ele_common.c   | 239 ++++++++++++++++
> > > >  drivers/firmware/imx/ele_common.h   |  43 +++
> > > >  drivers/firmware/imx/se_ctrl.c      | 531
> > > ++++++++++++++++++++++++++++++++++++
> > > >  drivers/firmware/imx/se_ctrl.h      |  99 +++++++
> > > >  include/linux/firmware/imx/se_api.h |  14 +
> > > >  9 files changed, 1318 insertions(+)
> > > >
> > >
> > > > +static int se_probe_if_cleanup(struct platform_device *pdev) {
> > > > +     struct device *dev =3D &pdev->dev;
> > > > +     struct se_if_priv *priv;
> > > > +     int ret =3D 0;
> > > > +
> > > > +     priv =3D dev_get_drvdata(dev);
> > > > +     if (!priv) {
> > > > +             ret =3D 0;
> > > > +             dev_dbg(dev, "SE-MU Priv data is NULL;");
> > > > +             return ret;
> > > > +     }
> > > > +
> > > > +     if (priv->tx_chan)
> > > > +             mbox_free_channel(priv->tx_chan);
> > > > +     if (priv->rx_chan)
> > > > +             mbox_free_channel(priv->rx_chan);
> > > > +
> > > > +     /* free the buffer in se remove, previously allocated
> > > > +      * in se probe to store encrypted IMEM
> > > > +      */
> > > > +     if (priv->imem.buf) {
> > > > +             dmam_free_coherent(dev,
> > > > +                                ELE_IMEM_SIZE,
> > > > +                                priv->imem.buf,
> > > > +                                priv->imem.phyaddr);
> > > > +             priv->imem.buf =3D NULL;
> > > > +     }
> > > > +
> > > > +     if (priv->flags & RESERVED_DMA_POOL) {
> > > > +             of_reserved_mem_device_release(dev);
> > >
> > > You can call this unconditionally, no need to keep track if you
> > > called
> > > of_reserved_mem_device_init() successfully.
> >
> > But it will not be called for each SoC.
> > The memory is not reserved for i.MX95 platforms.
> > This is required.
>
> Again: You can call this unconditionally. Look at the code,
> of_reserved_mem_device_release() won't do anything if you haven't called
> of_reserved_mem_device_init() before.


Agree. Accepted and will removed in v3.

>


> Sascha
>
> --
> Pengutronix e.K.                           |                             =
|
> Steuerwalder Str. 21                       |
> http://www.p/
> engutronix.de%2F&data=3D05%7C02%7Cpankaj.gupta%40nxp.com%7Cead7b9
> 3ccacb404124bf08dc7beca6b2%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C
> 0%7C0%7C638521503534570049%7CUnknown%7CTWFpbGZsb3d8eyJWIjoi
> MC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%
> 7C%7C%7C&sdata=3DU0BX68CpPzJg%2B9IytihYTcmivJhfn7xbfIQpMp0R8o0%3D
> &reserved=3D0  |
> 31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    =
|
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 =
|