Received-SPF: pass (google.com: domain of linux-kernel+bounces-214614-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <57d4659a5abb63d7c085865059b9d71c40371edd.camel@gmail.com>
Subject: Re: [PATCH] iio: adc: adi-axi-adc: improve probe() error messaging
From: Nuno =?ISO-8859-1?Q?S=E1?= <noname.nuno@gmail.com>
To: Trevor Gamblin <tgamblin@baylibre.com>, Lars-Peter Clausen
 <lars@metafoo.de>,  Michael Hennerich <Michael.Hennerich@analog.com>,
 Jonathan Cameron <jic23@kernel.org>
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Date: Fri, 14 Jun 2024 11:11:34 +0200
In-Reply-To: <20240613163407.2147884-1-tgamblin@baylibre.com>
References: <20240613163407.2147884-1-tgamblin@baylibre.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.52.2 (3.52.2-1.fc40) 
Precedence: bulk
MIME-Version: 1.0

On Thu, 2024-06-13 at 12:34 -0400, Trevor Gamblin wrote:
> The current error handling for calls such as devm_clk_get_enabled() in
> the adi-axi-adc probe() function means that, if a property such as
> 'clocks' (for example) is not present in the devicetree when booting a
> kernel with the driver enabled, the resulting error message will be
> vague, e.g.:
>=20
> > adi_axi_adc 44a00000.backend: probe with driver adi_axi_adc failed with=
 error -2
>=20
> Change the devm_clk_get_enabled(), devm_regmap_init_mmio(), and
> devm_iio_backend_register() checks to use dev_err_probe() with some
> context for easier debugging.
>=20
> After the fix:
>=20
> > adi_axi_adc 44a00000.backend: error -ENOENT: failed to get clock
> > adi_axi_adc 44a00000.backend: probe with driver adi_axi_adc failed with=
 error -2
>=20
> Signed-off-by: Trevor Gamblin <tgamblin@baylibre.com>
> ---

Somehow feel that in these cases the error log should come from the functio=
ns we're
calling but bah... likely not going happen/change:

Reviewed-by: Nuno Sa <nuno.sa@analog.com>

(As a suggestion, you may do similar work in the axi-dac driver)

- Nuno S=C3=A1