Received-SPF: pass (google.com: domain of linux-kernel+bounces-214615-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Fri, 14 Jun 2024 11:11:48 +0200
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Carlos Llamas <cmllamas@google.com>, kernel-team@android.com,
	Alice Ryhl <aliceryhl@google.com>,
	Arve =?iso-8859-1?B?SGr4bm5lduVn?= <arve@android.com>,
	Christian Brauner <brauner@kernel.org>,
	Joel Fernandes <joel@joelfernandes.org>,
	Martijn Coenen <maco@android.com>,
	Suren Baghdasaryan <surenb@google.com>,
	Todd Kjos <tkjos@android.com>, LKML <linux-kernel@vger.kernel.org>,
	Christophe Jaillet <christophe.jaillet@wanadoo.fr>,
	John Stultz <jstultz@google.com>, Nick Chen <chenjia3@oppo.com>,
	Steven Moreland <smoreland@google.com>,
	Tim Murray <timmurray@google.com>
Subject: Re: [PATCH v5] binder: use bitmap for faster descriptor lookup
Message-ID: <2024061443-breeding-obvious-908d@gregkh>
References: <20240612042535.1556708-1-cmllamas@google.com>
 <7daafcb7-2c80-4c2a-bf25-7202634f79f0@web.de>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <7daafcb7-2c80-4c2a-bf25-7202634f79f0@web.de>

On Thu, Jun 13, 2024 at 06:50:53PM +0200, Markus Elfring wrote:
> …
> > +++ b/drivers/android/binder.c
> …
> > +static void try_shrink_dmap(struct binder_proc *proc)
> > +{
> …
> > +	binder_proc_lock(proc);
> > +	nbits = dbitmap_shrink_nbits(&proc->dmap);
> > +	binder_proc_unlock(proc);
> …
> > +	new = bitmap_zalloc(nbits, GFP_KERNEL);
> > +	binder_proc_lock(proc);
> > +	dbitmap_shrink(&proc->dmap, new, nbits);
> > +	binder_proc_unlock(proc);
> > +}
> …
> 
> Would you become interested to apply lock guards?
> https://elixir.bootlin.com/linux/v6.10-rc3/source/include/linux/cleanup.h#L124


Hi,

This is the semi-friendly patch-bot of Greg Kroah-Hartman.

Markus, you seem to have sent a nonsensical or otherwise pointless
review comment to a patch submission on a Linux kernel developer mailing
list.  I strongly suggest that you not do this anymore.  Please do not
bother developers who are actively working to produce patches and
features with comments that, in the end, are a waste of time.

Patch submitter, please ignore Markus's suggestion; you do not need to
follow it at all.  The person/bot/AI that sent it is being ignored by
almost all Linux kernel maintainers for having a persistent pattern of
behavior of producing distracting and pointless commentary, and
inability to adapt to feedback.  Please feel free to also ignore emails
from them.

thanks,

greg k-h's patch email bot