Received: by 2002:a89:413:0:b0:1fd:dba5:e537 with SMTP id m19csp679872lqs; Fri, 14 Jun 2024 02:21:05 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVwPeF/7GjOjnIiFIZvuIiit1HN7l+/xO5M70Is7PgGOJLKJAYXZvaz7wNFy3RgbG4vbNZtEUB2rSUiLDHuFr8Ij0bN3n50X3AiYE0tmQ== X-Google-Smtp-Source: AGHT+IFbGlwXiHEP/m7mntEB5TqDRgMmJRnhgAXAtbDSqMWGL9pQuuPW3dX/+ZI52So9MJyHpDB8 X-Received: by 2002:a05:6a20:2583:b0:1b0:3190:96d6 with SMTP id adf61e73a8af0-1bae7f14586mr2422362637.34.1718356865586; Fri, 14 Jun 2024 02:21:05 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1718356865; cv=pass; d=google.com; s=arc-20160816; b=skh/1Gl1kguZ7NSVmyXLKiCEvOY9f41yROGYz5K7T2QUFjY1rO8MMIZY3nFrbqDXqp K9J7mu04hGQdik8Ad9b2jjF4TMJayTnkiXK9l1Nz1B4g2rTaFznmhv5zmAQ/CijM4gd4 kwgsH6kr4BkHe539vDER8qnVNzB7u8kIbCs1G3IzPHyAU7+jRoqfKKswsYwq0mOFYtZP BogtmN0lIjB+Ea9wEriBe5NhYMcQIhK+Zu8lDBZ54Vis0W08iAqyq28EZXNmh3qVttNd TvpmfTSKG9mhY/o/GKbuvhwtkMHIHd+NUbxcVaLszvM38ukB6R2T0RL7f2Ie8ctE5kB3 XxwA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :user-agent:content-transfer-encoding:autocrypt:references :in-reply-to:date:cc:to:from:subject:message-id:dkim-signature; bh=skEW245heqx5hhkkxdwGf9ST6lRMIe/inx6ZRzBlNMw=; fh=foYVpNX6a2da9gn9JskTUzZnSkHWy9C311b2XdqiR0M=; b=OcqyddOrQ/pZbnvmkPQ0bg4ZOByC8DIPVPcO1Vcv6kZsvjxUHB+I9YLcpaNI4u7yMk 7iXKYIbWlWLqyarioERm+DDVEBpNFI8zT6ns24Eih/pKqEUF76SRb0yhCSd3j1NDUI+1 S5bOGhPhUr9seAoC1i+AXQEpL9Goe/jrp/cATcvnrSR87XQSHkoT7Xn8QV+gQSZpRu6O p3Bzj8sNH0yeTqbH7sfutFKRb5JUOp5QtbD9ozNRrRurHOZgKk6J0me69vGz1vlE4jrw 7hzsfmtHFNTdFkaqibY+Z1BAmkL5Svf91+yeyT/i32o6CKhr/O/UqYZSTZa8TnSeN6EW wspQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ZbEpUPBA; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-214620-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-214620-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id d2e1a72fcca58-705ccb3dc08si3091948b3a.163.2024.06.14.02.21.05 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Jun 2024 02:21:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-214620-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ZbEpUPBA; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-214620-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-214620-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id E8CE0B20A8A for ; Fri, 14 Jun 2024 09:16:37 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C659E1922E2; Fri, 14 Jun 2024 09:16:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ZbEpUPBA" Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 54E6818FC9F for ; Fri, 14 Jun 2024 09:16:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718356587; cv=none; b=VzyDwSrDfgasuAzb//ixifM6sI7XaPjjWWmOSHcx+BO67SqpN2Bvx2wB8MlMYcKClp58hWgdq+XoKE0suAiheX9cgGD7s4CQZi2Vp8uy5LB2hb5lE8af6FeCXUQW/FoZdOK5eXKum0L49D7ZIk2cwWyhvLgnIXdwbpn5rGLAywM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718356587; c=relaxed/simple; bh=uY7LMAy9M3Xc1LzAtkVESEKP+QJY2N1x6SoYsv+9f8k=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=I5xfawT/Kx1PpSG1GB6yEODz/zXHDJOTA8eSEwmULezTdipcDyX/xLYrtLFvQztF8M27JeHYXQu9GVvUdLM0baJsd2ehR/AwPNYhDxs/6SrOvcnA9CycB+2pvlPDs8eKKRs6f4lKlTPg3IdoObFzTapvS4Ke/qZSfUxDIYMQgJ8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=ZbEpUPBA; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1718356585; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=skEW245heqx5hhkkxdwGf9ST6lRMIe/inx6ZRzBlNMw=; b=ZbEpUPBAQ3ZcFCKxYvaycIPiIpYiO63vNK+f5bUQfZQX5VNAIoVcad6EB9lJ+0ufF3BST8 rs4MbmaqE+Omh2C/miyMms39GO1yZ7G1yceXNAi8R/8z/t0hmHJd+VuUQ+l1PlmM9rBf0y PM2QNlZHUkAr3hnMfPE2ZZywxqgcEOI= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-124-ir17U-_8OraGmikuNILUpA-1; Fri, 14 Jun 2024 05:16:21 -0400 X-MC-Unique: ir17U-_8OraGmikuNILUpA-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-354dfd4971dso276594f8f.0 for ; Fri, 14 Jun 2024 02:16:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718356580; x=1718961380; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=skEW245heqx5hhkkxdwGf9ST6lRMIe/inx6ZRzBlNMw=; b=HAOwjIQorlbnMRbC88F79azbRkr+bkU8U3ERIFqoEi1tB/jiEN/jq6W5X/lIWTM8Qf WknsDKdaq49H/vtldWdjsj9X+cVyBjA51y6C4tqRtyYtbl4PNHUapYu2BbRm1sWxAMcE fB6Y/ASestT7OCSjfuVFyl+hEsLEQ0Hq2KnM6QvF9bCgekis6+NHqoLEcTsGCfnST4dw S6PXEm0COnf7LJI4g63v0STwo2e1A/8CIe6ApAX+I21+/m5h3R2OdyGjZyCvcFjhegEu YrEsssdXV/5PRR5LZMPcKUcSnj1hfAOn+3FiK9/HHU3DcE3v2TnlDbbbIzAfxoE4bnwK 2sfw== X-Forwarded-Encrypted: i=1; AJvYcCXf7daxe1EU0SToetkuKwxOMvIpxXw0DdpP2ECXqnHE/UuEIy/GWg2fFrf1bIhfHfNWs6Egg/5Oxzpxpuxrwh9JWHCDU5YvfikvMXcj X-Gm-Message-State: AOJu0YymMkdYjWzPfdnyxN2r/MhGQGNR2fJ6lxAeYZfCsZrBH4GM5tQL 4DIrH2SlXXvcXTx1U7sBWtS8sGIUr1XmRPfSlU4mNiX39gNcLVGKQYDXXjuWeDbiwKtNt8Ou3Ty mxDveUg0ZNAvCF4c5tIHAZbLt82dKbvQ5D02/uZEWLWBuKZwTVxs0QFSe8Rptvtr05A4zE3e8 X-Received: by 2002:a05:6000:144a:b0:360:8461:9f7f with SMTP id ffacd0b85a97d-3608461a24dmr704398f8f.0.1718356580051; Fri, 14 Jun 2024 02:16:20 -0700 (PDT) X-Received: by 2002:a05:6000:144a:b0:360:8461:9f7f with SMTP id ffacd0b85a97d-3608461a24dmr704392f8f.0.1718356579705; Fri, 14 Jun 2024 02:16:19 -0700 (PDT) Received: from gerbillo.redhat.com ([2a0d:3341:b083:7210:de1e:fd05:fa25:40db]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-36075093d41sm3847285f8f.16.2024.06.14.02.16.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Jun 2024 02:16:19 -0700 (PDT) Message-ID: Subject: Re: [PATCH net-next v5 3/4] net: macb: Add ARP support to WOL From: Paolo Abeni To: Vineeth Karumanchi , nicolas.ferre@microchip.com, claudiu.beznea@tuxon.dev, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, linux@armlinux.org.uk, vadim.fedorenko@linux.dev, andrew@lunn.ch Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, git@amd.com Date: Fri, 14 Jun 2024 11:16:17 +0200 In-Reply-To: <20240611162827.887162-4-vineeth.karumanchi@amd.com> References: <20240611162827.887162-1-vineeth.karumanchi@amd.com> <20240611162827.887162-4-vineeth.karumanchi@amd.com> Autocrypt: addr=pabeni@redhat.com; prefer-encrypt=mutual; keydata=mQINBGISiDUBEAC5uMdJicjm3ZlWQJG4u2EU1EhWUSx8IZLUTmEE8zmjPJFSYDcjtfGcbzLPb63BvX7FADmTOkO7gwtDgm501XnQaZgBUnCOUT8qv5MkKsFH20h1XJyqjPeGM55YFAXc+a4WD0YyO5M0+KhDeRLoildeRna1ey944VlZ6Inf67zMYw9vfE5XozBtytFIrRyGEWkQwkjaYhr1cGM8ia24QQVQid3P7SPkR78kJmrT32sGk+TdR4YnZzBvVaojX4AroZrrAQVdOLQWR+w4w1mONfJvahNdjq73tKv51nIpu4SAC1Zmnm3x4u9r22mbMDr0uWqDqwhsvkanYmn4umDKc1ZkBnDIbbumd40x9CKgG6ogVlLYeJa9WyfVMOHDF6f0wRjFjxVoPO6p/ZDkuEa67KCpJnXNYipLJ3MYhdKWBZw0xc3LKiKc+nMfQlo76T/qHMDfRMaMhk+L8gWc3ZlRQFG0/Pd1pdQEiRuvfM5DUXDo/YOZLV0NfRFU9SmtIPhbdm9cV8Hf8mUwubihiJB/9zPvVq8xfiVbdT0sPzBtxW0fXwrbFxYAOFvT0UC2MjlIsukjmXOUJtdZqBE3v3Jf7VnjNVj9P58+MOx9iYo8jl3fNd7biyQWdPDfYk9ncK8km4skfZQIoUVqrWqGDJjHO1W9CQLAxkfOeHrmG29PK9tHIwARAQABtB9QYW9sbyBBYmVuaSA8cGFiZW5pQHJlZGhhdC5jb20+iQJSBBMBCAA8FiEEg1AjqC77wbdLX2LbKSR5jcyPE6QFAmISiDUCGwMFCwkIBwIDIgIBBhUKCQgLAgQWAgMBAh4HAheAAAoJECkkeY3MjxOkJSYQAJcc6MTsuFxYdYZkeWjW//zbD3ApRHzpNlHLVSuJqHr9/aDS+tyszgS8jj9MiqALzgq4iZbg 7ZxN9ZsDL38qVIuFkSpgMZCiUHdxBC11J8nbBSLlpnc924UAyr5XrGA99 6Wl5I4Km3128GY6iAkH54pZpOmpoUyBjcxbJWHstzmvyiXrjA2sMzYjt3Xkqp0cJfIEekOi75wnNPofEEJg28XPcFrpkMUFFvB4Aqrdc2yyR8Y36rbw18sIX3dJdomIP3dL7LoJi9mfUKOnr86Z0xltgcLPGYoCiUZMlXyWgB2IPmmcMP2jLJrusICjZxLYJJLofEjznAJSUEwB/3rlvFrSYvkKkVmfnfro5XEr5nStVTECxfy7RTtltwih85LlZEHP8eJWMUDj3P4Q9CWNgz2pWr1t68QuPHWaA+PrXyasDlcRpRXHZCOcvsKhAaCOG8TzCrutOZ5NxdfXTe3f1jVIEab7lNgr+7HiNVS+UPRzmvBc73DAyToKQBn9kC4jh9HoWyYTepjdcxnio0crmara+/HEyRZDQeOzSexf85I4dwxcdPKXv0fmLtxrN57Ae82bHuRlfeTuDG3x3vl/Bjx4O7Lb+oN2BLTmgpYq7V1WJPUwikZg8M+nvDNcsOoWGbU417PbHHn3N7yS0lLGoCCWyrK1OY0QM4EVsL3TjOfUtCNQYW9sbyBBYmVuaSA8cGFvbG8uYWJlbmlAZ21haWwuY29tPokCUgQTAQgAPBYhBINQI6gu+8G3S19i2ykkeY3MjxOkBQJiEoitAhsDBQsJCAcCAyICAQYVCgkICwIEFgIDAQIeBwIXgAAKCRApJHmNzI8TpBzHD/45pUctaCnhee1vkQnmStAYvHmwrWwIEH1lzDMDCpJQHTUQOOJWDAZOFnE/67bxSS81Wie0OKW2jvg1ylmpBA0gPpnzIExQmfP72cQ1TBoeVColVT6Io35BINn+ymM7c0Bn8RvngSEpr3jBtqvvWXjvtnJ5/HbOVQCg62NC6ewosoKJPWpGXMJ9SKsVIOUHsmoWK60spzeiJoSmAwm3zTJQnM5kRh2q iWjoCy8L35zPqR5TV+f5WR5hTVCqmLHSgm1jxwKhPg9L+GfuE4d0SWd84y GeOB3sSxlhWsuTj1K6K3MO9srD9hr0puqjO9sAizd0BJP8ucf/AACfrgmzIqZXCfVS7jJ/M+0ic+j1Si3yY8wYPEi3dvbVC0zsoGj9n1R7B7L9c3g1pZ4L9ui428vnPiMnDN3jh9OsdaXeWLvSvTylYvw9q0DEXVQTv4/OkcoMrfEkfbXbtZ3PRlAiddSZA5BDEkkm6P9KA2YAuooi1OD9d4MW8LFAeEicvHG+TPO6jtKTacdXDRe611EfRwTjBs19HmabSUfFcumL6BlVyceIoSqXFe5jOfGpbBevTZtg4kTSHqymGb6ra6sKs+/9aJiONs5NXY7iacZ55qG3Ib1cpQTps9bQILnqpwL2VTaH9TPGWwMY3Nc2VEc08zsLrXnA/yZKqZ1YzSY9MGXWYLkCDQRiEog1ARAAyXMKL+x1lDvLZVQjSUIVlaWswc0nV5y2EzBdbdZZCP3ysGC+s+n7xtq0o1wOvSvaG9h5q7sYZs+AKbuUbeZPu0bPWKoO02i00yVoSgWnEqDbyNeiSW+vI+VdiXITV83lG6pS+pAoTZlRROkpb5xo0gQ5ZeYok8MrkEmJbsPjdoKUJDBFTwrRnaDOfb+Qx1D22PlAZpdKiNtwbNZWiwEQFm6mHkIVSTUe2zSemoqYX4QQRvbmuMyPIbwbdNWlItukjHsffuPivLF/XsI1gDV67S1cVnQbBgrpFDxN62USwewXkNl+ndwa+15wgJFyq4Sd+RSMTPDzDQPFovyDfA/jxN2SK1Lizam6o+LBmvhIxwZOfdYH8bdYCoSpqcKLJVG3qVcTwbhGJr3kpRcBRz39Ml6iZhJyI3pEoX3bJTlR5Pr1Kjpx13qGydSMos94CIYWAKhegI06aTdvvuiigBwjngo/Rk5S+iEGR5KmTqGyp27o6YxZy6D4NIc6PKUzhIUxfvuHNvfu sD2W1U7eyLdm/jCgticGDsRtweytsgCSYfbz0gdgUuL3EBYN3JLbAU+UZpy v/fyD4cHDWaizNy/KmOI6FFjvVh4LRCpGTGDVPHsQXaqvzUybaMb7HSfmBBzZqqfVbq9n5FqPjAgD2lJ0rkzb9XnVXHgr6bmMRlaTlBMAEQEAAYkCNgQYAQgAIBYhBINQI6gu+8G3S19i2ykkeY3MjxOkBQJiEog1AhsMAAoJECkkeY3MjxOkY1YQAKdGjHyIdOWSjM8DPLdGJaPgJdugHZowaoyCxffilMGXqc8axBtmYjUIoXurpl+f+a7S0tQhXjGUt09zKlNXxGcebL5TEPFqgJTHN/77ayLslMTtZVYHE2FiIxkvW48yDjZUlefmphGpfpoXe4nRBNto1mMB9Pb9vR47EjNBZCtWWbwJTIEUwHP2Z5fV9nMx9Zw2BhwrfnODnzI8xRWVqk7/5R+FJvl7s3nY4F+svKGD9QHYmxfd8Gx42PZc/qkeCjUORaOf1fsYyChTtJI4iNm6iWbD9HK5LTMzwl0n0lL7CEsBsCJ97i2swm1DQiY1ZJ95G2Nz5PjNRSiymIw9/neTvUT8VJJhzRl3Nb/EmO/qeahfiG7zTpqSn2dEl+AwbcwQrbAhTPzuHIcoLZYV0xDWzAibUnn7pSrQKja+b8kHD9WF+m7dPlRVY7soqEYXylyCOXr5516upH8vVBmqweCIxXSWqPAhQq8d3hB/Ww2A0H0PBTN1REVw8pRLNApEA7C2nX6RW0XmA53PIQvAP0EAakWsqHoKZ5WdpeOcH9iVlUQhRgemQSkhfNaP9LqR1XKujlTuUTpoyT3xwAzkmSxN1nABoutHEO/N87fpIbpbZaIdinF7b9srwUvDOKsywfs5HMiUZhLKoZzCcU/AEFjQsPTATACGsWf3JYPnWxL9 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.4 (3.50.4-1.fc39) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Hi, On Tue, 2024-06-11 at 21:58 +0530, Vineeth Karumanchi wrote: > @@ -5257,6 +5247,12 @@ static int __maybe_unused macb_suspend(struct devi= ce *dev) > return 0; > =20 > if (bp->wol & MACB_WOL_ENABLED) { > + /* Check for IP address in WOL ARP mode */ > + ifa =3D rcu_dereference(__in_dev_get_rcu(bp->dev)->ifa_list); I'm sorry for the late feedback, but: - you can use rcu_access_pointer() here instead of rcu_dereference() - (much more importantly) __in_dev_get_rcu() can return a NULL pointer, you can't unconditionally dereference it. Thanks! Paolo