Date: Thu, 7 Feb 2008 10:36:55 -0800
From: Andrew Morton <akpm@linux-foundation.org>
To: Jan Kara <jack@suse.cz>
Cc: linux-kernel@vger.kernel.org, Michael Tokarev <mjt@tls.msk.ru>,
       stable@kernel.org
Subject: Re: [PATCH] quota: Turn quotas off when remounting read-only
Message-Id: <20080207103655.14ce8512.akpm@linux-foundation.org>
In-Reply-To: <20080207143721.GH6140@duck.suse.cz>
References: <20080207143721.GH6140@duck.suse.cz>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1134
Lines: 30

On Thu, 7 Feb 2008 15:37:21 +0100 Jan Kara <jack@suse.cz> wrote:

> Turn off quotas before filesystem is remounted read only. Otherwise quota will
> try to write to read-only filesystem which does no good... We could also just
> refuse to remount ro when quota is enabled but turning quota off is consistent
> with what we do on umount.
> 
> Signed-off-by: Jan Kara <jack@suse.cz>
> ---
> Andrew, this should fix the hang reported... Please apply. Thanks.
> 
> diff --git a/fs/super.c b/fs/super.c
> index ceaf2e3..945c322 100644
> --- a/fs/super.c
> +++ b/fs/super.c
> @@ -603,6 +603,7 @@ int do_remount_sb(struct super_block *sb, int flags, void *data, int force)
>  			mark_files_ro(sb);
>  		else if (!fs_may_remount_ro(sb))
>  			return -EBUSY;
> +		DQUOT_OFF(sb);
>  	}
>  
>  	if (sb->s_op->remount_fs) {

Cool.  And this is applicable to 2.6.23, 2.6.22 and even earlier, isn't it?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/