Received-SPF: pass (google.com: domain of linux-kernel+bounces-214701-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <d4c33ee4-1e91-40e5-90c8-bd793bcf34ff@kernel.org>
Date: Fri, 14 Jun 2024 12:53:37 +0300
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v6 5/8] arm64: dts: ti: k3-j722s: Move MAIN domain
 overrides to k3-j722s-main.dtsi
To: Siddharth Vadapalli <s-vadapalli@ti.com>, nm@ti.com, vigneshr@ti.com,
 afd@ti.com, kristo@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
 conor+dt@kernel.org
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
 linux-arm-kernel@lists.infradead.org, u-kumar1@ti.com, danishanwar@ti.com,
 srk@ti.com
References: <20240612132409.2477888-1-s-vadapalli@ti.com>
 <20240612132409.2477888-6-s-vadapalli@ti.com>
Content-Language: en-US
From: Roger Quadros <rogerq@kernel.org>
In-Reply-To: <20240612132409.2477888-6-s-vadapalli@ti.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

Hi Siddharth,

On 12/06/2024 16:24, Siddharth Vadapalli wrote:
> Since the MAIN domain peripherals specific to J722S SoC are present in the
> "k3-j722s-main.dtsi" file, move the overrides for the MAIN domain from the
> "k3-j722s.dtsi" file to the "k3-j722s-main.dtsi" file.

Overrides is kind of a misnomer here. It looks like these are J722S specific
changes.

> 
> Signed-off-by: Siddharth Vadapalli <s-vadapalli@ti.com>
> ---
> This patch has been newly introduced in this series and doesn't have a
> Changelog.
> 
>  arch/arm64/boot/dts/ti/k3-j722s-main.dtsi | 11 +++++++++++
>  arch/arm64/boot/dts/ti/k3-j722s.dtsi      | 11 -----------
>  2 files changed, 11 insertions(+), 11 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-j722s-main.dtsi b/arch/arm64/boot/dts/ti/k3-j722s-main.dtsi
> index 84378fc839d6..b75dab8230c2 100644
> --- a/arch/arm64/boot/dts/ti/k3-j722s-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-j722s-main.dtsi
> @@ -38,3 +38,14 @@ usb1: usb@31200000{
>  		};
>  	};
>  };
> +
> +/* MAIN domain overrides */
> +
> +&inta_main_dmss {
> +	ti,interrupt-ranges = <7 71 21>;
> +};
> +
> +&oc_sram {
> +	reg = <0x00 0x70000000 0x00 0x40000>;
> +	ranges = <0x00 0x00 0x70000000 0x40000>;
> +};
> diff --git a/arch/arm64/boot/dts/ti/k3-j722s.dtsi b/arch/arm64/boot/dts/ti/k3-j722s.dtsi
> index 1bcbc9152ff0..14c6c6a332ef 100644
> --- a/arch/arm64/boot/dts/ti/k3-j722s.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-j722s.dtsi
> @@ -232,14 +232,3 @@ cbass_wakeup: bus@b00000 {
>  
>  /* Include J722S specific peripherals */
>  #include "k3-j722s-main.dtsi"
> -
> -/* Main domain overrides */
> -
> -&inta_main_dmss {
> -	ti,interrupt-ranges = <7 71 21>;
> -};
> -
> -&oc_sram {
> -	reg = <0x00 0x70000000 0x00 0x40000>;
> -	ranges = <0x00 0x00 0x70000000 0x40000>;
> -};
These are originally set in k3-am62p-j722s-common-main.dtsi
which cannot be as they are not common to both SoCs.

Should we be moving the AM62 specific portion into k3-am62p-main.dtsi.

So they are no longer overrides but SoC specific changes?

-- 
cheers,
-roger