Received: by 2002:a89:413:0:b0:1fd:dba5:e537 with SMTP id m19csp718886lqs; Fri, 14 Jun 2024 03:54:24 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVAg3hP7alWSlLsDhRIImQteoTX/+QdhgwHtlou3iIWkCAAjoXFUR+v7wCa0b3recKpo3Kg51HhmV9Ke3wL9f6FxHGytiH2yFRFQTOvSQ== X-Google-Smtp-Source: AGHT+IGLREXv/jskzPBWPnlbLFITsJdW1Rsl728r/1msdCAau6tbU6VnZWLDcyuJrOr6YIXoNdvU X-Received: by 2002:a05:6870:f71c:b0:220:873d:dbcc with SMTP id 586e51a60fabf-25842b7b550mr2683260fac.49.1718362464479; Fri, 14 Jun 2024 03:54:24 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1718362464; cv=pass; d=google.com; s=arc-20160816; b=BzlRP182tMRsbo5EOPa0P/nqgMVHzVG/Ejkm9vJWMEdyKUNdfzaaPdoSeTNLR6J9G1 t9d4U8jq6UGmumdDJ8KO+FMYzyVs2xcahZzE7a0YXDWiEninQteaD+gw1BlKaVf6Pmbz tbEoS3YwnmZI3El3NVY8kAT6FDTfEep+W+ouEA6iB8agQs+3kubh51Oku4LKHotS7nLL K7hBs5U5ExFBzthdHnZTOYq01/ndkiXjTwVA9aXlftyGJQ/azbxMSH5Gti3As0wJgw69 ZT4QtxRoUFirenftaGBwBoISoVOfIsgAIk4NLpbPeTFvM8YoOvOqDm88LgbycM+sD3GF PIBA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:dkim-signature:from; bh=xG1AQXuw8xV0an8P6VCKByYew/mF3CYP7qNVxhJkJ7A=; fh=GnkFJqtJsGpmUoGxtwwwgkWmP/eqZ8OFCnL6dlWeDJE=; b=T6/cBF5GPJm5mZl06wDygfy9NepNQsiRruwwKFmR3p8CwhXvv/rKpmNK6tYawT80hO 0d5kROeUkH7YFBoiXWwKaahTgQrKM1L2bhXxypbc4hS/tUOIOoTNMAMEhEcf5+JIs8va fVDGSu4lSsIL4fntB+MCjYOShf+aaoFat4Or9NdKHVTj9Fhs5mPk5Cnuv6Y21haQd2OM 3R3L2T5A8RCcT+DEHNBbyzL1R72FuERmGah901RlOcQyeD7BzVhP1VRjq+6dRbw03EFV Xb6Ttz2mS5M6snnPlRBU25tLImj3La/+2xKausHlLl94CSN2CA4kSKaabW5EOLZMUU2i yrWw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@swemel.ru header.s=mail header.b=OFslIQ+A; arc=pass (i=1 spf=pass spfdomain=swemel.ru dkim=pass dkdomain=swemel.ru dmarc=pass fromdomain=swemel.ru); spf=pass (google.com: domain of linux-kernel+bounces-214760-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-214760-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=swemel.ru Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id d2e1a72fcca58-705ccb3dbe7si3264230b3a.217.2024.06.14.03.54.24 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Jun 2024 03:54:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-214760-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@swemel.ru header.s=mail header.b=OFslIQ+A; arc=pass (i=1 spf=pass spfdomain=swemel.ru dkim=pass dkdomain=swemel.ru dmarc=pass fromdomain=swemel.ru); spf=pass (google.com: domain of linux-kernel+bounces-214760-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-214760-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=swemel.ru Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 11A91B29426 for ; Fri, 14 Jun 2024 10:20:57 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0930519922E; Fri, 14 Jun 2024 10:18:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=swemel.ru header.i=@swemel.ru header.b="OFslIQ+A" Received: from mx.swemel.ru (mx.swemel.ru [95.143.211.150]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6931A19754A; Fri, 14 Jun 2024 10:18:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.143.211.150 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718360317; cv=none; b=TcBuutl1YVmPWCtJnw5ayQIsPoD22u9sjgV5d0dkbMGRFlnrSBuimBsTpYQdjr6CBegr1ecQCYKs3S6dNIxiLj1OnLDriDxiZUX7hvnBJnPmwusHnKj5jcxWKSzFSHVpeWpkn+Yb7rNFqD8qYT43IaV/6PeLBisUwKGnvGQDf6w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718360317; c=relaxed/simple; bh=9sQxTcB4tQcicv3SgwJlLxCQ8Gwg5BkPrUfSOqMLj5Q=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=ocC6yR80i4xv0lJ0CdL6UJFGn0gqdT84Ffw8/RnUFYlCnhYZUKEuUq8aH8vOE2OmKVxXqj78qdimn0auvXRDDIb+EesWSvCddRD34HMQLAJaCGGdcU+APePGuR/VraGQNIvc7b8ofJ8xdTaf86IDA4iqXbtQ1snohZYfZ5gPusA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=swemel.ru; spf=pass smtp.mailfrom=swemel.ru; dkim=pass (1024-bit key) header.d=swemel.ru header.i=@swemel.ru header.b=OFslIQ+A; arc=none smtp.client-ip=95.143.211.150 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=swemel.ru Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=swemel.ru From: Denis Arefev DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=swemel.ru; s=mail; t=1718360306; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xG1AQXuw8xV0an8P6VCKByYew/mF3CYP7qNVxhJkJ7A=; b=OFslIQ+AwLcdrvdVlRhus0hfY038/oT5zqHecaJhOhY9lt6uI87bTL1iOey3o52ki1ZfDF gD6WOhSiAxm9ZNmhg+DKmw5Cczm5h8vkHv7Hso2m3nA0tdVm70LD6/2Csf+sFx1LDR+wk5 xktdnReIjxLOvnEzl18u0YK+d7Xs4Qw= To: jiri@resnulli.us Cc: arefev@swemel.ru, edumazet@google.com, eperezma@redhat.com, jasowang@redhat.com, linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org, mst@redhat.com, netdev@vger.kernel.org, virtualization@lists.linux.dev, xuanzhuo@linux.alibaba.com Subject: [PATCH v2] net: missing check virtio Date: Fri, 14 Jun 2024 13:18:26 +0300 Message-Id: <20240614101826.30518-1-arefev@swemel.ru> In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Yeah, I was thinking of adding Fixes: But this code is new, it complements what is done. 1. check (!(ret && (hdr->gso_size > needed) && ((remainder > needed) || (remainder == 0)))) complements comit 0f6925b3e8da0 2. The setting of the SKBFL_SHARED_FRAG flag can be associated with this comit cef401de7be8c. In the skb_checksum_help function, a check for skb_has_shared_frag has been added. If the flag is not set, the skb buffer will remain non-linear, which is not good.