Received-SPF: pass (google.com: domain of linux-kernel+bounces-214811-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Content-Type: text/plain; charset="utf-8"
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <a440cbf7-c6d5-4286-a69f-05e668522931@moroto.mountain>
References: <20240613194150.2915202-1-kieran.bingham@ideasonboard.com> <a440cbf7-c6d5-4286-a69f-05e668522931@moroto.mountain>
Subject: Re: [PATCH] staging: vc04_services: vchiq_arm: Fix initialisation check
From: Kieran Bingham <kieran.bingham@ideasonboard.com>
Cc: Umang Jain <umang.jain@ideasonboard.com>, Florian Fainelli <florian.fainelli@broadcom.com>, linux-rpi-kernel@lists.infradead.org, Broadcom internal kernel review list <bcm-kernel-feedback-list@broadcom.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Stefan Wahren <wahrenst@gmx.net>, Laurent Pinchart <laurent.pinchart@ideasonboard.com>, Dave Stevenson <dave.stevenson@raspberrypi.org>, detule <ogjoneski@gmail.com>, moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE <linux-arm-kernel@lists.infradead.org>, open list:STAGING SUBSYSTEM <linux-staging@lists.linux.dev>, open list <linux-kernel@vger.kernel.org>, Julia Lawall <Julia.Lawall@inria.fr>;
To: Dan Carpenter <dan.carpenter@linaro.org>
Date: Fri, 14 Jun 2024 11:45:30 +0100
Message-ID: <171836193023.2248009.1498291832866754294@ping.linuxembedded.co.uk>
User-Agent: alot/0.10

Quoting Dan Carpenter (2024-06-13 20:58:40)
> On Thu, Jun 13, 2024 at 08:41:45PM +0100, Kieran Bingham wrote:
> > ---
> >  .../staging/vc04_services/interface/vchiq_arm/vchiq_arm.c  | 4 ++--
> >  .../staging/vc04_services/interface/vchiq_arm/vchiq_core.h | 5 +++++
> >  .../staging/vc04_services/interface/vchiq_arm/vchiq_dev.c  | 7 ++++++-
> >  3 files changed, 13 insertions(+), 3 deletions(-)
> >=20
> > diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_ar=
m.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
> > index 54467be8c371..67d853f5f2a0 100644
> > --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
> > +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
> > @@ -804,7 +804,7 @@ int vchiq_initialise(struct vchiq_state *state, str=
uct vchiq_instance **instance
> >        * block forever.
> >        */
> >       for (i =3D 0; i < VCHIQ_INIT_RETRIES; i++) {
> > -             if (state)
> > +             if (vchiq_remote_initialised(state))
> >                       break;
> >               usleep_range(500, 600);
> >       }
>=20
> :/  In the original code, this would either break on the first iteration
> or fail.  The diff looked like this:
>=20
>         for (i =3D 0; i < VCHIQ_INIT_RETRIES; i++) {
> -               state =3D vchiq_get_state();
>                 if (state)
>                         break;
>=20
> I feel bad for not spotting this.  A static checker which looked at

Definitely don't feel bad - I'm pretty sure I looked through the patch
on it's way through too and missed it then!

I only spotted this once I went deeper and was doing more rework, so it
suddenly stood out with more context.

Unfortunately - it's one of the pains of limited context in diffs in a
mail client I think.

--
Kieran


> diffs could have made this work, but all of our tools look at a momement
> in time instead of looking at the change over time.
>=20
> regards,
> dan carpenter
>