Received-SPF: pass (google.com: domain of linux-kernel+bounces-214823-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <37779db2-114c-4df6-97fd-2444bdad5529@gmx.net>
Date: Fri, 14 Jun 2024 13:00:38 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [v2 PATCH] staging: vc04_services: vchiq_arm: Fix initialisation
 check
To: Kieran Bingham <kieran.bingham@ideasonboard.com>,
 Umang Jain <umang.jain@ideasonboard.com>,
 Florian Fainelli <florian.fainelli@broadcom.com>,
 linux-rpi-kernel@lists.infradead.org,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Broadcom internal kernel review list
 <bcm-kernel-feedback-list@broadcom.com>,
 Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
 Dave Stevenson <dave.stevenson@raspberrypi.org>, detule
 <ogjoneski@gmail.com>, Dan Carpenter <dan.carpenter@linaro.org>,
 "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE"
 <linux-arm-kernel@lists.infradead.org>,
 "open list:STAGING SUBSYSTEM" <linux-staging@lists.linux.dev>,
 open list <linux-kernel@vger.kernel.org>
References: <20240614104339.3858830-1-kieran.bingham@ideasonboard.com>
Content-Language: en-US
From: Stefan Wahren <wahrenst@gmx.net>
In-Reply-To: <20240614104339.3858830-1-kieran.bingham@ideasonboard.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
UI-OutboundReport: notjunk:1;M01:P0:occl8Cm/CtM=;YElQUL7i3ZG/PImyL2wJ/77mUok
 k/F+SGxzbvFf6/oJ2rRQeJB9fFFtppZ9s+2mmp0BFJw1jS9VMXxEYCmaUNWX4QpN4gesiC5Mm
 p0HzMDaDRUVhLV4Dtf31Bxtkvk1LqFVmLvShYWdX4yYrLgLWOI6OEyJ7K5dw9QDm/MuJzEUrL
 W7RjjkdUEty5cxu5DnArW//TcAGv07FVoJB7kH0GSfQQiWVFADcfqVdIILY498CmK1PLotwyM
 bPEBIfbLHtiHbN1hS+UjdGmjboPnamGQ4bdzE+lA7oLHSrGFepImn09pXcwnrL14ZyzEhw8Sk
 P5hNmGJxRtv6PGGhrdrO8YjphzCXYj/RAsIciN6jW26yo2ozeJYrC2/++DLy2QWS5Nqvl7Qv9
 RAsa8Mr4tXYcUImPM99I340nEQM7HWriNhS95s5onfekgvOzuHymp+FyYW5vsmK6G2k3MAsZZ
 Ii9diRRyDm82ZXYiRRFCnUhD8v/4zWnxgTMTqvi71ogylPpILCS+A5233t+7nXvsprWdXS5qE
 N1qxnnmlwDzt5ZWPF94Crh2FhJCTtoSOttDyyoiN2TCxbxDHg3Rz7idpDz+r/bfQdCQWccvjZ
 kNlxwUYc8uRrfGp8O4xYTgb/xfOY/vWZlQ8WPVUQ5hC9LIdHIg+UrxPa71jcmAoeGx5DVuRk0
 PHy7PQiZEEbE+KhekwTvGHbdH/vLQc7wokCdbyFVo/ShCI7xfstSCPX+/TJelBegA8CqWn+pL
 OLDrEFHEZMWwq4wKNhUfwVQeEmzllLH+c4PF5ZzDKG/Ml7GiAVaqN22GdvLqvnzJU49kDoCHN
 o+MRHucJ908jwfAvbcySkMe38vOJZ9EBbdxEbpHfPPuAI=

Hi Kieran,

Am 14.06.24 um 12:43 schrieb Kieran Bingham:
> The vchiq_state used to be obtained through an accessor
> which would validate that the VCHIQ had been initialised
> correctly with the remote.
>
> In commit 42a2f6664e18 ("staging: vc04_services: Move global g_state to
> vchiq_state") the global state was moved to the vchiq_mgnt structures
> stored as a vchiq instance specific context. This conversion removed the
> helpers and instead replaced users of this helper with the assumption
> that the state is always available and the remote connected.
>
> Fix this broken assumption by re-introducing the logic that was lost
> during the conversion.
>
> Fixes: 42a2f6664e18 ("staging: vc04_services: Move global g_state to vchiq_state")
> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
> ---
> v2:
>   - No change, just resend
what happen to my comments for the first version?