Received-SPF: pass (google.com: domain of linux-kernel+bounces-214845-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <7f54113a-e2b4-4b7f-91fb-7e60af9ec2cf@quicinc.com>
Date: Fri, 14 Jun 2024 19:42:57 +0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net-next 1/2] net: phy: introduce core support for
 phy-mode = "10g-qxgmii"
To: "Russell King (Oracle)" <linux@armlinux.org.uk>
CC: <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
        <pabeni@redhat.com>, <robh@kernel.org>, <krzk+dt@kernel.org>,
        <conor+dt@kernel.org>, <andrew@lunn.ch>, <hkallweit1@gmail.com>,
        <corbet@lwn.net>, <vladimir.oltean@nxp.com>, <netdev@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-doc@vger.kernel.org>
References: <20240612095317.1261855-1-quic_luoj@quicinc.com>
 <20240612095317.1261855-2-quic_luoj@quicinc.com>
 <Zmqlvn2gOlxoy5Gm@shell.armlinux.org.uk>
Content-Language: en-US
From: Jie Luo <quic_luoj@quicinc.com>
In-Reply-To: <Zmqlvn2gOlxoy5Gm@shell.armlinux.org.uk>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit


On 6/13/2024 3:54 PM, Russell King (Oracle) wrote:
> On Wed, Jun 12, 2024 at 05:53:16PM +0800, Luo Jie wrote:
>> @@ -1865,7 +1872,8 @@ static int phylink_validate_phy(struct phylink *pl, struct phy_device *phy,
>>   	if (phy->is_c45 && state->rate_matching == RATE_MATCH_NONE &&
>>   	    state->interface != PHY_INTERFACE_MODE_RXAUI &&
>>   	    state->interface != PHY_INTERFACE_MODE_XAUI &&
>> -	    state->interface != PHY_INTERFACE_MODE_USXGMII)
>> +	    state->interface != PHY_INTERFACE_MODE_USXGMII &&
>> +	    state->interface != PHY_INTERFACE_MODE_10G_QXGMII)
>>   		state->interface = PHY_INTERFACE_MODE_NA;
> 
> It would be better, rather than extending this workaround, instead to
> have the PHY driver set phy->possible_interfaces in its .config_init
> method. phy->possible_interfaces should be the set of interfaces that
> the PHY _will_ use given its configuration for the different media
> speeds. I think that means just PHY_INTERFACE_MODE_10G_QXGMII for
> your configuration.
> 
> Thanks.
> 

Hi Russell,

Yes, for QCA8084(pure PHY chip), only PHY_INTERFACE_MODE_10G_QXGMII will
be set to the phy->possible_interfaces when it works on the interface
mode PHY_INTERFACE_MODE_10G_QXGMII.

I will push a new patch series to remove PHY_INTERFACE_MODE_10G_QXGMII
from this work-around validation here.

Thanks,
Jie