Received-SPF: pass (google.com: domain of linux-kernel+bounces-214828-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Fri, 14 Jun 2024 12:19:51 +0100
From: Sudeep Holla <sudeep.holla@arm.com>
To: Cristian Marussi <cristian.marussi@arm.com>
Cc: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, Peng Fan <peng.fan@nxp.com>
Subject: Re: [PATCH v2 2/2] firmware: arm_scmi: mailbox: support P2A channel
 completion
Message-ID: <ZmwnV_M3WX-4gJiH@bogus>
References: <20240510-scmi-notify-v2-0-e994cf14ef86@nxp.com>
 <20240510-scmi-notify-v2-2-e994cf14ef86@nxp.com>
 <ZmwLLoh1dbykOZZq@bogus>
 <ZmwcD-v6dCmObP_2@pluto>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZmwcD-v6dCmObP_2@pluto>

On Fri, Jun 14, 2024 at 11:31:43AM +0100, Cristian Marussi wrote:
> On Fri, Jun 14, 2024 at 10:19:42AM +0100, Sudeep Holla wrote:
> > 
> > diff --git i/drivers/firmware/arm_scmi/mailbox.c w/drivers/firmware/arm_scmi/mailbox.c
> > index adb69a6a0223..3bb3fba8f478 100644
> > --- i/drivers/firmware/arm_scmi/mailbox.c
> > +++ w/drivers/firmware/arm_scmi/mailbox.c
> > @@ -326,30 +326,25 @@ static void mailbox_fetch_notification(struct scmi_chan_info *cinfo,
> >  static void mailbox_clear_channel(struct scmi_chan_info *cinfo)
> >  {
> >         struct scmi_mailbox *smbox = cinfo->transport_info;
> > -       struct device *cdev = cinfo->dev;
> > -       struct mbox_chan *intr;
> > +       struct mbox_chan *intr_chan = NULL;
> >         int ret;
> > 
> >         shmem_clear_channel(smbox->shmem);
> > 
> > -       if (!shmem_channel_intr_enabled(smbox->shmem))
> > -               return;
> > -
> >         if (smbox->chan_platform_receiver)
> > -               intr = smbox->chan_platform_receiver;
> > +               intr_chan = smbox->chan_platform_receiver;
> >         else if (smbox->chan)
> > -               intr = smbox->chan;
> > -       else {
> > -               dev_err(cdev, "Channel INTR wrongly set?\n");
> > +               intr_chan = smbox->chan;
> > +
> > +       if (!(intr_chan && shmem_channel_intr_enabled(smbox->shmem)))
> >                 return;
> > -       }
> 
> Fine with dropping the dev_err() but is not this cumulative negated-if a
> bit cryptic...also you can bail out early straight away as before when
> platform has not required any P2A completion irq...I mean something like
>

Agreed, updated now.

-- 
Regards,
Sudeep