Received: by 2002:a89:413:0:b0:1fd:dba5:e537 with SMTP id m19csp753025lqs; Fri, 14 Jun 2024 05:01:12 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXeArKs+QYBGlg9cWFdkuoLr5YJfGU4gc7LfVGY4cCVx91ATGDXBOPrWd4SL3qm3IIzsdK1MKsOUuWN0pg5tB+JJa99o54sCPItkyRdkA== X-Google-Smtp-Source: AGHT+IFcI1c3YrC7X/Ue6EZRyQL3lci34J42c5thoISg/b5Eas4GSjIIJiM4q+X9m3DEWHePY1fe X-Received: by 2002:a50:931c:0:b0:57c:6021:f198 with SMTP id 4fb4d7f45d1cf-57cbd6a62f9mr1406893a12.36.1718366472582; Fri, 14 Jun 2024 05:01:12 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1718366472; cv=pass; d=google.com; s=arc-20160816; b=QYCOibgUsMmWmPsZUETGbbhEV3YvNVrygI2BPVja34tHXD54hRb6Xmm+LGN11qZfdF 6lE/g7EqTZjBsL2gCR375Hbc6XW1cTeJ2+F6imVh3fjjxnJSx9l4tMykMfyJjw9YqnwA 9EeMEP25XuBsk4/W7yGi2fdV9JAbQjnSnlYv9lCryi/14XLkmocVhNY6k7gxV0OdH+Ae Xb7yGfYzf6Ng7hNHA3XM+cpTBOzKp4RRpg/uqbecXmbDxyIN3VRpC2Keysh3tHmwSGlb mDlrAsA+TQ378oz/f65zzAtn9WOY6SVkefIvBsyHahSpgC//ULmIY1eeekj8Lp9mZnex 0xCQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date; bh=fx3+tEx/bRO112S5D6MlGbG6rpWnWaRFWOVaBF2ErTo=; fh=620pPFGVwhrIPDMIo33p3Rgu5/WCj4iI0nTVPcpZ7so=; b=UYsPZBHYbkT0xCA9aYE04ISXnWvCFCYlpPtIAkXX3yU71z/ZnAHcfJP2WJiGr2ytvK 5lW8zCIXPOFHWsNRrD4xeujz0Jw4MLbR8y6iZU83ZruX90Zao/1muwT0BkHj9E+0uHZr +MVXRTszbelC5wEWeAPBPgzHn2Ids7Ub/VdDUCDZ78F252gNH0OQaiaHJ0NBjwMSDY05 vrqJDTRT34emL/AQCm0tYEZP5P0TuD4FmIwlfIhXMiJZA1w8lVQLPOwl+doEO+XGxxBO clnQc5UkCMhuVJC0kSxjlcntiBAVOm0ngB11sqLCmGMMohSB0hDTS2gE9CVIoJE6upIz alIw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-214859-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-214859-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id 4fb4d7f45d1cf-57cb74411a6si1707765a12.374.2024.06.14.05.01.12 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Jun 2024 05:01:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-214859-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-214859-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-214859-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 1E70C1F21966 for ; Fri, 14 Jun 2024 12:01:12 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E58BA195FEE; Fri, 14 Jun 2024 12:01:00 +0000 (UTC) Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D4B61184108; Fri, 14 Jun 2024 12:00:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718366460; cv=none; b=sb5SKsZHw3MqCBqKQhK0tHsYJ64r47H7e9KxMFoVd0CFKsMv+GhnElIs+YmvyW8jpHkGPNJfm5xm3El9rGJikHgQqaWCSmDKWDFHr+LHIj1HykRInwAhYGNUQqABnQOjPhpf5+DCkcCzXbEHfibQ0MB52TozUIaxJEkpwktk+J4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718366460; c=relaxed/simple; bh=MgEc7xmF7iEZYhCWJxN5DpXt7Nk1yu973TKHIqqKb3Q=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Bev8hN+ZiO0AuW+BfGN75CQtR6Glk0AFIV+pqUjGZofkbemx01DwqjpgaEMBR3DohnEhkJT7qYC4x1nFRu4yeisFXVGEq1RaCC80kEDc7uqFyXpm+9lzJgqYRX+qd+m8i6H4Aln7e/q9o3emOPZHP60CtpFn/Sqh/W6M3OIArBI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.208.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ed1-f47.google.com with SMTP id 4fb4d7f45d1cf-57c73a3b3d7so2266220a12.1; Fri, 14 Jun 2024 05:00:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718366457; x=1718971257; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=fx3+tEx/bRO112S5D6MlGbG6rpWnWaRFWOVaBF2ErTo=; b=tWWc7Ol9wb5VHKWwhkimqHDLmcL0XO4HN5WnWBVD1qMjGnL5np5pfQNLUDXX74WTJy YRUfySHCXt2txUzsK73NuE5EnGhNERMjDtPYvY93QwlOv7Jqz6/7SMfwfALZoE5ZNG9Z LusVMlbVu0qbv6GvgtykXwmI0mgVyVeuxh0DeU0QcecJa3SrWhhWI5BT64EWFTjyunFN RaT4UEdkdZckhlFR+oaEAUMqQ7cWfMjhzNQbk1MA4i37TEtZPl/zpRANf0w6lDuYHAik iEvLykAUfh74oT/W4CFp6YWpylNZDqIk7Cb/V5s6LazRx8fHUx1R4yShXoMFQ4OuFlci Fhtg== X-Forwarded-Encrypted: i=1; AJvYcCUmM6nsfdt1ypXBHKKnOBMvMDTCcuKyKeF30m7CWwq6SzDU+Pul4Tsa7iDJiyS5WZCkexSCGFzs2vFkVCyH1en+LMVLFU1PXXz9Stx+FQr9Y9TczJkklBjNljH5oKNUteLq5IFR0mW0P8TetCy2oWJ+OQ3Ux+OI6jBVE0dLGzDnhOD4Gs3w X-Gm-Message-State: AOJu0YxS+NUyKiae3lhQPoCDAirBg1EsHy74UkqRvMSG+ThFbCqN+gm2 mmjchU++X/rNC3SkzFNhpsmVJeXOaDdNCZ5Cz5eU7NIpj5WjtZbv X-Received: by 2002:a50:d5c2:0:b0:573:555e:6d89 with SMTP id 4fb4d7f45d1cf-57cbd652436mr1663002a12.1.1718366456759; Fri, 14 Jun 2024 05:00:56 -0700 (PDT) Received: from gmail.com (fwdproxy-lla-007.fbsv.net. [2a03:2880:30ff:7::face:b00c]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-57cb72ce067sm2206196a12.9.2024.06.14.05.00.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Jun 2024 05:00:56 -0700 (PDT) Date: Fri, 14 Jun 2024 05:00:54 -0700 From: Breno Leitao To: Alexander Lobakin Cc: Jakub Kicinski , "David S. Miller" , Eric Dumazet , Paolo Abeni , Kees Cook , "Gustavo A. R. Silva" , Simon Horman , nex.sw.ncis.osdt.itp.upstreaming@intel.com, linux-hardening@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next] netdevice: define and allocate &net_device _properly_ Message-ID: References: <20240507123937.15364-1-aleksander.lobakin@intel.com> <20240507111035.5fa9b1eb@kernel.org> <3b08e1d0-62be-4fae-9dbb-9161992ee067@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3b08e1d0-62be-4fae-9dbb-9161992ee067@intel.com> On Wed, May 08, 2024 at 11:13:21AM +0200, Alexander Lobakin wrote: > From: Jakub Kicinski > Date: Tue, 7 May 2024 11:10:35 -0700 > > > On Tue, 7 May 2024 14:39:37 +0200 Alexander Lobakin wrote: > >> There are several instances of the structure embedded into other > >> structures, but also there's ongoing effort to remove them and we > >> could in the meantime declare &net_device properly. > > > > Is there a reason you're reposting this before that effort is completed? > > To speed up the conversion probably :D > > > The warnings this adds come from sparse and you think they should be > > ignored? > > For now... > > > > > TBH since Breno is doing the heavy lifting of changing the embedders > > it'd seem more fair to me if he got to send this at the end. Or at > > least, you know, got a mention or a CC. > > I was lazy enough to add tags, sorry. The idea of him sending this at > the end sounds reasonable. I think we are almost at the time to get rid of the last user of embedded netdev. https://lore.kernel.org/all/20240614115317.657700-1-leitao@debian.org/ Once that patch lands, I will submit this patch on top of that final fix. Let me know if you have any concern. --breno