Received-SPF: pass (google.com: domain of linux-kernel+bounces-214887-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: Jens Axboe <axboe@kernel.dk>
To: Christoph Hellwig <hch@infradead.org>, linux-block@vger.kernel.org, 
 linux-kernel@vger.kernel.org, Cyril Hrubis <chrubis@suse.cz>
Cc: Jan Kara <jack@suse.cz>
In-Reply-To: <20240613163817.22640-1-chrubis@suse.cz>
References: <20240613163817.22640-1-chrubis@suse.cz>
Subject: Re: [PATCH v2] loop: Disable fallocate() zero and discard if not
 supported
Message-Id: <171836769633.229112.12813343173922846778.b4-ty@kernel.dk>
Date: Fri, 14 Jun 2024 06:21:36 -0600
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


On Thu, 13 Jun 2024 18:38:17 +0200, Cyril Hrubis wrote:
> If fallcate is implemented but zero and discard operations are not
> supported by the filesystem the backing file is on we continue to fill
> dmesg with errors from the blk_mq_end_request() since each time we call
> fallocate() on the loop device the EOPNOTSUPP error from lo_fallocate()
> ends up propagated into the block layer. In the end syscall succeeds
> since the blkdev_issue_zeroout() falls back to writing zeroes which
> makes the errors even more misleading and confusing.
> 
> [...]

Applied, thanks!

[1/1] loop: Disable fallocate() zero and discard if not supported
      commit: 5f75e081ab5cbfbe7aca2112a802e69576ee9778

Best regards,
-- 
Jens Axboe