Received-SPF: pass (google.com: domain of linux-kernel+bounces-214870-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID:
 <OS3P286MB2490D85DD16331E5942BCEC4B1C22@OS3P286MB2490.JPNP286.PROD.OUTLOOK.COM>
Date: Fri, 14 Jun 2024 20:12:59 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3] cpufreq/cppc: Remove the desired_perf compare when set
 target
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Ionela Voinescu <ionela.voinescu@arm.com>, beata.michalska@arm.com,
 rafael@kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
 hotran@apm.com, Riwen Lu <luriwen@kylinos.cn>
References: <20240530061621.36byo5a2iqc6o2az@vireshk-i7>
 <OS3P286MB249076187B3497D1EDD70988B1F32@OS3P286MB2490.JPNP286.PROD.OUTLOOK.COM>
 <20240606090737.z3qenphikjs5ijj4@vireshk-i7> <ZmgQ06jtJBPh5wat@arm.com>
 <20240611091049.lrypvvluntf37uff@vireshk-i7>
 <OS3P286MB249073C57E2B5A36F45A02E0B1C02@OS3P286MB2490.JPNP286.PROD.OUTLOOK.COM>
 <20240612062404.yjfduze4bvgyts6a@vireshk-i7>
Content-Language: en-US
From: Riwen Lu <luriwen@hotmail.com>
In-Reply-To: <20240612062404.yjfduze4bvgyts6a@vireshk-i7>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: OS3P286MB2490:EE_|TYWP286MB3382:EE_
X-MS-Office365-Filtering-Correlation-Id: ed427f30-4eb9-49c0-1f11-08dc8c6b58bd
X-Microsoft-Antispam: BCL:0;ARA:14566002|461199025|3412199022|440099025;
X-Microsoft-Antispam-Message-Info:
	xU/zco++OmyUXubIYZn4JGW4fF6wvhq5k3SOm5YGy4INymZd+dyVoI6mRI81URiMw+wOFDM0rgkQEJ56pJci4s5ymkc01C6rP3MNzK983fv16Avm0sUe3NhWqqmCg8vxdPKvggZgclbvEZ4zOWxZh6QnzPFawgw2hy2FIGtU0JF0iVKFFzFz3IjV59XSqG98qIa2lkiGcSAVVDnOXEmF+qtfkz6YiKFtWynIH4lFm7aOLHoC99dezVBVyuLO4a6vy8UvnU5S4IwnLvlP1t0F4PJAwFiH8WGF2IL/mLnCGUw5Ar7CHeFTq6e+Pw8BUc1Amy2uzuXO8pXccAf77ZvaQL5a+5OCIiACEv2aWfDn5M4ZMZEBI7srnwt0H56yLwjkMixk/EjD0150E1oLXpWhkvqmcO01AkQOrGjE8pDrJ78C6u4baU/aTJFa37LldfgCQ1XaTHQ1seMlLaeZFQLmdPgowHqSp4F2aCpcYhcW2DcneBlFLRWpNPHD375mwaBXGPx5I4pEUlKKwrOd6yQYguCGE3LM+10kSlRbWmcI1WE5W2NCwz6BIfg+dBgo3wWh
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Z0FqWHZ6RTcrV00xR00vNkh4TTkxTm5QYnhZSWdnaWtvMEJQK1hRNnNPQUxC?=
 =?utf-8?B?cUxWd3J0RnM4cURxV2VSaGlYRjI3am1UWU9OclZVdG54SkhnMVN5ZG1IS1Ur?=
 =?utf-8?B?NjJVMVZHY3I4UlorU1B3SjBDMFN0L3RTclVGSWN4RXpKdk5XQVB5R3RmRVkw?=
 =?utf-8?B?WXJxcTM1eWJvZ0djUm5ubms1N0FNR2tiS1JoK0hCV2crVHdNYjkvQmdUWTJ5?=
 =?utf-8?B?bW1GaGpVQTJnYlp4QTNGOUwyQmF4VXBBdkh1TjJEMUQ4bUtHZ2hLT2xxa1Av?=
 =?utf-8?B?VEJwdEdHN3F2SS9SVTRwaGo3WWliQjdRVGRQRVlmSWlacCtQYklud2J1YVpk?=
 =?utf-8?B?d3hOKzZ2ajFGVUVKcDV2YThxL09QanV2cy9KV2VzMEtZeENBcFpreDVRRmNp?=
 =?utf-8?B?OUkxSUVCVjlEdUxJa21FNUtFRnlaSi93ZlFjRFhCN21Sd3F4ZzFmeTJCSEtz?=
 =?utf-8?B?U0x6ZlltVE0xNnBJVVJtOExFdXBSSkRsTm1ZSFc5enZ1cnF0VzUvd3NuU3p0?=
 =?utf-8?B?ZTEyTTFrMkdJQVQ3UFNYcnZTK0RJT2xlbFdPMU1MZFU4amlGb1A0MVlqbkQ1?=
 =?utf-8?B?a3dVQjdKYnVzMThwemt2NjNLV2pGcmYzZ0hCM1RDTFNFQnFNSTJnUXJORUlX?=
 =?utf-8?B?UzFhNTBlZXdEc0s3RUovQ2tlZXNuc1Nvb0hvVkZJNm9EbkxZZUZpQkVhdzh0?=
 =?utf-8?B?S3A2OTFUMFB2dFVxdnltWXVjVUhYOVZlOXNjYzV4M09OQ0VmdzBGbHhiZFNZ?=
 =?utf-8?B?eDdscU9KV3FwQnkzMEd2c0hiR0NRWDRwSlhHZDRKL3ozNlB2UDRnL0pYK0xm?=
 =?utf-8?B?MllCbjJCdGxMWDNKdnRNbVZmVlc3VGk0NXRma1RkL0wzN3hwL1VZSU9SNEtE?=
 =?utf-8?B?UFZnSGQ5b08wSm0zbTRJaTFhKzU2NGpMSDc3Z1RGeS9WbDZQaVhESXoyY0xI?=
 =?utf-8?B?a2pBU0Rta0NBTUlIQkFScnh3d0YyWUdWTFVUbTZHdGlGYzJySmZvMTdzQmI2?=
 =?utf-8?B?cUpHYVlsbUpYaFVMSTM5dlNlSUVCNzBWVllkU0Y5aWtORXpGVjNFeDB5QVFF?=
 =?utf-8?B?R2RwU2lRRkNWeXlHS2RQU3RsbUcvNHgxMmFtcnlhRjBENENPOXVVeHlFaFU2?=
 =?utf-8?B?ZXlIRThTa2lXRFhnbW1WQ0xiWjJMejQ2NVd0NWhxd3VCcUhTaG01RmlqY3Va?=
 =?utf-8?B?WmpsWmE2QnozVitWUjNDcFJYNWx5Z2t4K3lSNThOZ0Z1NWtHQnU0R1pSaEJr?=
 =?utf-8?B?eXZwaTA5eWlxUERTbndSSE9QY1ZXTnVmZXBsRGVMTXQrZUlxcXp1dERzbVpx?=
 =?utf-8?B?czdUaCtrREtYYUlSdW9MR29DdlF2WDlrOC9oY1RDOGJTK285ZWx3eEc2aTAx?=
 =?utf-8?B?NmNpUGFJMFlFcHhuSDVycld2ZFRudG9WQTE3YmUwT2MrRnUrc2ZwNHhUQ2dR?=
 =?utf-8?B?Si9kL3E2RjEzRGd2dTR1amZzQjdYaE9LSVpwYXorZGZzVnFyUnRlMXRiYVdy?=
 =?utf-8?B?amE0L1NQZEo1SVBVeDlMcDVrNkI4SWtBVFBDMktaSnhHL1l4SS9sM2drc1dR?=
 =?utf-8?B?VFVKZ2NHYURqdWNZQmpuOGszc1ZNQmFZcExIR2MxWHpJVU5LWnl4ZHkxYldE?=
 =?utf-8?Q?D6n/CAIDX7RbnwMdoMHm5JTbWV9UKXPdjvomrmtF4CHI=3D?=
X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-05f45.templateTenant
X-MS-Exchange-CrossTenant-Network-Message-Id: ed427f30-4eb9-49c0-1f11-08dc8c6b58bd
X-MS-Exchange-CrossTenant-AuthSource: OS3P286MB2490.JPNP286.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jun 2024 12:13:06.0332
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg:
	00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYWP286MB3382

在 2024/6/12 14:24, Viresh Kumar 写道:
> On 12-06-24, 10:52, Riwen Lu wrote:
>> I think it's no need to remove the "desired_perf" local variable here, the
>> code is seems more readable.
> 
> There is no need of a temporary variable and I don't think it increases
> readability at all. Moreover, same needs to be done in
> cppc_cpufreq_fast_switch() too.
> 
OK. I'll push a patch that remove the desired_perf temporary in 
cppc_cpufreq_fast_switch().