Received-SPF: pass (google.com: domain of linux-kernel+bounces-214702-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
Date: Fri, 14 Jun 2024 12:55:48 +0300 (EEST)
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
cc: Sebastian Reichel <sre@kernel.org>, Rob Herring <robh@kernel.org>, 
    Krzysztof Kozlowski <krzk+dt@kernel.org>, 
    Conor Dooley <conor+dt@kernel.org>, Bjorn Andersson <andersson@kernel.org>, 
    Hans de Goede <hdegoede@redhat.com>, 
    =?ISO-8859-15?Q?Ilpo_J=E4rvinen?= <ilpo.jarvinen@linux.intel.com>, 
    Bryan O'Donoghue <bryan.odonoghue@linaro.org>, 
    Heikki Krogerus <heikki.krogerus@linux.intel.com>, 
    Greg Kroah-Hartman <gregkh@linuxfoundation.org>, 
    Konrad Dybcio <konrad.dybcio@linaro.org>, linux-pm@vger.kernel.org, 
    devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, 
    platform-driver-x86@vger.kernel.org, linux-usb@vger.kernel.org, 
    linux-arm-msm@vger.kernel.org, Nikita Travkin <nikita@trvn.ru>
Subject: Re: [PATCH v7 4/6] power: supply: lenovo_yoga_c630_battery: add
 Lenovo C630 driver
In-Reply-To: <20240614-yoga-ec-driver-v7-4-9f0b9b40ae76@linaro.org>
Message-ID: <1f6ada87-ae52-dca8-96f2-0fe6f85a372a@linux.intel.com>
References: <20240614-yoga-ec-driver-v7-0-9f0b9b40ae76@linaro.org> <20240614-yoga-ec-driver-v7-4-9f0b9b40ae76@linaro.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323328-240991490-1718358948=:1013"

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323328-240991490-1718358948=:1013
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: QUOTED-PRINTABLE

On Fri, 14 Jun 2024, Dmitry Baryshkov wrote:

> On the Lenovo Yoga C630 WOS laptop the EC provides access to the adapter
> and battery status. Add the driver to read power supply status on the
> laptop.
>=20
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
>  drivers/power/supply/Kconfig                    |   9 +
>  drivers/power/supply/Makefile                   |   1 +
>  drivers/power/supply/lenovo_yoga_c630_battery.c | 500 ++++++++++++++++++=
++++++
>  3 files changed, 510 insertions(+)
>=20
> diff --git a/drivers/power/supply/Kconfig b/drivers/power/supply/Kconfig
> index 3e31375491d5..55ab8e90747d 100644
> --- a/drivers/power/supply/Kconfig
> +++ b/drivers/power/supply/Kconfig
> @@ -167,6 +167,15 @@ config BATTERY_LEGO_EV3
>  =09help
>  =09  Say Y here to enable support for the LEGO MINDSTORMS EV3 battery.
> =20
> +config BATTERY_LENOVO_YOGA_C630
> +=09tristate "Lenovo Yoga C630 battery"
> +=09depends on OF && EC_LENOVO_YOGA_C630
> +=09help
> +=09  This driver enables battery support on the Lenovo Yoga C630 laptop.
> +
> +=09  To compile the driver as a module, choose M here: the module will b=
e
> +=09  called lenovo_yoga_c630_battery.
> +
>  config BATTERY_PMU
>  =09tristate "Apple PMU battery"
>  =09depends on PPC32 && ADB_PMU
> diff --git a/drivers/power/supply/Makefile b/drivers/power/supply/Makefil=
e
> index 58b567278034..8ebbdcf92dac 100644
> --- a/drivers/power/supply/Makefile
> +++ b/drivers/power/supply/Makefile
> @@ -32,6 +32,7 @@ obj-$(CONFIG_BATTERY_DS2782)=09+=3D ds2782_battery.o
>  obj-$(CONFIG_BATTERY_GAUGE_LTC2941)=09+=3D ltc2941-battery-gauge.o
>  obj-$(CONFIG_BATTERY_GOLDFISH)=09+=3D goldfish_battery.o
>  obj-$(CONFIG_BATTERY_LEGO_EV3)=09+=3D lego_ev3_battery.o
> +obj-$(CONFIG_BATTERY_LENOVO_YOGA_C630) +=3D lenovo_yoga_c630_battery.o
>  obj-$(CONFIG_BATTERY_PMU)=09+=3D pmu_battery.o
>  obj-$(CONFIG_BATTERY_QCOM_BATTMGR)=09+=3D qcom_battmgr.o
>  obj-$(CONFIG_BATTERY_OLPC)=09+=3D olpc_battery.o
> diff --git a/drivers/power/supply/lenovo_yoga_c630_battery.c b/drivers/po=
wer/supply/lenovo_yoga_c630_battery.c
> new file mode 100644
> index 000000000000..0209cdb5546f
> --- /dev/null
> +++ b/drivers/power/supply/lenovo_yoga_c630_battery.c
> @@ -0,0 +1,500 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +/*
> + * Copyright (c) 2022-2024, Linaro Ltd
> + * Authors:
> + *    Bjorn Andersson
> + *    Dmitry Baryshkov
> + */
> +#include <linux/auxiliary_bus.h>
> +#include <linux/bits.h>

Add #include <linux/cleanup.h> for guard().

(I added it into patch 2/6 myself so you don't need to respin that=20
patch just because of it).

Once you've addressed the include and the note from Sebastian about=20
Kconfig dependencies, please add:

Reviewed-by: Ilpo J=E4rvinen <ilpo.jarvinen@linux.intel.com>

--=20
 i.
--8323328-240991490-1718358948=:1013--