Received-SPF: pass (google.com: domain of linux-kernel+bounces-214925-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Fri, 14 Jun 2024 15:01:10 +0200
From: Joel Granados <j.granados@samsung.com>
To: Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@redhat.com>,
	Will Deacon <will@kernel.org>, Waiman Long <longman@redhat.com>, Boqun Feng
	<boqun.feng@gmail.com>, Suren Baghdasaryan <surenb@google.com>, "Kent
 Overstreet" <kent.overstreet@linux.dev>, Andrew Morton
	<akpm@linux-foundation.org>, Luis Chamberlain <mcgrof@kernel.org>, Kees Cook
	<keescook@chromium.org>, "David S. Miller" <davem@davemloft.net>, "Eric
 Dumazet" <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo
	Abeni <pabeni@redhat.com>, <linux-kernel@vger.kernel.org>,
	<linux-mm@kvack.org>, <linux-fsdevel@vger.kernel.org>,
	<netdev@vger.kernel.org>
Subject: Re: [PATCH 8/8] sysctl: Warn on an empty procname element
Message-ID: <20240614130110.rovlk7be2ytkcm6x@joelS2.panther.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20240604-jag-sysctl_remset-v1-8-2df7ecdba0bd@samsung.com>
CMS-TYPE: 201P
References: <20240604-jag-sysctl_remset-v1-0-2df7ecdba0bd@samsung.com>
	<CGME20240604063006eucas1p144c1d1a90606e5cd0c1852c6270ed3e1@eucas1p1.samsung.com>
	<20240604-jag-sysctl_remset-v1-8-2df7ecdba0bd@samsung.com>

On Tue, Jun 04, 2024 at 08:29:26AM +0200, Joel Granados via B4 Relay wrote:
> From: Joel Granados <j.granados@samsung.com>
> 
> Add a pr_err warning in case a ctl_table is registered with a sentinel
> element containing a NULL procname.
> 
> Signed-off-by: Joel Granados <j.granados@samsung.com>
> ---
>  fs/proc/proc_sysctl.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/fs/proc/proc_sysctl.c b/fs/proc/proc_sysctl.c
> index 806700b70dea..f65098de5fcb 100644
> --- a/fs/proc/proc_sysctl.c
> +++ b/fs/proc/proc_sysctl.c
> @@ -1119,6 +1119,8 @@ static int sysctl_check_table(const char *path, struct ctl_table_header *header)
>  	struct ctl_table *entry;
>  	int err = 0;
>  	list_for_each_table_entry(entry, header) {
> +		if (!entry->procname)
> +			err |= sysctl_err(path, entry, "procname is null");
>  		if ((entry->proc_handler == proc_dostring) ||
>  		    (entry->proc_handler == proc_dobool) ||
>  		    (entry->proc_handler == proc_dointvec) ||
> 
> -- 
> 2.43.0
> 
> 
To add to this check, I sent out a static analysis check to smatch in
such a way that a warning will be printed out if there is a ctl_table
element with a procname or prog_handler that are NULL. You can see it
here https://lore.kernel.org/all/20240614-master-v1-1-c652f5aa15fb@samsung.com/

Best
-- 

Joel Granados