Received-SPF: pass (google.com: domain of linux-kernel+bounces-214969-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Fri, 14 Jun 2024 14:51:44 +0100
Message-ID: <86msnnk4y7.wl-maz@kernel.org>
From: Marc Zyngier <maz@kernel.org>
To: Sebastian Ene <sebastianene@google.com>
Cc: catalin.marinas@arm.com,
	james.morse@arm.com,
	jean-philippe@linaro.org,
	oliver.upton@linux.dev,
	qperret@google.com,
	qwandor@google.com,
	sudeep.holla@arm.com,
	suzuki.poulose@arm.com,
	tabba@google.com,
	will@kernel.org,
	yuzenghui@huawei.com,
	lpieralisi@kernel.org,
	kvmarm@lists.linux.dev,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	kernel-team@android.com
Subject: Re: [PATCH v3 0/4] KVM: arm64: pKVM host proxy FF-A fixes
In-Reply-To: <20240613132035.1070360-1-sebastianene@google.com>
References: <20240613132035.1070360-1-sebastianene@google.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue)
 FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.2
 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO)
Precedence: bulk
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII

On Thu, 13 Jun 2024 14:20:31 +0100,
Sebastian Ene <sebastianene@google.com> wrote:
> 
> Hello,
> 
> 
> This series contains some small fixes for the host pKVM proxy code. I included
> some of the patches that I already sent on the list as part of this series
> to make it easier to keep track of them.
> 
> I verified the functionality with OPTEE as a TEE-OS.
> 
> Changelog:
> 
> v2 -> v3:
> 
> * small fixes on the commit messages
> * applied the Review-by tags from Sudeep. Thank you Sudeep !
>  
> v1 -> v2:
> 
> * applied the feedback received from Will on the FFA_VERSION patch:
>   The spec requires that no other calls to be issued prior to the FFA
>   version negotiation and the current change reflects this. After the
>   version negotiation phase is complete with Trustzone we will just
>   return the hypervisor version.
> 
> * corrected some mistakes on the FFA_PARTITION_INFO_GET patch:
>   - don't trim the number of bytes copied from the hypervisor buffer
>   - introduce FFA_1_0_PARTITON_INFO_SZ definition
>   - simplify the logic when the input flag is specified 
> 
> * collected the Ack from Will and embbeded it in the commit - Thanks Will ! 
> 
> 
> v2:
> https://lore.kernel.org/all/20240515172258.1680881-1-sebastianene@google.com/
> 
> v1:
> 
> * previously posted FFA_PARTITION_INFO_GET patch here:
> https://lore.kernel.org/kvmarm/20240411133249.2134696-1-sebastianene@google.com/
>  -> minor changes from the previous version, look for the current
>     ffa_version in the host_buffer structure
> 
> * previously posted "Fix the identification range for the FF-A smcs" here:
> https://lore.kernel.org/kvmarm/20240322124303.309423-1-sebastianene@google.com/
> 
> Thank you,
> Sebastian
> 
> Sebastian Ene (4):
>   KVM: arm64: Trap FFA_VERSION host call in pKVM
>   KVM: arm64: Add support for FFA_PARTITION_INFO_GET
>   KVM: arm64: Update the identification range for the FF-A smcs
>   KVM: arm64: Use FF-A 1.1 with pKVM
> 
>  arch/arm64/kvm/hyp/include/nvhe/ffa.h |   2 +-
>  arch/arm64/kvm/hyp/nvhe/ffa.c         | 180 +++++++++++++++++++++-----
>  include/linux/arm_ffa.h               |   3 +
>  3 files changed, 152 insertions(+), 33 deletions(-)

Although these are labelled as fixes, I don't think they warrant being
taken into 6.10. So assuming Oliver will take them into 6.11:

Acked-by: Marc Zyngier <maz@kernel.org>

	M.

-- 
Without deviation from the norm, progress is not possible.