Received-SPF: pass (google.com: domain of linux-kernel+bounces-214973-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <6b863124-d1ce-429f-b1b6-73fc48978a6d@arm.com>
Date: Fri, 14 Jun 2024 14:57:58 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 17/35] x86/resctrl: Move mbm_cfg_mask to struct
 rdt_resource
Content-Language: en-GB
To: Dave Martin <Dave.Martin@arm.com>, x86@kernel.org,
 linux-kernel@vger.kernel.org
Cc: Fenghua Yu <fenghua.yu@intel.com>,
 Reinette Chatre <reinette.chatre@intel.com>,
 Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
 Borislav Petkov <bp@alien8.de>, H Peter Anvin <hpa@zytor.com>,
 Babu Moger <Babu.Moger@amd.com>, shameerali.kolothum.thodi@huawei.com,
 D Scott Phillips OS <scott@os.amperecomputing.com>,
 carl@os.amperecomputing.com, lcherian@marvell.com,
 bobo.shaobowang@huawei.com, "Shaopeng Tan (Fujitsu)"
 <tan.shaopeng@fujitsu.com>, baolin.wang@linux.alibaba.com,
 Jamie Iles <quic_jiles@quicinc.com>, Xin Hao <xhao@linux.alibaba.com>,
 Peter Newman <peternewman@google.com>, dfustini@baylibre.com,
 amitsinght@marvell.com, David Hildenbrand <david@redhat.com>,
 Rex Nie <rex.nie@jaguarmicro.com>
References: <20240426150537.8094-1-Dave.Martin@arm.com>
 <20240426150904.8854-1-Dave.Martin@arm.com>
 <20240426150904.8854-17-Dave.Martin@arm.com>
From: James Morse <james.morse@arm.com>
In-Reply-To: <20240426150904.8854-17-Dave.Martin@arm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

Hi Dave,

On 26/04/2024 16:08, Dave Martin wrote:
> From: James Morse <james.morse@arm.com>
> 
> The mbm_cfg_mask field lists the bits that user-space can set when
> configuring an event. This value is output via the last_cmd_status
> file.
> 
> Once the filesystem parts of resctrl are moved to live in /fs/, the
> struct rdt_hw_resource is inaccessible to the filesystem code. Because
> this value is output to user-space, it has to be accessible to the
> filesystem code.
> 
> Move it to struct rdt_resource.


>  * Reword comments to avoid being overly arch-specific.
> 
>    Is the _content_ of mbm_cfg_mask arch-independent?

This comes from the mbm_total_bytes_config, nothing in Documentation/arch/x86/resctrl.rst
says this is AMD specific, so it can be assumed to be defined by resctrl, but depending on
some hardware feature.

I'm not sure we can make this retroactively platform specific.


Thanks,

James