Received-SPF: pass (google.com: domain of linux-kernel+bounces-214978-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <7c223157-3e82-4cf8-aec7-4a7dd6e32d76@intel.com>
Date: Fri, 14 Jun 2024 15:59:14 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] idle: Remove stale RCU comment
To: Christian Loehle <christian.loehle@arm.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
CC: Daniel Lezcano <daniel.lezcano@linaro.org>, Thomas Gleixner
	<tglx@linutronix.de>, Peter Zijlstra <peterz@infradead.org>, Ingo Molnar
	<mingo@redhat.com>, Steven Rostedt <rostedt@goodmis.org>, Vincent Guittot
	<vincent.guittot@linaro.org>
References: <5b936388-47df-4050-9229-6617a6c2bba5@arm.com>
Content-Language: en-US
From: "Wysocki, Rafael J" <rafael.j.wysocki@intel.com>
In-Reply-To: <5b936388-47df-4050-9229-6617a6c2bba5@arm.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Nys4MHhDQVJiT3lwNHdtUGo5SjdqRklzYlJRTCtmOGhycmR2MjBvZEhnZHB2?=
 =?utf-8?B?ZTdrZEtXck9iUVRMeU9FWldleUhONjZKNmNTdXFQSTRiUVFBMFBvMzBabGpo?=
 =?utf-8?B?bkJLNGxZWTBEMzZmWHdtSEQyZWozRHp4TVhQNFhtNGJHVmZlM0FhRCtUaERr?=
 =?utf-8?B?SkpObnNGamZTSC8wR2JnR2N4VTBEVVVRMDdnbjZmbi9RMjBmcHdibUR6R211?=
 =?utf-8?B?T0NkOGVDb0VUejZ5emJ2WDVqNEVxNytFR1pCU0tNK0NEcWNYeVhhZ0NyR3Rq?=
 =?utf-8?B?eno1cFVwbmJHYWxJbDQwcUxCcmlTaUZBT3BHSFJ5NUdGYzEyN0FST0tVdlMz?=
 =?utf-8?B?S2l5VWVVVWJNK1NoeXNzYUxQTVdmbC9mYXZZUytmNEhFdFRlVGhpYys0aFFk?=
 =?utf-8?B?ZjJIMTJ1VDFidVJnNTRrQlBwQnRPMkRaYXRnaENHeXo4MzB0Y29oRDNUd0N0?=
 =?utf-8?B?cStVazJYeFZSR2U0RFhLMWZXWXRkcHV6Ukc2bFlYODJHVU13MmdYMzYrMWtF?=
 =?utf-8?B?RUhoZjlVSzVFbWtGTEdrRUhYMkFnRTJXSUpGWlBacDVPNjM1dVpaSHVUbHBO?=
 =?utf-8?B?T1hFbHBtVnFCWXBVbTlxaDNqNEtSeXZ1ZnN6eE1QSy8rbFJJUGJQT0diYlBm?=
 =?utf-8?B?M2loWW9jV2pMTXdrZ2FQLyt1bWxIa2Q3NiszZm9BdkdkOEcyREVxWGpySXJ2?=
 =?utf-8?B?ZXhNc2dzQm9GZFBJZGZlSGo5UDdrdFV1Z1lWSU16Wi9zNTcrREZFQzhJM2ww?=
 =?utf-8?B?dTNrVjl1Z0Z5NU1hU3hVbnYrQkFiVmpxRVlZdm5OK1ZnWXpMaXgwMGtvRTJT?=
 =?utf-8?B?YmRxaGp3WGhPRTN6MEJMS1hmZGtHT0NuTGFuMGdHTG04c1JRbGJMbnJpdTBy?=
 =?utf-8?B?Z09vdHhNOFZUSHVGQUZ5WUNGOCtiWWtlY0hyaW5LR1J4aGFLTlVPUUx5cy9X?=
 =?utf-8?B?MlZwaE5UQVNLaERjZnpqT1VFSnpNditMRWtrcDJxZ3Evc3VKZmRidElmU3Nk?=
 =?utf-8?B?WUZHN2EzOWV2eUN6Y1MyVkRxMys5MG50dVh5OFJzQnhvSUp3RUFwaWpDbCt5?=
 =?utf-8?B?L1Z4VEU2cVJTS3lIbzZoaEs3cXYwTlVnQmhhZkFZQks5RnBJZ0w2UFpneUFh?=
 =?utf-8?B?UWhDb29tazNvMmRhSHNRYUdpRUJtMmFua3ZpZnZSZ0kwRnNBMUJVWUNndzh4?=
 =?utf-8?B?ejFIMVFVREg3eFpwWHFqQUx1b1E4RG1aZnpVcGd3MkRuVzFnNXNNVlRFYkZV?=
 =?utf-8?B?RnBmck4wSm9GNzFUZEJHOVNUSHVaclk1SHNmL2FMUENHeXJMV2Q2Z3JGcU9l?=
 =?utf-8?B?c3dXTk1HVTlFN1I3Nk1tcjZaTEdGNEJaRjBnZFBOR3FtYWxvcjRmb1J3R29q?=
 =?utf-8?B?Rm1NZ3dsN3FRcUdRSWFlM0Z2RzJiemJSV0t6ckd3L1FyQ3lyb0h6UUQ2T0Nh?=
 =?utf-8?B?UTJjUEN4dm9DMFJob3o2cHlMeFM4bDgxZ3dkY2ZpT0FyZ3FHZWYvZkUvK1Vh?=
 =?utf-8?B?UkNKRkJZUUpjczNad0oyR29iNzd1K2t0ZWNHVDZ0QUhBUmpGNlhoc25TZ09p?=
 =?utf-8?B?Uk5LMUVMb3pyZXNXeU9LV2IyeFkyY2oxMkhXeGJZUjFHOVZKZlAzZ0JnUVM4?=
 =?utf-8?B?Y2VUS3ZPMFI2MzVEcXZnb05vcXhpMncrVFBOZW9QeVZjMFBoaFNKckFNNjZh?=
 =?utf-8?B?SjRKYUlWcmxDK2VVZFZGM0krQ01pQnFzUHR6NEpyeEZxYm5ndWRzTEYzYnF5?=
 =?utf-8?B?UVh3ZXJKVkNxR2wvcUFCaXF5WTBYSlNIc3V1MWJJY0RWM0hYb1JpOTNTUE9w?=
 =?utf-8?B?cEk3Y0h1aWZkYlpWZjUvZ1BJUFF0UzFId0J6SFlWcUJmLzlwTWRZbHFLODhO?=
 =?utf-8?B?YlZQOFpyU1o2UmZFdmNzaHlodWdzUkxYcUpsYmJvYzVsYmRXYnAweXNTUHo1?=
 =?utf-8?B?dUtFQzdYVXBNK2toRTlOdG1IVFNSVHp4R3hsYnExaW11L05EN0Z0K2VncXQr?=
 =?utf-8?B?c0xuNVgwOTBIdytwT2l6WEZWVkR4bkxHR1F6Yml3SVdmSlF4QjlLcERFc0ZJ?=
 =?utf-8?B?NlBWeDhSaWNrSmtleDlWVGw1aUQzQlB1enlkVGxaamkwRDhUQ2x4ZVB6aUVG?=
 =?utf-8?B?Z3RGdnpQZ0dPNXZhUzBHTXYxVGhUdEI4M3MxV2JnVjFTa1c2RWFUL2Fpa2ZJ?=
 =?utf-8?B?MHc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 2f0559c4-e163-4e54-fb2a-08dc8c7a3062
X-MS-Exchange-CrossTenant-AuthSource: MW5PR11MB5810.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jun 2024 13:59:20.8103
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mQBYARH+akHG6M7mroBPbAH9/WwwVNqrkYyseyj6PNeziTbN7me/6Ck3lCdRW79fn8Iv3eZvOiFdYB4lwZCk8Ungt90NdyV5Yodc3I8lTSk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5032
X-OriginatorOrg: intel.com

On 6/3/2024 5:30 PM, Christian Loehle wrote:
> The call of rcu_idle_enter() from within cpuidle_idle_call() was
> removed in commit 1098582a0f6c ("sched,idle,rcu: Push rcu_idle deeper
> into the idle path") which makes the comment out of place.
>
> Signed-off-by: Christian Loehle <christian.loehle@arm.com>

Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>


> ---
>   kernel/sched/idle.c | 6 ------
>   1 file changed, 6 deletions(-)
>
> diff --git a/kernel/sched/idle.c b/kernel/sched/idle.c
> index 6135fbe83d68..3cc1a592d9a1 100644
> --- a/kernel/sched/idle.c
> +++ b/kernel/sched/idle.c
> @@ -179,12 +179,6 @@ static void cpuidle_idle_call(void)
>   		return;
>   	}
>   
> -	/*
> -	 * The RCU framework needs to be told that we are entering an idle
> -	 * section, so no more rcu read side critical sections and one more
> -	 * step to the grace period
> -	 */
> -
>   	if (cpuidle_not_available(drv, dev)) {
>   		tick_nohz_idle_stop_tick();
>